Checking if a value is true in a yml file

So I'm making an online list for my guard plugin, and this is what I have so far:

Code:java

package com.gmail.mcheadgam3z.hgGuard.Commands;
 
import java.io.File;
 
import org.bukkit.Bukkit;
import org.bukkit.command.Command;
import org.bukkit.command.CommandExecutor;
import org.bukkit.command.CommandSender;
import org.bukkit.configuration.file.YamlConfiguration;
import org.bukkit.entity.Player;
 
import com.gmail.mcheadgam3z.hgGuard.Main;
 
public class HgGuards implements CommandExecutor {
    // vars
    static Main plugin;
    static File guards = new File(Main.plugin.getDataFolder(), "guards.yml");
    static YamlConfiguration guardData = YamlConfiguration
            .loadConfiguration(guards);
    // constructor
    public HgGuards(Main passedPlugin) {
        HgGuards.plugin = passedPlugin;
    }
 
    public boolean onCommand(CommandSender sender, Command cmd, String label,
            String[] args) {
        if (cmd.getName().equalsIgnoreCase("hgguards")) {
            if (sender.hasPermission("hgGuard.view")) { // change perm later
                if (sender instanceof Player) {
                    Player p = (Player) sender;
                    StringBuilder online = new StringBuilder();
                    Player[] players = Bukkit.getOnlinePlayers();
                    for (Player player : players) {
                        if (!p.canSee(player))
                            continue;
                        if (online.length() > 0) {
                            online.append(", ");
                        }
                        // check to see if online players have perm
                        if (player.hasPermission("hgGuard.duty")) {
                            for (String key : guardData
                                    .getConfigurationSection("Duty").getKeys(
                                            false)) {
                                // error below
                                if (key.contains("true")) {
                                    online.append(player.getDisplayName());
                                }
                            }
                        }
                    }
                    // send sender list
                    p.sendMessage("There are " + players.length + "/"
                            + Bukkit.getMaxPlayers() + " guards online:\n"
                            + online.toString());
                    return true;
                }
            }
        }
        return false;
    }
}
 

It was working fine, until I added

Code:java

for (String key : guardData
                                    .getConfigurationSection("Duty").getKeys(
                                            false)) {
                                // error below
                                if (key.contains("true")) {

So there is something wrong there.
What I am trying to do is search through my guards.yml file, and check to see if there is a UUID with the value of true (in this case, a string that is true 'cause contains() doesn't like booleans...) And if so, add them to the list and send the list to the player.

My guards.yml file that it is searching through looks like this:

Code:

Duty:
  394a506f-a223-3770-a364-feeea5bcea01: true

Any suggestions?

 

The key would not contain the "true", it's the value that's true.

Code:

                            for (Entry<String, Object> entrySet : guardData.getConfigurationSection("Duty").getValues(false).entrySet()) {
                                // error below
                                if (entrySet.getValue().toString().equalsIgnoreCase("true")) {
                                    online.append(player.getDisplayName());
                                }
                            }

Your new edited version that's slightly optimized (changed): http://pastie.org/private/sdkwhw3zfw9hxxrzihs1da

 

KingFaris11
It's still showing a player in the list even if their value is false. I think it's because even if it finds one value as true, it'll still add them to the list. So I guess I need to approach this from a different angle.

 

Sorry, I misread your code completely, of course this won't work.
Here's something I wrote quickly, not sure if it'll work:
http://pastie.org/private/uzyezucdjgcd41awxoxw
Although, I changed Bukkit.getMaxPlayers() to guardsOnDuty.size() since it makes sense for you to show the amount of guards on duty online out of the amount of guards on duty in total.

 

KingFaris11
Sorry about the long wait reply, somehow I didn't see this...
Anyway, it gave me a NPE on this line:

Code:java

for (Entry<String, Object> entrySet : this.guardData.getConfigurationSection("Duty").getValues(false).entrySet()) {

 

That means either your guardData is null OR Duty doesn't exist in the config OR guardData hasn't been loaded

 

KingFaris11
guardData exists, Duty exists in it's own guards.yml file, and it is getting loaded.

 

Try this:

Code:

if (this.guardData != null && this.guardData.contains("Duty") && this.guardData.isConfigurationSection("Duty")) {
    for (Map.Entry<String, Object> entrySet : this.guardData.getConfigurationSection("Duty").getValues(false).entrySet()) {
        // Do stuff.
    }
}

If it no longer throws the error but doesn't pass this statement, it means either: guardData is null, guardData does not contain "Duty" (maybe you haven't loaded guardData properly) or Duty isn't correctly a configuration section (or a Map).

I don't have time to format it, but this is how the final version should roughly look like: http://pastie.org/private/mpmhlkag03ezdlsbo8pdg

I may have added an extra } at the end of Entry set clause accidentally.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.