Check how many players there are in a world, if a certain number of players, issue a command

Hi,
Am making plugin, need to check how many players are in a world, and if there are 2 players, it will teleport them.
Here is my java code:

Code:Java

 
package me.bukkit.jabbers9999;
 
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.Location;
import org.bukkit.World;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.plugin.java.JavaPlugin;
 
 
public class Survive extends JavaPlugin {
 
    @Override
    public void onEnable() {
          getLogger().info("Survive has been enabled!");
    }
 
 
    @Override
    public void onDisable() {
 
    }
 
     public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args){
           if(commandLabel.equalsIgnoreCase("survjoin")){
               Player player = (Player) sender;
               World world = Bukkit.getWorld("survive");
               Location loc = new Location(world, -391.874,4,883.654);
               loc.add(0.5, 0, 0.5);
               loc.setPitch((float)4);
               loc.setYaw((float) -179.4);
               player.teleport(loc);
               player.sendMessage(ChatColor.BLUE + "Joining a game of survive...");
 
                  for(Player p : Bukkit.getWorld("survive").getPlayers()){
                        p.sendMessage(sender.getName() + " has joined survive!");
 
 
                        if (world.getPlayers().size() >= 2) {
                        for(Player player1 : Bukkit.getWorld("survive").getPlayers()){
                              player1.sendMessage ("round has begun!");
                          }
 
 
 
                            }
 
                        }
 
                }{
 
 
 
 
            }
                return true;}}
 
 

Thanks
Joey

 

@Jabbers9999 Please. Don't sleep the main thread (especially for 15+ minutes...)

Also, you might want to learn how to format Java code (or any langage actually), with indents and line breaks.

You check for the the size of the players in the InterruptedException catch.
Don't, just put the code after the try/catch (and remove the whole try/catch).

And you don't do anything with the size of the players, try this:

Code:

if (world.getPlayers().size() >= 2) {
    // Do something
} else {
    // Do something else
}

You can either execute a command (as the console) like that:

Code:

Bukkit.dispatchCommand(Bukkit.getConsoleSender(), "command without slash");

or teleport the players like you did with Player#teleport(Location).

 

@au2001, thanks, anyway I could split to players up? Could I possibly make it so player 1 teleports here player 2 teleports here, etc.
Thanks

 

I don't see how 1000 milliseconds (1 second) are 15+ minutes for you..

 

@FisheyLP Oh, I thought it was in seconds...

@Jabbers9999 Yes, create two locations, teleport payer1 to location1 and player2 to location2.

 

@au2001 how would i define player 1 as player 1 and player 2 as player 2?
Because normally you would just do:

Code:

player.teleport(<LOCATION>)

Just saying, here is my code now:

Code:Java

 
public class Survive extends JavaPlugin {
 
 
@Override
 
public void onEnable() {
 
      getLogger().info("Survive has been enabled!");
 
}
 
 
 
@Override
 
public void onDisable() {
 
 
}
 
 
  public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args){
 
        if(commandLabel.equalsIgnoreCase("survjoin")){
 
            Player player = (Player) sender;
 
            World world = Bukkit.getWorld("survive");
 
            Location loc = new Location(world, -391.874,4,883.654);
 
            loc.add(0.5, 0, 0.5);
 
            loc.setPitch((float)4);
 
            loc.setYaw((float) -179.4);
 
            player.teleport(loc);
 
            player.sendMessage(ChatColor.BLUE + "Joining a game of survive...");
 
 
 
            for(Player p : Bukkit.getWorld("survive").getPlayers()){
 
                    p.sendMessage(sender.getName() + " has joined survive!");
 
 
 
 
 
                    if (world.getPlayers().size() >= 4) {
                  //Here I would like it to count down from 20, then teleport player 1 to location 1 and player 2 to location 2.
                for(Player player1 : Bukkit.getWorld("survive").getPlayers()){
 
                        player1.sendMessage(sender.getName() + " round has begun!");
 
                    }
 
 
 
 
 
 
 
}
 
 
 
}
 
 
 
            }{
 
 
 

Errrr ive changed the '4' to 2 amd ive got my friend to join. It does not send the message 'round has begun!'

Code:

          if (world.getPlayers().size() >= 2) {
                for(Player player1 : Bukkit.getWorld("survive").getPlayers()){

                        player1.sendMessage(sender.getName() + " round has begun!");

                    }

                          

                          

 

@Jabbers9999

Make sure you're importing world as "org.bukkit". Also sender.getName() only gets the player who sent the command. So upon reaching the world size the last person who joined will have their name displayed to everyone playing.

 

@DuaneTheDev_
I am importing all as bukkit. Here are all my imports:

Code:

import org.bukkit.Bukkit;

import org.bukkit.ChatColor;

import org.bukkit.Location;

import org.bukkit.World;

import org.bukkit.command.Command;

import org.bukkit.command.CommandSender;

import org.bukkit.entity.Player;

import org.bukkit.plugin.java.JavaPlugin;

So its not that. And I want it to count down from ten or something when the last player joins.

 

@Jabbers9999

Your code is really horribly formatted, and barely readable.
Take a look at this: http://www.oracle.com/technetwork/java/codeconventions-150003.pdf
And if you use eclipse, try this: http://stackoverflow.com/questions/15655126/how-to-auto-format-code-in-eclipse

 

@au2001 I have now formatted, so can you please tell me how to define player 1 as player 1 and player 2 as player 2

 

A) Remove your onEnable and onDisable, you don't need them for what you are doing.
B) The reason you don't need your onEnable is because Bukkit automatically prints when the plugin is enabled.
C) Use cmd.getName().equalsIgnoreCase instead of commandLabel.equalsIgnoreCase, this allows for aliases and is just good practice
D) Don't assume that the sender is a player. Check before casting sender to player.
E) Check to see if the world "survive" actually exists. If it doesn't right now, you will get an NPE.
F) DON'T USE .bukkit for your package! Use me.(your name).(project name) instead. Using .bukkit implies that you own the domain, or you are a bukkit staff member.

 

@henderry2019 Ok i have removed OnEnable and onDisable, and changed the package name, and changed the commandLabel.equalsIgnoreCase to cmd.getName() .gonna test it out.

@henderry2019 Ok Thanks! But now it says (username) round has begun.
What I want is 'Round has begun!' once to everyone on that world
Here is my code:

Code:Java

 
package me.Jabbers9999.Survive;
 
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.Location;
import org.bukkit.World;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.plugin.java.JavaPlugin;
 
 
public class Survive extends JavaPlugin {
 
     public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args){
           if(cmd.getName().equalsIgnoreCase("survjoin")){
               Player player = (Player) sender;
               World world = Bukkit.getWorld("survive");
               Location loc = new Location(world, -391.874,4,883.654);
               loc.add(0.5, 0, 0.5);
               loc.setPitch((float)4);
               loc.setYaw((float) -179.4);
               player.teleport(loc);
               player.sendMessage(ChatColor.BLUE + "Joining a game of survive...");
 
                  for(Player p : Bukkit.getWorld("survive").getPlayers()){
                        p.sendMessage(sender.getName() + " has joined survive!");
 
 
                        if (world.getPlayers().size() >= 2) {
                        for(Player player1 : Bukkit.getWorld("survive").getPlayers()){
                              player1.sendMessage ("round has begun!");
                          }
 
 
 
                            }
 
                        }
 
                }{
 
 
 
 
            }
                return true;}}
 
 

Thanks

EDIT by Timtower: merged posts, please use the edit button instead of double posting.

 

A) Package name should be all lowercase
B) You haven't actually done steps D or E from my original post.

 

@henderry2019 The world survive does exist and can you give me some basic code for step D?

 

@timtower So how would I use instanceof?

 

@timtower All I found was: https://bukkit.org/threads/e-getentity-instanceof-player.67030/

 

Don't do the checks inside a loop, also you're looping again inside the loop.

 

int i = 0;
for(i; Bukkit.getServer().getWorld().getPlayers().size()){
i++
}
if( > 4){
//do stuff
}

 

Why do you use a for-loop?!
Just use

Code:

if (world.getPlayers().size() > 4) {

 

Thanks everyone for the support!
I won't be needing the 'for(i; Bukkit.getServer().getWorld().getPlayers()' as I have switched to bungeecord.
So I have switched to bukkit.broadcastMessage().

@FisheyLP
Err so yeah I just realised that switching to bungeecord would mean doing the /server command.
Anyway of making the player issue that command, without having permissions or seeing the message?
Thanks
EDIT: I could just have bungeeportals, thats what I will probably do, ignore this post

Also (One last thing, I promise) on the other server, it says 'An internal error occured while attempting to perform this command'. Any ideas? Also, on my console it came up with an error - http://pastebin.com/2mwtckpu

 

@Jabbers9999
Whats line 29 of your plugin?

 

I wouldn't say that in the bukkit forums... (Angry moderators incoming that want to lock this thread because of bungeecord/offline mode in 3.. 2.. 1.. )

 

Tactical Moderators inbound!

Locked, offline mode is not supportd here.