Solved cannot be resolved

can anyone help im having problem with my almost finished code i kept getting nulpointer so i tried
fixing it i know im close but i cant just quite put my finger on what im missing

Code:java

 
public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args ){
final Player player1 = (Player) sender;
if (commandLabel.equalsIgnoreCase("hugs")){
if(args.length == 0){
player1.sendMessage(ChatColor.RED + "You need to Choose a Player");
}
else if(args.length == 1){
if (Bukkit.getServer().getPlayer(args[0]) != null){
String Player2 = Bukkit.getServer().getPlayer(args[0]).getName();
}else{
player1.sendMessage("Player is Offline");}
}else{
player1.sendMessage(ChatColor.RED + "Unknown player");
return true;
}
}
if(player1.getLocation().distanceSquared(getServer().getPlayer(Player2).getLocation()) <= 4) {
BukkitRunnable run = new BukkitRunnable(){
 
private int count = 0;
 
@Override
public void run() {
if(count >= 4){
this.cancel();
return;
}
hearts(player1);
count++;
 
}
 
};
run.runTaskTimer(this, 0L, 20L);
getServer().getPlayer(Player2).sendMessage(player1 + "just gave you a hug");
}
else{
player1.sendMessage(ChatColor.RED + "player too far away");
}
return true;
}
}

 

Hello kamakarzy,
where is the Exception occurring?

 

MP5K on player 2

if(player1.getLocation().distanceSquared(getServer().getPlayer(Player2).getLocation()) <= 4) {
BukkitRunnable run = new BukkitRunnable(){

getServer().getPlayer(Player2).sendMessage(player1 + "just gave you a hug");

ERROR: Player2 cannot be resolved into a veriable

@MP5K
any ideas ?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

change: String Player2 = Bukkit.getServer().getPlayer(args[0]).getName();
to: final String Player2 = Bukkit.getServer().getPlayer(args[0]).getName();

 

MP5K nope stays same

attached a pic for u

 

kamakarzy
Learn to use indentation, your IDE can do it for you easily.
That way you can clearly see the code and the scope of variables... in that code your Player2 variable (which is badly named, don't start fields/variables/package names with upper case letters) is within the condition scope...

Indented code:

Code:

public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args)
{
    final Player player1 = (Player)sender; // this will throw an error when command is used from console
    
    if(commandLabel.equalsIgnoreCase("hugs")) // use cmd.getName() instead
    {
        if(args.length == 0)
        {
            // you don't need a Player object to send messages, sender.sendMessage() works too...
            player1.sendMessage(ChatColor.RED + "You need to Choose a Player");
        }
        else if(args.length == 1)
        {
            if(Bukkit.getServer().getPlayer(args[0]) != null) // why are you calling getPlayer() more than once ? Store it properly
            {
                String Player2 = Bukkit.getServer().getPlayer(args[0]).getName();
                // Your issue:
                // You create 'Player2' here, therefore it's only accessible in this code block
                // Create it next to 'player1' and don't asign it.
            }
            else
            {
                player1.sendMessage("Player is Offline");
                // you should return here as you did below.
            }
        }
        else
        {
            player1.sendMessage(ChatColor.RED + "Unknown player");
            return true;
        }
    }
    
    if(player1.getLocation().distanceSquared(getServer().getPlayer(Player2).getLocation()) <= 4)
    {
        BukkitRunnable run = new BukkitRunnable()
        {
            
            private int count = 0;
            
            @Override
            public void run()
            {
                if(count >= 4)
                {
                    this.cancel();
                    return;
                }
                hearts(player1);
                count++;
                
            }
            
        };
        run.runTaskTimer(this, 0L, 20L);
        getServer().getPlayer(Player2).sendMessage(player1 + "just gave you a hug"); // why are you using getPlayer() again ?! Just store the player pointer.
    }
    else
    {
        player1.sendMessage(ChatColor.RED + "player too far away");
    }
    return true;
}

See code comments.

EDIT:
I see you have somewhat of indentation there, it's still a bit off so I suggest using your IDE's format option.... Ctrl+Shift+F for Eclipse.

 

Digi thanks i think i got what you ment and now i just get a

Code:

2013-05-05 15:31:12 [SEVERE] null
org.bukkit.command.CommandException: Unhandled exception executing command 'hugs' in plugin Huggs v1.0
    at org.bukkit.command.PluginCommand.execute(PluginCommand.java:46)
    at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:189)
    at org.bukkit.craftbukkit.v1_5_R2.CraftServer.dispatchCommand(CraftServer.java:523)
    at net.minecraft.server.v1_5_R2.PlayerConnection.handleCommand(PlayerConnection.java:966)
    at net.minecraft.server.v1_5_R2.PlayerConnection.chat(PlayerConnection.java:884)
    at net.minecraft.server.v1_5_R2.PlayerConnection.a(PlayerConnection.java:841)
    at net.minecraft.server.v1_5_R2.Packet3Chat.handle(Packet3Chat.java:44)
    at net.minecraft.server.v1_5_R2.NetworkManager.b(NetworkManager.java:292)
    at net.minecraft.server.v1_5_R2.PlayerConnection.d(PlayerConnection.java:110)
    at net.minecraft.server.v1_5_R2.ServerConnection.b(SourceFile:35)
    at net.minecraft.server.v1_5_R2.DedicatedServerConnection.b(SourceFile:30)
    at net.minecraft.server.v1_5_R2.MinecraftServer.r(MinecraftServer.java:580)
    at net.minecraft.server.v1_5_R2.DedicatedServer.r(DedicatedServer.java:225)
    at net.minecraft.server.v1_5_R2.MinecraftServer.q(MinecraftServer.java:476)
    at net.minecraft.server.v1_5_R2.MinecraftServer.run(MinecraftServer.java:409)
    at net.minecraft.server.v1_5_R2.ThreadServerApplication.run(SourceFile:573)
Caused by: java.lang.IllegalArgumentException: Name cannot be null
    at org.apache.commons.lang.Validate.notNull(Validate.java:203)
    at org.bukkit.craftbukkit.v1_5_R2.CraftServer.getPlayer(CraftServer.java:323)
    at com.gmail.nomad856.kamakarzy.Main.onCommand(Main.java:62)
    at org.bukkit.command.PluginCommand.execute(PluginCommand.java:44)
    ... 15 more

Code:java

package com.gmail.nomad856.kamakarzy;
 
import java.util.logging.Logger;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.EntityEffect;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.entity.Wolf;
import org.bukkit.plugin.PluginDescriptionFile;
import org.bukkit.plugin.java.JavaPlugin;
import org.bukkit.scheduler.BukkitRunnable;
 
public class Main extends JavaPlugin {
public final Logger logger = Logger.getLogger("Minecraft");
public static Main plugin;
 
@Override
public void onEnable() {
PluginDescriptionFile pdfFile = this.getDescription();
this.logger.info(pdfFile.getName() + "Version" + pdfFile.getVersion()
+ "Has Been Enabled");
}
 
@Override
public void onDisable() {
PluginDescriptionFile pdfFile = this.getDescription();
this.logger.info(pdfFile.getName() + "Has Been Disabled");
}
 
public void hearts(Player p) {
Wolf o = p.getWorld().spawn(p.getLocation(), Wolf.class);
o.playEffect(EntityEffect.WOLF_HEARTS);
o.remove();
}
 
public boolean onCommand(CommandSender sender, Command cmd,
String commandLabel, String[] args) {
final Player player1 = (Player) sender;
final String player2 = null;
if (commandLabel.equalsIgnoreCase("hugs")) {
if (args.length == 0) {
sender.sendMessage(ChatColor.RED
+ "You need to Choose a Player");
} else if (args.length == 1) {
if (Bukkit.getServer().getPlayer(args[0]) != null) {
 
} else {
sender.sendMessage("Player is Offline");
}
return true;
} else {
sender.sendMessage(ChatColor.RED + "Unknown player");
return true;
}
}
if (player1.getLocation().distanceSquared(
getServer().getPlayer(player2).getLocation()) <= 4) {
BukkitRunnable run = new BukkitRunnable() {
 
private int count = 0;
 
@Override
public void run() {
if (count >= 4) {
this.cancel();
return;
}
hearts(player1);
count++;
 
}
 
};
run.runTaskTimer(this, 0L, 20L);
getServer().getPlayer(player2).sendMessage(
player1 + "just gave you a hug");
} else {
player1.sendMessage(ChatColor.RED + "player too far away");
}
return true;
}
}
 

 

kamakarzy
That 2nd part of code must not be reached if player2 is null...

 

Digi anything you could suggest i had it working b4 all i wanted to do is put a check in for if player was off line to stop null point exception

 

kamakarzy Not sure if you did this on purpose, but you literally set Player2 to null.

Code:

final String player2 = null;

Edit: I'm pretty sure you need to make Player2 an actual player instead of a string to use stuff like getLocation, etc. as well.

 

StaticE & Digi
i decided there must be a betterway to check if the player is online so if you could look through this and tell me if there is

Code:java

package com.gmail.nomad856.kamakarzy;
 
import java.util.logging.Logger;
 
import org.bukkit.ChatColor;
import org.bukkit.EntityEffect;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.entity.Wolf;
import org.bukkit.plugin.PluginDescriptionFile;
import org.bukkit.plugin.java.JavaPlugin;
import org.bukkit.scheduler.BukkitRunnable;
 
public class Main extends JavaPlugin {
    public final Logger logger = Logger.getLogger("Minecraft");
    public static Main plugin;
 
    @Override
    public void onEnable() {
        PluginDescriptionFile pdfFile = this.getDescription();
        this.logger.info(pdfFile.getName() + "Version" + pdfFile.getVersion()
                + "Has Been Enabled");
    }
 
    @Override
    public void onDisable() {
        PluginDescriptionFile pdfFile = this.getDescription();
        this.logger.info(pdfFile.getName() + "Has Been Disabled");
    }
 
    public void hearts(Player p) {
        Wolf o = p.getWorld().spawn(p.getLocation(), Wolf.class);
        o.playEffect(EntityEffect.WOLF_HEARTS);
        o.remove();
    }
 
    public boolean onCommand(CommandSender sender, Command cmd,
            String commandLabel, String[] args) {
        final Player player1 = (Player) sender;
        Player player2 = sender.getServer().getPlayer(args[0]);
        if (commandLabel.equalsIgnoreCase("hugs")) {
            if (args.length == 0) {
                if(player1.getLocation().distanceSquared(player2.getLocation()) <= 4) {
        }
            BukkitRunnable run = new BukkitRunnable() {
 
                private int count = 0;
 
                @Override
                public void run() {
                    if (count >= 4) {
                        this.cancel();
                        return;
                    }
                    hearts(player1);
                    count++;
 
                }
 
            };
            run.runTaskTimer(this, 0L, 20L);
            player2.sendMessage(player1 + "just gave you a hug");
        } else {
            sender.sendMessage(ChatColor.RED + "player too far away");
        }
    }
        return true;
}
}

 

kamakarzy

Code:

    @Override
    public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args)
    {
        if(cmd.getName().equals("hugs"))
        {
            if(sender instanceof Player)
            {
                if(args.length > 0)
                {
                    Player target = Bukkit.getPlayer(args[0]);
                    
                    if(target != null)
                    {
                        Player player = (Player)sender;
                        Location playerLoc = player.getLocation();
                        Location targetLoc = target.getLocation();
                        
                        if(playerLoc.getWorld().getUID().equals(targetLoc.getWorld().getUID()))
                        {
                            if(playerLoc.distanceSquared(targetLoc) < 4) // this is max 2 blocks away.
                            {
                                target.setFireTicks(20 * 5); // hehehe :}
                                // but seriously, do your thing here.
                                
                                target.sendMessage(player.getDisplayName() + " hugs you.");
                            }
                            else
                            {
                                sender.sendMessage(target.getDisplayName() + " is too far away.");
                            }
                        }
                        else
                        {
                            sender.sendMessage(target.getDisplayName() + " is not in the same world as you.");
                        }
                    }
                    else
                    {
                        sender.sendMessage("Can't find player: " + args[0]);
                    }
                }
                else
                {
                    return false; // print usage
                }
            }
            else
            {
                sender.sendMessage("This command can only be used by a player.");
            }
        }
        
        return true;
    }

 

Digi

thanks and the set the player on fire was a good idea but ill leave that for a different plugin