Plugin Help Can Some One Fix This Please?

Discussion in 'Plugin Help/Development/Requests' started by PENGUllN, Aug 18, 2015.

Thread Status:
Not open for further replies.
  1. Offline

    PENGUllN

    I have been trying to get "the killers" to display when you type /wanted
    here is my code
    Code:
    import java.util.ArrayList;
    import org.bukkit.ChatColor;
    import org.bukkit.command.Command;
    import org.bukkit.command.CommandExecutor;
    import org.bukkit.command.CommandSender;
    import org.bukkit.entity.Player;
    import org.bukkit.event.EventHandler;
    import org.bukkit.event.Listener;
    import org.bukkit.event.entity.PlayerDeathEvent;
    
        public class WantedList implements Listener, CommandExecutor {
         
            public ArrayList<String> wanted = new ArrayList<String>();
         
            @EventHandler
            public void playerDeath(PlayerDeathEvent event) {
                Player deadPlayer = event.getEntity();
                Player killer = event.getEntity().getKiller();
                if (killer instanceof Player && deadPlayer instanceof Player);
                    wanted.add(killer.getName());
                }
                public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
                    if(cmd.getName().equalsIgnoreCase("wanted")) ;
                    Player p = (Player)sender;
                    p.sendMessage(ChatColor.YELLOW + "" + ChatColor.BOLD + "Wanted:" + wanted);
                    for (String wanted : wanted) {
                        p.sendMessage(ChatColor.GREEN + "" + wanted);
                    }
                    return false;
            }
        }
    the command works but when I kill a player to see if I get added to the commands list it displays nothing but

    [​IMG]

    can someone fix this for me ? I cannot see why
     
    Last edited: Aug 18, 2015
  2. They are called the same thing.

    And it would be empty if someone hadn't died but did the event
     
  3. Offline

    PENGUllN

    what do call it then and a player had died
     
  4. Offline

    Boomer

    for (String w: wanted)

    You also have your command method INSIDE of the event method.
    It should be separate
     
  5. Offline

    PENGUllN

    I just cannot seem to fix everything I try I come across another error
     
  6. Offline

    SantaClawz69

    Here, just copy and paste this. I usually don't give code like this but it seems like you knew what you were doing but you're just mixing some stuff up so here you go:

    Code:
     @EventHandler
            public void playerDeath(PlayerDeathEvent event) 
                {
                Player deadPlayer = event.getEntity();
                Player killer = event.getEntity().getKiller();
                if (killer instanceof Player && deadPlayer instanceof Player)
                {
                    wanted.add(killer.getName());
                }
                }
                public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
                    if(cmd.getName().equalsIgnoreCase("wanted")) ;
                    if(sender instanceof Player) {
                    Player p = (Player)sender;
                    p.sendMessage(ChatColor.YELLOW + "" + ChatColor.BOLD + "Wanted:" + wanted);
                    for (String w : wanted) {
                        p.sendMessage(ChatColor.GREEN + "" + w);
                    }
    }
                    return false;
            }
        }
     
Thread Status:
Not open for further replies.

Share This Page