Can anyone see why this isnt firing?

This is driving me mad, This seems to work fine for when a PLAYER shoots an arrow, I get the 'arrow shot" message fine..so its triggering.

But Skeletons don't trigger the EntityShootBowEvent at all, anyone see anything I'm missing?

Code:java

 
package me.dx.seasons.plugin;
 
import net.minecraft.server.MobEffect;
 
import org.bukkit.Effect;
import org.bukkit.Location;
import org.bukkit.World;
import org.bukkit.craftbukkit.CraftWorld;
import org.bukkit.craftbukkit.entity.CraftEntity;
import org.bukkit.entity.Arrow;
import org.bukkit.entity.Entity;
import org.bukkit.entity.EntityType;
import org.bukkit.entity.Skeleton;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.CreatureSpawnEvent;
import org.bukkit.event.entity.CreatureSpawnEvent.SpawnReason;
import org.bukkit.event.entity.EntityShootBowEvent;
import org.bukkit.util.Vector;
 
public class MobListener implements Listener{
    private final Main plugin;
    public MobListener(Main plugin) {
        this.plugin = plugin;
    }
    //-----------------------------
    //Skele Arrows
    //-----------------------------
    @EventHandler
    public void onShoot(EntityShootBowEvent event) {
        plugin.log.info("ARROW SHOT");
        Entity e = (Entity) event.getEntity();
        if (e instanceof Skeleton) {
            if (event.getProjectile() instanceof Arrow) {
                Arrow a = (Arrow) event.getProjectile();
                a.setFireTicks(20);
            }
        }
    }
//snip rest of class thats not related.
 

 

Instead, try getting the EntityDamagedByEntityEvent and compare if the hitter is a Skeleton, then set the entity's fire tick to 20.

 

Well that would work for the fire, but if I can get it working, was also going to add 'more arrows' fired with a synctask when they fired. :\

But cant get it to trigger when anything but a player fires.

 

did you register the event in the onEnable method in your main class?

 

I think I did it correctly, since it fires when a player shoots with the debug message, just not skeletons. have this in my on enable of Main:
pm.registerEvents(new MobListener(this), this);

and this in my class extends of Main:
MobListener OnS = new MobListener(this);

Main class snippet :

Code:java

 
public class Main extends JavaPlugin implements Runnable {
    private static Main instance;
    public final Main playerListener = this;
    MobListener OnS = new MobListener(this);
    Lis lis = new Lis(this);
 

And on Enable snippet:

Code:java

 
    public void onEnable()
    {
        instance = this;
        this.getCommand("season").setExecutor(new Clis(this));
        PluginManager pm = getServer().getPluginManager();
        pm.registerEvents(new Lis(this), this);
        pm.registerEvents(new MobListener(this), this);
 

 

Try This

Change Your Code In onEnable To


pm.registerEvents(new MobListener(), this);

And delete MobListener OnS = new MobListener(this); from your extends of Main.

If it doesnt works , then try not deleting MobListener OnS = new MobListener(this); .

Hope It Helps

 

That won't work at all since his Listener class has an instance of the main class so when registering the plugin, he must have the reference to the main in his constructor as well.

 

I get "constructor "MobListener()" is undefined"
if I remove the 'this'. :\

maybe add:

public final Main EntityListener = this;
and
pm.registerEvents(new MobListener(EntityListener), this);

?
Im about to try that.

edit:scratch that, just realized that would do nothing..I can call it whatever I want..PlayerListener, EntityListener, JohnListner..it doesn't matter.

so adding "Entity" to the name wont make it look for mobs...

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

No. Leave it with "this." You didn't do anything wrong there. Are you sure that the event's not firing at all if it's a skeleton? Remove all other plugins to avoid a possible conflict.

 

here is the entire "trying to catch Skele arrow shot" class cleaned up to just the basics...Catching any arrow shot with a log of "Something shot arrow" and down to when a skele shoots with "Skele shot arrow:

Bit still only fires when players shot, and gives the "something"..skele doesnt trigger even that.

Code:java

 
package me.dx.seasons.plugin;
 
import org.bukkit.entity.Arrow;
import org.bukkit.entity.Entity;
import org.bukkit.entity.Skeleton;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.EntityShootBowEvent;
 
public class MobListener implements Listener{
    private final Main plugin;
    public MobListener(Main plugin) {
        this.plugin = plugin;
    }
    //-----------------------------
    //Skele Arrows
    //-----------------------------
    @EventHandler
    public void onShoot(EntityShootBowEvent event) {
        plugin.log.info("ARROW SHOT");
        Entity e = (Entity) event.getEntity();
        if (e instanceof Skeleton) {
            plugin.log.info("SKELO ARROW SHOT");
            if (event.getProjectile() instanceof Arrow) {
                Arrow a = (Arrow) event.getProjectile();
                a.setFireTicks(20);
            }
        }
    }
 

Yes its the only plugin in place other than permissions.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

dxwarlock
Does it print the first "arrow shot"?

 

No, only when player fires does it trigger..the Skeleton doesnt trigger it. why I'm at a loss here.

and there is code below it for "onCreatureSpawn" that triggers, so I know the class is catching events.
is there there anything special I need to do to get it to catch 'creature action' events?

 

Is it possible that skeletons do not actually fire the bow, that they are simply holding the bow for show and that the arrows that they shoot are just being spawned with the appropriate direction and velocity?

 

I thought that too. so I dug around the forums looking..it seems it SHOULD still trigger it.

http://forums.bukkit.org/threads/entityshootbowevent.55239/
This adds the EntityShootBowEvent, which is triggered when either a player releases a pulled bow, or when a Skeleton shoots an arrow.

So maybe its bugged?

 

I think its bugged, I cant find something about the shoout event inside the source:
https://github.com/Bukkit/CraftBukk.../net/minecraft/server/EntitySkeleton.java#L19
https://github.com/Bukkit/CraftBukk...aft/server/PathfinderGoalArrowAttack.java#L77

 

Yea, I'm still working on it, I went the looong about way of doing it.
remaking my own EntitySkeleton and PathFinderGoalArrowAttack by copying and tweaking the default one,to changing the way the skeleton shoots... Now I can have Gatling Gun skeletons that hit you for 40 blocks away (not that I need them, but fun to play with on the test server to test it)

lot more code, but it works

And do you EVER sleep ferrybig?

 

[offtopic]Its now 13:18 at the place where I am[/offtopic]