Bukkit's Logic or Mine is Broken

Okay,

So I'm making a plugin that allows the player to make [Command] signs. When you make the sign, it checks to see if the first line is [Command] (case is not specific). But for some reason, even if I clearly am making it "[Command]", it still returns false.

Code:javascript

 
    @EventHandler
    public void onSignChange(SignChangeEvent event) 
    {
        Block b = event.getBlock();
        Sign s = (Sign) b.getState();
        if(s.getLine(0).equalsIgnoreCase("[Command]"))
        {
            if(!"".equals(s.getLine(1).toLowerCase()) && event.getPlayer().hasPermission("signdirectives.makesign"))
            {
                event.getPlayer().sendMessage("DEBUG: Created Command Sign");
                event.setLine(0, "§1[Command]");
                event.getBlock().getState().update();
            }
            else if("".equals(s.getLine(1).toLowerCase()) && event.getPlayer().hasPermission("signdirectives.makesign"))
            {
                event.getPlayer().sendMessage(ChatColor.RED + "Your Command Sign was incorrectly set up.");
                event.setLine(0, ChatColor.DARK_RED + "[Command]");
                event.setLine(1, ChatColor.RED + "<Command>");
                event.setLine(2, ChatColor.RED + "<Arguments>");
                event.setLine(3, ChatColor.RED + "<More Arguments>");
                event.getBlock().getState().update();
            }
            else if(!event.getPlayer().hasPermission("signdirectives.makesign"))
            {
                event.getPlayer().sendMessage(ChatColor.DARK_RED + "You don't have permission to make command signs.");
                event.setCancelled(true);
            }
        }
        else
        {
            boolean bool = s.getLine(0).equalsIgnoreCase("[Command]");
            event.getPlayer().sendMessage("§aDEBUG: Error! onoes! " + bool + ", actually is \"§r" + event.getLine(0) + "§a\"");
        }
 
    }
[/javascript]
 
            event.getPlayer().sendMessage("§aDEBUG: Error! onoes! " + bool + ", actually is \"§r" + event.getLine(0) + "§a\"");
This line tells me that the line is "actually [Command]"... so why is it returning false? It doesn't make sense. I have tried several different methods for comparing the sign line to what it needs to be including the toLowerCase().contains() method. Any advice? This is quite confusing. :P

 

TheHandfish use event.getLine(int). The lines aren't set in set on the Sign yet

 

fireblast709: Huh? Sorry. I don't understand. x.x Could you explain?

 

TheHandfish line 7 uses the tile entities data, which is set after the event has been handled (of course if the event hasn't been cancelled)

 

TheHandfish

The SignChangeEvent is pre called and works when you pressed the done button but since you don't have these lines yet because its precalled before it writes the sign data to the actualy blockstate its not really possible to use it that way, in order to fix that use the event it self it contain the same methods as in Sign but not the update() method because the event will care for that.

 

fireblast709, xize: I see. So, should I schedule a syncDelayedTask?

 

TheHandfish Now why would you do that when you could change s.getLine(x) with event.getLine(x)....

 

TheHandfish

let me geuss, you want real time updates on the signs?

in that case you may want to use no scheduler but instead using a combination of event.getLine() and blockstate.setLine() and blockstate.update(), but be aware by doing this when the sign is clicked on done it resents all the lines again...

-edit-
oh you actually need a scheduler though

 

xize TheHandfish Well you could just set the events line so that it updates to the line set.

 

TheHandfish no. Instead of getting the Sign and using s.getLine(x), check if e.getLine(x) matches the stuff you want to compare

 

Chiller

My concern is that it may not work unless the player has already clicked the done button.
but if he wants to update the signs live (when still typing on the sign) this event isn't really designed that way it doesn't do a 1 tick update automaticly it only adds things on the sign when done is clicked, so a scheduler would be more suitable but also sort of dangerous to, if I where the op I would strongely advise adding the scheduler outside the event and use a getter system or something smilliar.

 

xize stop advising the scheduler lol. If you read the initial post you can see he wants to make some kind of command executing sign

 

fireblast709
Fair enough, the first lines made me confused what the op intention was,
but now I see.

TheHandfish
ignore my last 2 posts, the scheduler is not needed it only creates confusion.

 

Okay, thanks. I just realized I forgot to change s.getLine to event.getLine. I'll try that next time I'm on a computer.