Bukkit Scheduler Memory Leakage? [Please help!]

Hey, I have a pretty weird and bad issue here. I've made a new plugin involving Bukkit schedulers which sets a group of worlds' times to their specified amount of ticks, which happens every amount of seconds as specified in the config file.

The problem with this is that the server's memory is skyrocketing from the moment it starts up, using too much memory to even issue commands in the console or join into the server in-game. I'm pretty sure this is memory leakage, and the only possible cause is the scheduler. I've 100% debugged my code (as far as I'm sure of) and nothing is either wrong with it or can take up so much memory other than Bukkit's code, which is why I assume it's the scheduler's fault.

I know that this is possible to do, since I've seen tons and tons of auto-broadcasting plugins, and I'm not sure why mine isn't working.

For reference, here's all of the code to my plugin:

Code:java

package me.pookeythekid.AlwaysTime;
 
import java.util.ArrayList;
import java.util.HashMap;
import java.util.logging.Logger;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.World;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.plugin.PluginDescriptionFile;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Main extends JavaPlugin {
 
public final Logger logger = Logger.getLogger("Minecraft");
 
public HashMap<String, Boolean> constWorlds = new HashMap<String, Boolean>();
 
public ArrayList<String> constWorldsList = new ArrayList<String>();
 
public static int wrldNum = 1;
 
 
@Override
public void onDisable() {
 
PluginDescriptionFile pdf = this.getDescription();
 
logger.info("[" + pdf.getName() + "] " + pdf.getName() + " is now disabled.");
 
}
 
 
@Override
public void onEnable() {
 
PluginDescriptionFile pdf = this.getDescription();
 
logger.info("[" + pdf.getName() + "] " + pdf.getName() + " v" + pdf.getVersion() + " is now enabled.");
 
 
try {
 
saveDefaultConfig();
 
} catch (Exception e) { e.printStackTrace(); }
 
 
constWorlds.clear();
 
constWorldsList.clear();
 
int i = 1;
 
while (getConfig().getString("world" + String.valueOf(i) + ".Name") != null) {
 
constWorlds.put(getConfig().getString("world" + String.valueOf(i) + ".Name"), true);
 
constWorldsList.add(getConfig().getString("world" + String.valueOf(i) + ".Name"));
 
}
 
Bukkit.getScheduler().scheduleSyncRepeatingTask(this, new Runnable() {
 
public void run() {
 
wrldNum = 1;
 
while (wrldNum <= constWorldsList.size()) {
 
if (constWorlds.get(getConfig().getString("world" + String.valueOf(wrldNum) + ".Name")) == true) {
 
World world = Bukkit.getServer().getWorld(getConfig().getString("world" + String.valueOf(wrldNum) + ".Name"));
 
world.setTime(getConfig().getLong("world" + String.valueOf(wrldNum) + ".ticks"));
 
}
 
wrldNum++;
 
}
 
}
 
}, 60 * 20, getConfig().getLong("seconds") * 20);
 
 
}
 
 
public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args) {
 
if (commandLabel.equalsIgnoreCase("alwaystime") || commandLabel.equalsIgnoreCase("at")) {
 
if (sender.hasPermission("alwaystime.toggle")) {
 
if (args.length < 2) {
 
sender.sendMessage(ChatColor.YELLOW + "/AlwaysTime toggle <world>");
sender.sendMessage(ChatColor.YELLOW + "/AtReload");
 
} else if (args.length >= 2
&& args[0].equalsIgnoreCase("toggle")
&& Bukkit.getServer().getWorld(args[1]) != null) {
 
if (constWorlds.get(args[1]) == true) {
 
constWorlds.put(args[1], false);
sender.sendMessage(ChatColor.AQUA + "World " + args[1]
+ "'s timer has been " + ChatColor.RED + "stopped.");
 
} else if (constWorlds.get(args[1]) == false
&& constWorlds.get(args[1]) != null) {
 
constWorlds.put(args[1], true);
sender.sendMessage(ChatColor.AQUA + "World " + args[1]
+ "'s timer has been " + ChatColor.GREEN + "started.");
 
}
 
} else if (!args[0].equalsIgnoreCase("toggle")) {
 
sender.sendMessage(ChatColor.YELLOW + "/AlwaysTime toggle <world>");
 
} else if (Bukkit.getServer().getWorld(args[1]) == null
|| constWorlds.get(args[1]) == null) {
 
sender.sendMessage(ChatColor.RED + "World " + args[1] + " either doesn't exist "
+ "or you don't have it in your AlwaysTime config file.");
 
}
 
} else if (!(sender.hasPermission("alwaystime.toggle"))) {
 
sender.sendMessage(ChatColor.RED + "You don't have permission to perform this command.");
 
}
 
} else if (commandLabel.equalsIgnoreCase("atreload")) {
 
if (sender.hasPermission("alwaystime.reload")) {
 
reloadConfig();
 
constWorlds.clear();
 
constWorldsList.clear();
 
int i = 1;
 
while (getConfig().getString("world" + String.valueOf(i) + ".Name") != null) {
 
constWorlds.put(getConfig().getString("world" + String.valueOf(i) + ".Name"), true);
 
constWorldsList.add(getConfig().getString("world" + String.valueOf(i) + ".Name"));
 
}
 
Bukkit.broadcastMessage(String.valueOf(constWorldsList.size()));
//Broadcasting the message was to troubleshoot the errors with my
// ArrayList and HashMap
 
sender.sendMessage(ChatColor.GREEN + "All timers have been restarted, and config has been reloaded.");
 
}
 
} else if (sender.hasPermission("alwaystime.reload")) {
 
sender.sendMessage(ChatColor.RED + "You don't have permission to perform this command.");
 
}
 
return true;
 
}
 
 
}
 

And here's the config file:

Code:

# How many seconds should there be between updating the time?
# If you time it correctly, this setting could be used to cycle
# through a certain period of time. For example, it could be
# only day or only night. In order to avoid lag overload,
# keep this number reasonably high!
seconds: 60
 
# This is the list of worlds that will always be a certain time.
# Follow the pattern to add more worlds. The "ticks" setting in
# each one of these means the time in game ticks that the world
# will always be.
world1:
  Name: PCGames
  ticks: 135500
world2:
  Name: anotherworld
  ticks: 200
world3:
  Name: yetanotherworld
  ticks: 0

Please don't let the length of this thread scare you away. I really need an answer to this!

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

I've heard some rumors that BukkitSchedule will be deprecated in favor of BukkitRunnable. Here's how to use BukkitRunnable -

Code:java

new BukkitRunnable(){
@Override
public void run(){
//Code
}
}.runTaskTimer(plugin, delay, timer);

or

Code:java

new BukkitRunnable(){
@Override
public void run(){
//Code
}
}.runTaskLater(plugin, delay);

 

unon1100 Thanks! But I have a question: What kind of object is "timer?" How do you use it?

Edit: Oh wait a second... runTaskTimer(), and runTaskLater()... Could you please explain the difference please? And still, please explain the use of timer. Thanks.

 

Timer is a repeating task. Later means not now, after a delay, i.e. later.

 

Alshain01 Yes that part makes sense. What I'm asking is the function of the timer object. Is that a long/int that is the delay between the re-execution of the code?

 

http://jd.bukkit.org/rb/apidocs/org...skTimer(org.bukkit.plugin.Plugin, long, long)

 

BillyGalbreath Thanks, that answered my question.

 

unon1100 Umm... Actually I have one last question: Do I still use "Bukkit.getScheduler().scheduleSyncRepeatingTask()" for this?
Example:

Code:java

Bukkit.getScheduler().scheduleSyncRepeatingTask(this, new BukkitRunnable() {
 
public void run() {
 
Bukkit.broadcastMessage("This is a broadcast.");
 
}
 
}, 0, 200);
 

Edit: Oh wait a second nevermind. That would defeat the purpose of having the delay option at the end of the BukkitRunnable body. But how would you piece the code together? Just how it is?

 

pookeythekid
add .runTaskTimer to the end of init code

 

xTrollxDudex Yeah I noticed that after I posted it, but I just got too lazy to do it. But you get the point.

BillyGalbreath unon1100 The code you two gave me still lags the server to the max. I'm assuming that this is memory leakage because my server host has once diagnosed this issue with some of the same conditions, such as not being able to log into or connect to the server. My next plan is to just take a look at the code of another (working) scheduled plugin.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

You need to check and make sure you have ONE scheduler per world. If you are creating a new one every time it runs then that would eat up your resources rather quickly. Its the only thing i can think of that might be causing the issue.

 

pookeythekid
Then again, that's a lot of IO

 

Maybe I am too sleepy right now. But didn't you created a endless loop with that while(get config!=null) thing?

 

L33m4n123 You may think so, but if you look at the format of the config file, it's "world1: <stuff below>, world2: <stuff below>" and so on. With the while loop, I check if "world" + i (in the first loop this would be "world1") != null, which would return true. As the while loop progresses, then "i" will increase. If the "i" eventually reaches a nonexistent world, which in the current config file would be "world4," then the loop will stop. So no, it's not an infinite loop.

BillyGalbreath I'm quite sure I'm not creating a scheduler for each world. You see, I have one scheduler that manages all of the worlds. Each time the scheduler fires off, I have a while loop inside of the run() void that loops through the existent worlds, the worlds that were added to the ArrayList in the previous while loop, and sets their time to the ticks that are specified in the config file.

Actually, a thought just occurred to me... it is slower to get data from an external file, so I could try to get the ticks for each world into another HashMap, then I could give the scheduler that data and perhaps that would speed up the process, using less memory. I kind of doubt it will make too much of a difference, but eh, it's worth a shot.

Edit: And just a note for everyone, I don't get any stack traces in the console, so I know it's not an error. A while ago, the plugin actually did work, but I got a ton of error spams in the console and the time only worked for one world. But that was a while ago. Now the only problem is some kind of memory overuse.

Does anyone think that this may work if I combined BukkitRunnable with Bukkit.getScheduler().scheduleSyncRepeatingTask, and just took the delay values out of BukkitRunnable?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

You do

Code:

int i = 1
while string of i != null
  add string into hashMap
  add string to list

so. No where you set the string to null NOR do you increase the i-value thus it stays at i = 1 so the string stays the same thus the while loop runs endlessly and in the end lagging your server.

 

Its not reading from file each time. getConfig() is in memory. Its populated when the plugins first loads/reloads (or when you explicitly tell it to reload from file).

 

L33m4n123 AAAAGGHH!! I feel like such an idiot! Technically you're half-wrong, since I'm not checking if i is null, I'm using i to loop through "world1," "world2," "world3" and so on. But I'm not increasing the i value... DUH! Thanks a lot.

BillyGalbreath Oh really? I did not know that...

EDIT by Moderator: merged posts, please use the edit button instead of double posting.