Bukkit Delayed Tasks not running in order

What I am trying to do is run a series of commands after the other in order, taking into account any delays that need to happen. The following code will, without delay commands, run all other commands in order:

Code:java

 
int delay = 0;
String Command = "say I|@delay 25|say II|say III|say IIII|@delay 50|say IIIII|say IIIIII";
String[] Commands = Command.split(Pattern.quote("|"));
for (int j = 0; j < Commands.length; j ++){
if (Commands[j].contains("@delay")){
String[] delayArgs = Commands[j].split(" ");
delay += Integer.parseInt(delayArgs[1]);
}else{
new ScheduledTask(Commands[j]).runTaskLater(plugin, delay);
}
}

Output:

Code:

I
II
III
IIII
IIIII
IIIIII

However, when this change is made:

Code:java

 
String Command = "say I|@delay 25|say II|say III|say IIII|@delay 50|say IIIII|say IIIIII";

It does not run the commands after the exact given delay; sometimes it runs as it should with the delays accounted for, but at other times, commands after delays are not run in order. I receive the following output on these occasions:

Code:

I
II
III
IIII
IIIIII
IIIII

I have attempted to use a foreach loop here but the for loop I currently have works better. What would be good is to assign a delay value to tasks that carry on to succeeding tasks. If this is possible, or a better workaround is viable, I would love to know.

Thanks.

 

Why not simply iterate over all commands with the same delay in one task, instead of splitting them into many tasks where the order isn't guarantied?

 

Because I'm developing a plugin whereby delays can be customized between commands.

Code:java

public class ScheduledTask extends BukkitRunnable{
 
private String Command;
private CommandSender Sender;
private boolean Op, currentOp;
 
public ScheduledTask(String command){
Command = command;
Sender = Bukkit.getServer().getConsoleSender();
}
 
public ScheduledTask(Player player, String command, boolean op){
Command = command;
Sender = (CommandSender) player;
Op = op;
currentOp = player.isOp();
}
 
@Override
public void run(){
if (Sender instanceof Player){
Player player = (Player) Sender;
if (!currentOp) player.setOp(Op);
player.performCommand(Command);
if (Op) player.setOp(currentOp);
}else{
Bukkit.dispatchCommand(Sender, Command);
}
}
}

I cannot iterate through each command in the run function here because the plugin needs to set a unique delay for each command. For example:

/say this command should run first
delay for 1 second
/say this command should run second <- total delay: 1 second
/say this command should run third <- total delay: 1 second
delay for 1 second
/say this command should run fourth <- total delay: 2 seconds
/say this command should run fifth <- total delay: 2 seconds

 

If the delays are consistent you can do it with one task just fine...
Actually even if they're not consistent you can still do it.

You're also relying on the in-game chat, which is in a diferent thread I belive, to tell you the order of your executions... print them in server console, that's the way to debug.

 

You didn't got my point. You should put all commands having the same delay in the same task. Means you should generate a new task only when a new delay is needed. Then you can give each task an array of commands to be done in a for each loop instead of doing only one command per task.

 

I understand you now, thankyou.I will apply this to my plugin now

I actually did something different but it actually fixed the problem when I least expected it to. Here's what I did:

Code:java

new ScheduledTask("" + delay + "}" + Commands[j]).runTaskLater(plugin, delay);

And in the ScheduledTask class, i simply substringed the command to the index of } + 1. This solved the problem when I was actually just trying to find out if the delays were correct. Thankyou for your help though.

 

Why not just use 2 arguments instead of parsing strings ... ?

new ScheduledTask(delay, commands[j])...

 

+1 for using typed parameters instead of using a String you need to split of and convert.