BlockIterator freeze

This is supposed to damage all entities within 10 block range, closer entities are, higher is damage. But only thing it will do is freeze server as soon as fireball is about to hit land.

Code:java

@EventHandler()
	public void onEntityExplode(EntityExplodeEvent event) {
		if (event.getEntity() instanceof Fireball) 
		{
			fireballExplode((Fireball) event.getEntity());
			event.setCancelled(true);
			return;
		}
 
	}

Code:java

	public void fireballExplode(Fireball ball)
	{
		List<LivingEntity> entities = new ArrayList<LivingEntity>();
		for (Entity e : ball.getNearbyEntities(10, 10, 10))
			if (e instanceof LivingEntity) entities.add((LivingEntity) e);
 
		BlockIterator literator = new BlockIterator(ball.getLocation(), 10);
 
		while (literator.hasNext())
		{
			Block b = literator.next();
			Location loc = b.getLocation();
			for (LivingEntity e : entities.toArray(new LivingEntity[0]))
			{
				Location l = e.getLocation();
				if (loc.getX() + 1.5 > l.getX() && loc.getX() - 0.5 < l.getX() &&
					loc.getY() + 2.5 > l.getY() && loc.getY() - 1.5 < l.getY() &&
					loc.getZ() + 1.5 > l.getZ() && loc.getZ() - 0.5 < l.getZ())
				{
					double range = ball.getLocation().distance(l);
					if (range > 10) continue;
 
					e.damage((int) (10 - range), ball);
					entities.remove(e);
				}
			}
		}
 
	}
 

 

You may be just trying to do too much work on your server all at once. Which may cause the server to freeze.

 

This is entirely too complicated for as simple of a task as you are trying to do:

1) use the fireball entity to getnearbyentities( 20, 20, 20 ) // 10 block radius
2) check the distance from the fireball entity to target
3) Divide damage based on distance
4) apply damage.

This could be done in like 8 lines of code. Look at the GetNearbyEntities function, I think it will save you a lot of headaches.

Good luck!

 

Um yeah, I see now how I completely failed on this concept (BlockIterator iterates only in one line). Why you did getNearbyEntities(20, 20, 20) if blockradius must be 10?

 

check the java docs, the input is:

GetNearbyEntities( Diameter/2, Diameter/2, Diameter/2 )

it's 20 Diameter, but 10 radius.

XXXXXXXXXXOXXXXXXXXXX

X = one block
0 = Center
it's 20 wide, but only 10 from the center.

Hope this helps!

 

Oh, I see. Thanks.

 

My pleasure, I am happy to assist.

 

That's not how I interpret it. It says to pass 1/2 the size of the box, meaning you should pass the radius (10), not the diameter (20).

 

Yes, after reading javadocs I think nisovin is right.

 

Ahh, there you go; it had been awhile since I used it, I knew it wasn't simply the diameter. Apparently I had it backwards, so if you want it to have a diameter of 10 you must enter 5.

Oh well, no one bats perfect... without steroids... *calls his doctor*