Arrow Barage

Name : Arrow Barrage
Version : 1.7.2 R0-2
Category : Others

Needed : I need a plugin that when you charge a custom bow with the name "Barrage Bow" you an shoot 5 arrows {like in mineplex}

Idea for Commands : /arrowbarrage

Idea for Permissions : arrowbarrageget.permission

When i'd like it : 1 Week 1 day or anything works

 

Please use a format.

 

what do you mean ?

 

bump

 

MordorKing78

He did use the format -_-

 

XdarkbeastX
I'll do this. Be done in about 10 mins

Sorry for the delay, went for my Dinner. <Edit by Moderator: Redacted mediafire url>

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

timtower

No I did not, Buts its done now so

 

RockyMan13 Nope, But he changed it! So he got that going for him witch is nice.

 

CraftCreeper6
does it have the command ?

CraftCreeper6
sorry but it doesnt look like it work for 1.7.2 R0-2

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

XdarkbeastX shouldve said it was for 1.7.2 -.-

 

XdarkbeastX
I coded it for 1.7.9. That's why.

 

CraftCreeper6
oh can you recode it please ?

 

XdarkbeastX
No, I am coding for 1.7.9, if you wanted it for 1.7.2 why did you not put it in your OP?

 

CraftCreeper6
oh so should i put it in my OP ?

 

XdarkbeastX
Yes, but that doesn't mean I am going to re-code it to fit something you didn't mention earlier.

 

list everything that you want which we can't read your mind with.

 

XdarkbeastX CraftCreeper6

Ok, so when OP talked about how your plugin doesn't work with 1.7.2... I just had to take a look as to why. There's no reason that you would need to access anything other than the Bukkit API for this.

What I saw was... well... horrifying.

For the faint of heart, don't click on the spoiler below.

Warning. Do not click if you have a heart condition (open) Warning. Do not click if you have a heart condition (close)

• Why are there onEnable/onDisable messages?
• Why do you make a new Shoot every time someone runs a command???
• Why are you using System.out.print??? It's not even println so the formatting will be messed up
• Why are you using a default displayname with no ChatColor, or any identifying feature? Anyone can rename their bow with an arrow
• Why are you making a new Random every time someone shoots an arrow?
• Why is there that random ArrayList called 'a'? It serves no purpose other than wasting RAM because of you creating the Shoot object every time the command is ran
• (EDIT) You don't own http://craftcreeper6.me, don't use that as your package name please. It's against Java convention. Use your email or something

On one hand, at least you're not abusing static, but honestly, you should just recode this to

• Fix whatever bug is not letting it load on 1.7.2
• Fix those horrible issues. Please.

 

zombiekiller753
My ArrayList is called "a" for a short way of "arrow", now I know this breaks Java Naming Conventions but I was really, really tired when I did this and I did say I would have it finished in ten minutes.
Default display name: Did he ask for a colour?
Random: Look at my first point.
My package name: Bad habit picked up from YouTube videos when I just started out ;p

New Shoot...? I don't I simply give them an ItemStack...

System.out.print(): I'll have you know it doesn't mess the formatting up. It automatically creates a new line. Why not test before you have a go at me?

 

CraftCreeper6
Just to make sure, I went and downloaded the latest version of your ArrowBarrage plugin.
Although you're right on the print thing, it turns out Apache's log4j takes care of that, you're still scarily misinformed about everything else.

There are three classes in your plugin. I think we can analyse them all here with little problems.

First, there's Main.java.


Nothing too bad here. Just the onenable/disable spam. Let's take a look at Commands.java



Oh, what's this? new Shoot().getBow() ?
No permissions check. Creates a new shoot every time. Easily abusable.

Finally, over at Shoot.java


Whatever that List 'a' is supposed to be for, it's not used. Just created. You also just compare the two itemstacks together, which will maybe possibly check for displaynames? I'm not sure. However, I am sure that because there's no ChatColor, any bow renamed will work. That's not a case of oh the customer didn't ask for a bag for his groceries, it's I should just have given him a bag.

Oh, and that Random. The player has a 1/4 chance of shooting no arrows. Great.

I just realized you edited 5 times. What did you change?

CraftCreeper6

Overrides are removed on compile, I think.
Just the 1/4 chance that I could possibly not shoot any arrows.
And the permission, depending on whether OP wanted it. I can't tell if he just put it there as a placeholder.

Then I'll <3 you

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

zombiekiller753
It will always shoot at least one As it is ProjectileLaunchEvent, it will always fire at least once. A permission for what?
EDIT: Nvm, blank moment xD

EDIT 2: <Edit by Moderator: Redacted mediafire url>

EDIT 3:
* Command: /arrowbarrage
* Permission: arrowbarrage.get

 

CraftCreeper6
Random#nextInt(int) will return a number between 0 (inclusive) and the specified number (exclusive). This means that you can get any of the following numbers:

0, 1, 2, 3

As you can see, one of those numbers is 0, so the player has a 1/4 chance of shooting 0 arrows.

That's all for bugs

CraftCreeper6
Ahh. I see. Brainfart on my end.

Grats

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

timtower
That might also be the case. I was thinking of how Java removes certain components on compile, like generic types.

 

CraftCreeper6
it doesnt work for 1.7.2 R0-2 ?

 

XdarkbeastX
I don't know, as I said, I am not going to re-code it just because you want it for 1.7.2

 

CraftCreeper6
ok

 

bump

 

bump

 

bump