ArrayList Problem

Earlier I created a getter for my ArrayList and yada yada yada. Which looks like this:

Code:java

    public ArrayList<String> getFillBottle() {
        ArrayList<String> playerFillBottleToggle = new ArrayList<String>();
        return playerFillBottleToggle;
    }

After that, I used my getter in my command, which looks like this:

Code:java

@Override
    public boolean onCommand(CommandSender cs, Command c, String s, String[] a) {
        if (c.getName().equalsIgnoreCase("fillbottle")) {
            if (cs instanceof Player) {
                final Player p = (Player) cs;
                if (!u.getFillBottle().contains(p.getUniqueId().toString())) {
                    p.sendMessage("does not have player's uuid");
                    u.getFillBottle().add(p.getUniqueId().toString());
                    p.sendMessage("FillBottle enabled.");
                    return true;
                }
                p.sendMessage("does have player's uuid");
                u.getFillBottle().remove(p.getUniqueId().toString());
                p.sendMessage("FillBottle disabled.");
                return true;
            }
        }
        return false;
    }

My problem is that the player's UUID never gets removed - ever. What I mean is, when a player uses /fillbottle for the first time, it stores (I guess, not sure if my getter is working) their UUID into an ArrayList and sends them a message <- that part works fine. When they use it again, it should remove them from the ArrayList, but it fails to do so. Instead, it just puts their UUID back into the ArrayList again, and sends them the message.

Is my ArrayList failing to add them, is my getter not working, is my brain bad? I'm not sure, so I came to you guys. I'm still trying things out to see if I can get this to work, but if one of you know what's wrong, please feel free to tell me.

 

HeadGam3z
Each time you call your getter...your creating a new array list that is empty and returning the new list. Make sure your returning the right list in your getter.

 

MCForger
Oh, yeah, my bad... Guess I need some more coffee.
Thanks for your help!

 

HeadGam3z
No problem.

 

MCForger
Would you happen to know why it wouldn't be able to read the arraylist from a different class...? I have an event that checks if a player's uuid is in that arraylist, and if so, do something. But the player's uuid is never in the list, apparently... When I toggle the /fillbottle command, it works perfectly. But my event for some reason cannot seem to understand that a player's uuid is in the list.

Reconfiguration my getter - which is in my Util class:

Code:java

    ArrayList<String> playerFillBottleToggle = new ArrayList<String>();
 
    public ArrayList<String> getFillBottle() {
        return playerFillBottleToggle;
    }

After I toggle my /fillbottle to on and try to use my event, it says "not in list".
Event:

Code:java

Util u = new Util();
 
    @EventHandler
    public void playerRightClick(PlayerInteractEvent e) {
        final Player p = e.getPlayer();
        ItemStack emptyBottle = new ItemStack(Material.GLASS_BOTTLE);
        if (e.getAction() == Action.RIGHT_CLICK_BLOCK
                || e.getAction() == Action.RIGHT_CLICK_AIR) {
            if (p.getItemInHand() != null) {
                if (p.getItemInHand().equals(emptyBottle)) {
                    if (u.getFillBottle().contains(p.getUniqueId().toString())) {
                        p.getInventory().getItemInHand()
                                .setType(Material.POTION);
                        p.sendMessage("Bottle filled!");
                        return;
                    } else {
                        p.sendMessage("not in list"); // message I get everytime.
                    }
                } else {
                    p.sendMessage("bottle no bottle");
                }
            } else {
                p.sendMessage("null");
            }
        } else {
            p.sendMessage("uht oh");
        }
    }

Please don't feed me code btw, hints are better than code anyways.

 

HeadGam3z
Are you creating a new util class twice instead of just passing the same object through a constuctor or making it static?

 

MCForger
Creating util twice.. I would pass the same object through a constructor, but I do not know how I would do that. Guess I'll do some research, but until then, I'll make it static for now as it does work, but I really don't like to use static.

Thanks again!