Solved Argument Troubles

Hello, I recently ran my broadcast command on my server, and when I run it with just the command, it adds in my prefix but nothing else. Can someone help me with placing arguments into my code? Thanks. ~Beast

Code:

  public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args)
  {
    int i;
    if (commandLabel.equalsIgnoreCase("ebc")) {
        if ((sender.hasPermission("easybroadcast.broadcast")) || ((sender instanceof ConsoleCommandSender))) {
      StringBuilder sb = new StringBuilder();
      for (i = 0; i < args.length; i++) {
        sb.append(args[i]).append(" ");
      }
      if (sender.hasPermission("easybroadcast.broadcast"))
        Bukkit.broadcastMessage(ChatColor.translateAlternateColorCodes('&', getConfig().getString("ManualPrefix")) + ChatColor.translateAlternateColorCodes('&', getConfig().getString("ManualMessageColor")) + sb.toString());
      else {
        sender.sendMessage(ChatColor.LIGHT_PURPLE + "You don't have permission!");
              }
        }
    }

 

HelpfulBeast
I can't see a problem in your StringBuilder, but I do see one with your permission checks.

Formated Code (open) Formated Code (close)

Code:java

public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args){
    int i;
    if (commandLabel.equalsIgnoreCase("ebc")) {
        if ((sender.hasPermission("easybroadcast.broadcast")) || ((sender instanceof ConsoleCommandSender))) {
            StringBuilder sb = new StringBuilder();
            for (i = 0; i < args.length; i++) {
                sb.append(args).append(" ");
            }
            if (sender.hasPermission("easybroadcast.broadcast"))
                Bukkit.broadcastMessage(ChatColor.translateAlternateColorCodes('&', getConfig().getString("ManualPrefix")) + ChatColor.translateAlternateColorCodes('&', getConfig().getString("ManualMessageColor")) + sb.toString());
            else {
            sender.sendMessage(ChatColor.LIGHT_PURPLE + "You don't have permission!");
            }
        }
    }
}

On line 4, you check if they have permission, which is all fine and dandy, but then, within that if, you again check if they have permission, but don't check if they are a ConsoleCommandSender. You should change your method like so:

New Code (open) New Code (close)

Code:java

public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args){
    int i;
    if (commandLabel.equalsIgnoreCase("ebc")) {
        if ((sender.hasPermission("easybroadcast.broadcast")) || ((sender instanceof ConsoleCommandSender))) {
            StringBuilder sb = new StringBuilder();
            for (i = 0; i < args.length; i++) {
                sb.append(args).append(" ");
            }
            Bukkit.broadcastMessage(ChatColor.translateAlternateColorCodes('&', getConfig().getString("ManualPrefix")) + ChatColor.translateAlternateColorCodes('&', getConfig().getString("ManualMessageColor")) + sb.toString());
        } else {
            sender.sendMessage(ChatColor.LIGHT_PURPLE + "You don't have permission!");
        }
    }
}

Also, note that you can setup for loops like:

Code:java

for (int i = 0; i < aNumber; i++){}

 

GusGold
Thanks. For some reason, I am getting a error on the last bracket in the statement. Here is the fixed:

Code:

  public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args){
        int i;
        if (commandLabel.equalsIgnoreCase("ebc")) {
            if ((sender.hasPermission("easybroadcast.broadcast")) || ((sender instanceof ConsoleCommandSender))) {
                StringBuilder sb = new StringBuilder();
                for (i = 0; i < args.length; i++) {
                    sb.append(args).append(" ");
                }
                Bukkit.broadcastMessage(ChatColor.translateAlternateColorCodes('&', getConfig().getString("ManualPrefix")) + ChatColor.translateAlternateColorCodes('&', getConfig().getString("ManualMessageColor")) + sb.toString());
            } else {
                sender.sendMessage(ChatColor.LIGHT_PURPLE + "You don't have permission!");
            }
        }
    } /* This bracket here. The error is "Syntax error on token "}", { expected after this token" */

 

HelpfulBeast
You need an extra '}' to close your onCommand method

 

GusGold
I added an extra one, and the error is as shown above still.

 

HelpfulBeast
Can you put your whole class in here?

 

GusGold
Sure! Here you go. http://pastebin.com/MW194p4m

 

HelpfulBeast Don't add an extra one

return true; or return false at the end of the boolean

 

HelpfulBeast
Ahh, okay, So where it says return false; remove the } preceeding it. When i said to add it earlier, it didn't have the return false after.

HelpfulBeast
You will also want to return true; after you do your Bukkit.broadcastMessage(); and after "You don't have permission"

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

GusGold DailyLove
Alright cool. So I run my command, and here is what I get:


It seems like my string is messed up. Here is the new and updated code. :

Code:java

  public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args){
   int i;
   if (commandLabel.equalsIgnoreCase("ebc")) {
       if ((sender.hasPermission("easybroadcast.broadcast")) || ((sender instanceof ConsoleCommandSender))) {
           StringBuilder sb = new StringBuilder();
           for (i = 0; i < args.length; i++) {
               sb.append(args).append(" ");
           }
           Bukkit.broadcastMessage(ChatColor.translateAlternateColorCodes('&', getConfig().getString("ManualPrefix")) + ChatColor.translateAlternateColorCodes('&', getConfig().getString("ManualMessageColor")) + sb.toString());
       return true;
       } else {
           sender.sendMessage(ChatColor.LIGHT_PURPLE + "You don't have permission!");
           return true;
       }
   }
return false;
}
 

 

HelpfulBeast
Yeah, that's giving you the object details, not the content.
If you didn't want to use StringBuilder, you could just replace sb.append() with:

Code:java

broadcastMessage += args[ i];

but don't forget to initiate it before the for loop with

Code:java

String broadcastMessage ="";

 

GusGold
Alright, so the String broadcastMessage =""; is giving me a yellow line under "broadcastMessage", and yes I added the "broadcastMessage += args;" thing. Shall I just add SurpressWarnings?

Thanks for your continuous help!

 

HelpfulBeast
I assume the warning is that the variable is unused? Make sure you replaced the sb.toString() with broadcastMessage when you broadcast the message to the server

 

GusGold
I added it, still yellow: String broadcastMessage. Here is the full method. I may need someone else's opinion on this, but it looks like it is fine to me.

Code:Java

Code:Java

Code:Java

 
public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args){
int i;
if (commandLabel.equalsIgnoreCase("ebc")) {
if ((sender.hasPermission("easybroadcast.broadcast")) || ((sender instanceof ConsoleCommandSender))) {
StringBuilder sb = new StringBuilder();
String broadcastMessage ="";
for (i = 0; i < args.length; i++) {
broadcastMessage += args[ i];
}
Bukkit.broadcastMessage(ChatColor.translateAlternateColorCodes('&', getConfig().getString("ManualPrefix")) + ChatColor.translateAlternateColorCodes('&', getConfig().getString("ManualMessageColor")) + sb.toString());
return true;
} else {
sender.sendMessage(ChatColor.LIGHT_PURPLE + "You don't have permission!");
return true;
}
}
return false;
}
[COLOR=#ffcc00][COLOR=#000000][/COLOR][/COLOR]

 

HelpfulBeast
Alright,

Old (open) Old (close)

Code:java

public boolean onCommand(CommandSender sender, Command cmd, StringcommandLabel, String[] args){
    int i;
    if (commandLabel.equalsIgnoreCase("ebc")) {
        if ((sender.hasPermission("easybroadcast.broadcast")) || ((sender instanceof ConsoleCommandSender))) {
            StringBuilder sb = new StringBuilder();
            String broadcastMessage ="";
            for (i = 0; i < args.length; i++) {
                broadcastMessage += args[i];
            }
            Bukkit.broadcastMessage(ChatColor.translateAlternateColorCodes('&', getConfig().getString("ManualPrefix")) + ChatColor.translateAlternateColorCodes('&', getConfig().getString("ManualMessageColor")) + sb.toString());
            return true;
        } else {
            sender.sendMessage(ChatColor.LIGHT_PURPLE + "You don't have permission!");
            return true;
        }
    }
    return false;
}[/i]

New (open) New (close)

Code:java

public boolean onCommand(CommandSender sender, Command cmd, StringcommandLabel, String[] args){
    int i;
    if (commandLabel.equalsIgnoreCase("ebc")) {
        if ((sender.hasPermission("easybroadcast.broadcast")) || ((sender instanceof ConsoleCommandSender))) {
 
            String broadcastMessage ="";
            for (i = 0; i < args.length; i++) {
                broadcastMessage += args[i];
            }
            Bukkit.broadcastMessage(ChatColor.translateAlternateColorCodes('&', getConfig().getString("ManualPrefix")) + ChatColor.translateAlternateColorCodes('&', getConfig().getString("ManualMessageColor")) + broadcastMessage);
            return true;
        } else {
            sender.sendMessage(ChatColor.LIGHT_PURPLE + "You don't have permission!");
            return true;
        }
    }
    return false;
}[/i]

So on line 5, I removed the sb as you don't need that anymore, and at the end of line 10, I replaced 'sb.toString()' with 'broadcastMessage'.
Have a go at that

HelpfulBeast
Also, just ignore the [ /i] at the end of the lines, it's because the format parser thinks that our args[ i]; means we want italics... -_-

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

GusGold
Oh my god you are godlike. One last thing. Can we set up some arguments to where if the sender enters nothing after the command, it returns a message saying that you need something after the command? (Hope that made sense. ) Here is the updating file. I did some editing to my likings.

Code:Java

  public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args)
  {
   if (commandLabel.equalsIgnoreCase("ebc")) {
       if ((sender.hasPermission("easybroadcast.broadcast")) || ((sender instanceof ConsoleCommandSender))) {
 
      int i;
           String broadcastMessage ="";
           for (i = 0; i < args.length; i++) {
           broadcastMessage += args[i];
 
           }
           Bukkit.broadcastMessage(ChatColor.translateAlternateColorCodes('&', getConfig().getString("ManualPrefix")) + ChatColor.translateAlternateColorCodes('&', getConfig().getString("ManualMessageColor")) + broadcastMessage);
           return true;
       } else 
       {
           sender.sendMessage(ChatColor.LIGHT_PURPLE + "You don't have permission!");
           return true;
       }
   }
   return false;
  }[/i]

GusGold

And no problem. I caught that.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Easy peasy!
Right after checking for permissions

Code:java

if ((sender.hasPermission("easybroadcast.broadcast")) || ((sender instanceof ConsoleCommandSender))) {

Check if the length of args = 0:

Code:java

if (args.length == 0){
    sender.sendMessage("Y U no message!");
    return true;
}

EDIT: Fixed derp

 

GusGold
Cool! So for some reason, it didn't like the "length()" idea so I changed it to "length". Here is the method:

Code:Java

if(args.length == 0){
           sender.sendMessage(ChatColor.RED + "Command Usage: /ebc YourBroadcastHere");
           return true;
       }

Now let me do testing....... Results: Much love sir! Works perfectly! I will use everything for future reference!

Now just.... One more question. xD If for say on a command I wanted to add an args length that runs off of a certain keyword as to: "/test word1" "/test word2". How infact, would this be done? Thanks again! ~Beast

 

Woops, yeah, length is a property, not a method

Also, I don't quite get what you mean 'args length of a certain keyword'?

 

GusGold

Like say.... Like... Hm.. Here is an example:

"/fly on"
sender.setFly (enabled) for instance.

"/fly off"
sender.setFly (disabled)

Each one does their own thing. Hopefully I am not confusing you too much.

 

HelpfulBeast
Ahh gotcha
For your /fly on|off example, you would have your onCommand() and you would check that your cmd.equalIgnoreCase("fly). This checks that the cmd was indeed '/fly'. Then you check that the sender has supplied at least one argument: if (args.length > 0)
if it is, then you check if args[0].equalsIgnoreCase("on")
if so, toggle fly mode to be on for them
then if args[0].equalsIgnoreCase("off")
and toggle fly off.

HelpfulBeast
What your actually code could look like:

Code:java

public boolean onCommand(CommandSender sender, Command cmd, String Label, String[] args){
    if (cmd.equalsIgnoreCase("fly"){
        if(args.length > 0){
            if(args[0].equalsIgnoreCase("on"){
                if(sender instanceof Player)
                    sender.setFlying(true);
                else
                    sender.sendMessage("Need to be a player to fly");
            } else if(args[0].equalsIgnoreCase("off"){
                if(sender instanceof Player)
                    sender.setFlying(false);
                else
                    sender.sendMessage("Need to be a player to fly");
            }
            return true;
        } else {
            sender.sendMessage("You need to supply an argument");
        }
    }
    return false;
}
 
EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

GusGold
Alright cool. I am setting that up in a different class just to test. Here is an error I am getting. I will explain it after the picture.


It tells me to add a ";" instead of the brackets. What seems to be the deal here? That doesn't make sense. Haha. Sorry

@GusGold
WHOA! Jesus. I didn't need the fly part of it. xD Was just an example. Much love to you. I will use the args examples as information for further use.

As of right now, SOLVED.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Yeah, you need an if surrounding your args[0].equalsIgnoreCase("on")

 

GusGold
Cool, also Gus, I decided to add permissions into that method. Is the else{} part of my permissions right with the statement? Should it work as that?

Edit: Unproper formatting. Better:

Code:

    public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args)
    {
        if(commandLabel.equalsIgnoreCase("fly")){
            if(sender.hasPermission("permission.permission") || sender instanceof ConsoleCommandSender){
            if(args.length > 0){
                if(args[0].equalsIgnoreCase("on")){
                    // Actions Here
                } else if(args[0].equalsIgnoreCase("off")){
                    // Actions Here
                } else{
                    sender.sendMessage("Supply an argument!");
                }
            } else{
                sender.sendMessage("You don't have permission.");
            }
        }
    }
        return false;
    }

 

You're welcome!

Your else needs to be one '}' level lower. It's currently 'elsing' the if(args.length >0)

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

GusGold
LOL! Thanks to you! That is probably all I am asking for now.

If it weren't for you, I would have made almost zero progress today. If I need anything in a while, I will just Tahg. Sorry for being a pain in the butt at times. You have helped greatly.

 

HelpfulBeast
xD All good

 

GusGold
Okay you know what. Back to bothering.... Sorry

I was doing some testing on the command we were working on /ebc. When I try to enter spaces in between my words... It joins them together... My oh my.



Alright... My code:

Code:Not Again

  public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args)
  {
   if (commandLabel.equalsIgnoreCase("ebc")) {
       if ((sender.hasPermission("easybroadcast.broadcast")) || ((sender instanceof ConsoleCommandSender))) {
 
       if(args.length == 0){
           sender.sendMessage(ChatColor.RED + "Command Usage: /ebc Broadcastmessagehere");
           return true;
       }
 
      int i;
           String broadcastMessage ="";
           for (i = 0; i < args.length; i++) {
           broadcastMessage += args[i];
 
           }
           Bukkit.broadcastMessage(ChatColor.translateAlternateColorCodes('&', getConfig().getString("ManualPrefix")) + ChatColor.translateAlternateColorCodes('&', getConfig().getString("ManualMessageColor")) + broadcastMessage);
           return true;
       } else 
       {
           sender.sendMessage(ChatColor.LIGHT_PURPLE + "You don't have permission!");
           return true;
       }
   }
   return false;
  }[/i]

GusGold
If you don't mind taking a look at that issue for me that would be great.

But I have to go to sleep, school tomorrow. Lol. After school, I will answer your response (if any) and work from there.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

HelpfulBeast may I suggest something?

I suggest you google, watch or maybe read a little about if operators and booleans. It would really help, and you would be getting this stuff like a breeze!

 

HelpfulBeast
Change

Code:java

broadcastMessage += args[i];[/i]

to

Code:java

broadcastMessage += args[i] + " ";[/i]

Ignore those damn '[ /i]' again