Archer class : LongShot

Hey guys! I am making an Archer kit for my kits server. Basically what I want it to do is when the shooter hits the enemy and the enemy was 30 blocks away, I want it to double the damage and message the player LongShot! Damage doubled! Any help guys? Thanks!
This is the code I have so far but I am not sure what to do next.

Code:java

    public void ArcherShot(EntityDamageByEntityEvent e){
        Player p = (Player) e.getEntity();
        Player d = (Player) e.getDamager();
        if (plugin.Archer.contains(d.getName())){
            if (e.getDamager() instanceof Player && e.getEntity() instanceof Player){
                if ( )
 
            }
        }
 
    }
 

 

Id assume it would be something like
if(p.getLocation().getBlockX() == d.getLocation().getBlockX() + 30){

}

Untested, so not sure if it works like that

 

I put that in and it made me get rid of the X to say it works. What would I do after that though to double the damage? I already tried p.getLastDamage() * 2 but it said the left side but be a variable. This is my code now...

Code:java

    public void ArcherShot(EntityDamageByEntityEvent e){
        Player p = (Player) e.getEntity();
        Player d = (Player) e.getDamager();
        if (plugin.Archer.contains(d.getName())){
            if (e.getDamager() instanceof Player && e.getEntity() instanceof Player){
                if(p.getLocation().getBlock().equals(d.getLocation().getBlockX() + 30));{
 
 
                }
 
            }
        }
 
    }
}

 

Try

Code:java

if(event.getCause() == DamageCause.PROJECTILE){
if(event.getDamager() instanceof Arrow){
if(event.getEntity() instanceof Player){
event.setDamage(2x Whatever the damage of the arrow WOULD be); 
}

 

TCO_007
Here's a method that I use to check if a player is nearby

Code:java

    public static boolean isClose(Player p, Player result, int distance) {
        // Loop through all nearby entities and check if the player we are looking for is in them.
        for (Entity e : p.getNearbyEntities(distance, distance, distance)) {
            if (e instanceof Player) {
                Player player = (Player) e;
                if (player.getName().equalsIgnoreCase(result.getName()))
                    return true;
               continue;
            }
        }
        return false;
    }

Now, you want to check if the player is not within 30 blocks away:

Code:java

if (!isClose(d, p, 30)) {
  e.setDamage(e.getDamage() * 2);
}

 

Where would I put that code though? I tried to branch if off of my code but it would work. Do I erase my code and input your code or..... tommyhoogstra

Thank you AoH_Ruthless
Ill see if yours works

Let's see. I just changed something in it and there are no errors now with yours tommyhoogstra so is there any errors with this that you guys can see?

Code:java

    public void ArcherShot(EntityDamageByEntityEvent e){
        Player p = (Player) e.getEntity();
        Player d = (Player) e.getDamager();
        if (plugin.Archer.contains(d.getName())){
            if (e.getDamager() instanceof Player && e.getEntity() instanceof Player){
                if(p.getLocation().getBlock().equals(d.getLocation().getBlockX() + 30));{
                    if(e.getCause() == DamageCause.PROJECTILE){
                        if (!isClose(d, p, 30)) {
                        if(e.getDamager() instanceof Arrow){
                        if(e.getEntity() instanceof Player){
                        e.setDamage((e.getDamage() * 2));
                        }
                }
                }
            }
        }
    }
}
}
    public static boolean isClose(Player p, Player result, int distance) {
        // Loop through all nearby entities and check if the player we are looking for is in them.
        for (Entity e : p.getNearbyEntities(distance, distance, distance)) {
            if (e instanceof Player) {
                Player player = (Player) e;
                if (player.getName().equalsIgnoreCase(result.getName()))
                    return true;
              continue;
            }
        }
        return false;
    }
}

It still doesnt work D:

I dont know why though. Any help? My code is still the same as the one above.

Whats happening is a shot right next to the player still does the same amount of damage as the player is 30 blocks away. I want the plugin to be able to tell that the player if the player is more than 30 blocks away and hits the enemy, it will deal double the damage. Nothings happening though.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

It should just go into your last if statement fine, whats it telling you?

 

First get the instance then cast:

Code:java

Entity ent = e.getEntity();
Entity dam = e.getDamager();
 
if(ent instanceof Player && dam instanceof Arrow) {
Player p = (Player) e.getEntity();
Entity a = (Arrow) e.getDamager();
 
}

 

so like this?

Code:java

@EventHandler
public void ArcherShot(EntityDamageByEntityEvent e){
Player p = (Player) e.getEntity();
Player d = (Player) e.getDamager();
if (plugin.Archer.contains(d.getName())){
Entity ent = e.getEntity();
Entity dam = e.getDamager();
 
if(ent instanceof Player && dam instanceof Arrow) {
Entity a = (Arrow) e.getDamager();
            if (!isClose(d, p, 30)) {
            e.setDamage((e.getDamage() * 2));
            }
    }
    }
}
public static boolean isClose(Player p, Player result, int distance) {
// Loop through all nearby entities and check if the player we are looking for is in them.
for (Entity e : p.getNearbyEntities(distance, distance, distance)) {
if (e instanceof Player) {
    Player player = (Player) e;
    if (player.getName().equalsIgnoreCase(result.getName()))
        return true;
  continue;
}
}
return false;
}
 
 
}

Minesuchtiiii

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

I think yes @ TCO_007