[ADMN] ModTRS v2.1 - Moderator Ticket Request System [1240]

Just found a bug in 141 on 766, I was standing in front of someone (online obviously), and I did a /check to see how many where open, and noticed someone standing infront of me had a mod request in but their name was red, so I /check'd their req # then it started showing green... just a little bug

 

few things ;]
mutliworld teleportation doesnt work
the minus in /tp-id is annoying
the colon in /check p:2 is annoying
cant check modreq from the console
it would be nice to have an otpion to see more than 5req per page

...and that "uncheck multiple item" option ;]

 

Multiworld support isn't added yet, but it will be.

Okay? I'm sure it won't hurt you to type an extra character.

Coming in a future version...

You do. Check the config.

 

Hey could you fix the link for CraftBukkituptoDate for us? really appreciate the work you put into this!

 

ability to leave a message to the person that made a ticket would be nice.
also ability to leave a message to the player when closing the ticket would be nice too..

 

You can. /done ID message

 

I am not sure if this is a bug or not but I will post it here so at least some one is aware of it:

If in the config file max_requests are set to 1 then:
Users can make two requests before they are told they can not make anymore requests.
If in the config file max_requests are set to 0 then:
Users can make as many requests as they want and are never told they can make more requests.
If in the config file max_requests are set to 2 then:
Users can make three requests before they are told they can not make anymore requests.

 

Could you add search for player function to check command?

 

NM I fixed it my self

 

How? We have this same issue, with:

max_requests: 1

Users can still spam requests. I had to resort to setting a unique key on the column in MySQL, but that gives off an exception every time there's a double request.

A fix in the plugin would be ideal.

 

I grabbed the source. I reassembled it in eclipse. I found the spot with the programming glitch. I fixed it. Then recompiled it.

 

Did you post it somewhere?

 

I believe it's not allowed or atleast highly discouraged to post unofficial releases. You could reassemble it yourself though, or get your plugin devs to do it.

 

Yea we have a custom build in our repo now with this issue fixed. Something with -1 needing to be 0, or so.

 

Could you post the fix? I'll implement it and credit you.

 

The fix is easy..
I don't know what he did to fix his but all your missing is one character.

In ModreqCommand.java: line 65

Code:

if (request_count > ModTRSSettings.maxRequests) {

should be

Code:

if (request_count >= ModTRSSettings.maxRequests) {

Bam Fixed!

This is of course based on your original code.

 

Not multi-world compatible.

Given a ModReq in World1, and you check it in World2, you will go to the coordinates.. in World2.

 

Just coming in here to thank you. This is the most useful plugin on our server and there is nothing that needs to be improved on. Good job.

 

@Yetanotherx
typing /check doesn't work, the chat-reply is only "/check"
nothing in the log
writing a modreq works fine
/claim and /done are working too
CB860&928, Permissions3, same with and without mySQL

edit: sRPG reserved /check ... but i removed it

 

Looking forward to seeing something new on this plugin

 

sometimes i have to uncheck dozens of requests a day, believe me the extra characters hurt.
especially now with the five digit id's! dynamic id's would be nice, maybe resenting every 24h...
i would resent it manually but i don't want to loose my db, witch brings me to my next point - some kind of statistics would be nice, i don't know who to "fire" from oping and this db is just asking for this kind of functionality (chlitto - done: 20 in the last week)

...and maybe some kind of "automatic temporary claim" (for 1min) when someone uses "tp-id" so no other moderator will do the same, and after that /done would close the request without the need to fill in the id

/edit i know i'm giving too complicated requests ;] but... in some cases (hundreds in the last days on my server) i need to tp someone to my place to process the request, so the "automatic temporary claim" option would need a "tphere-id" command

 

Have been looking through plugins while I'm waiting for my Box to get a RAM upgrade, this is a very interesting plugin, my server isn't the type to get griefed.. well not very much at all, but there's always a fair bit of chat activity, and this would make life a lot easier for my staff. Going to give it a go for sure.

 

You could always edit the plugin.yml file witin the jar and edit the command names to your pleasure..... Not responsible if you break your server or other plugins. Just a suggestion.

 

Will custom messages (for Multi-Language support) ever be implemented ?

 

i've just started getting this today for no reason o.o

Code:

2011-07-07 15:07:12 [SEVERE] java.lang.NullPointerException
2011-07-07 15:07:12 [SEVERE]     at yetanotherx.bukkitplugin.ModTRS.command.CheckCommand.onCommand(CheckCommand.java:96)
2011-07-07 15:07:12 [SEVERE]     at yetanotherx.bukkitplugin.ModTRS.command.CommandHandler.onCommand(CommandHandler.java:147)
2011-07-07 15:07:12 [SEVERE]     at yetanotherx.bukkitplugin.ModTRS.ModTRS.onCommand(ModTRS.java:153)
2011-07-07 15:07:12 [SEVERE]     at org.bukkit.command.PluginCommand.execute(PluginCommand.java:35)
2011-07-07 15:07:12 [SEVERE]     at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:129)
2011-07-07 15:07:12 [SEVERE]     at org.bukkit.craftbukkit.CraftServer.dispatchCommand(CraftServer.java:298)
2011-07-07 15:07:12 [SEVERE]     at net.minecraft.server.NetServerHandler.handleCommand(NetServerHandler.java:711)
2011-07-07 15:07:12 [SEVERE]     at net.minecraft.server.NetServerHandler.chat(NetServerHandler.java:676)
2011-07-07 15:07:12 [SEVERE]     at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:669)
2011-07-07 15:07:12 [SEVERE]     at net.minecraft.server.Packet3Chat.a(Packet3Chat.java:33)
2011-07-07 15:07:12 [SEVERE]     at net.minecraft.server.NetworkManager.b(NetworkManager.java:226)
2011-07-07 15:07:12 [SEVERE]     at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:84)
2011-07-07 15:07:12 [SEVERE]     at net.minecraft.server.NetworkListenThread.a(SourceFile:105)
2011-07-07 15:07:12 [SEVERE]     at net.minecraft.server.MinecraftServer.h(MinecraftServer.java:451)
2011-07-07 15:07:12 [SEVERE]     at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:361)
2011-07-07 15:07:12 [SEVERE]     at net.minecraft.server.ThreadServerApplication.run(SourceFile:422)
2011-07-07 15:07:18 [SEVERE] java.lang.NullPointerException
2011-07-07 15:07:18 [SEVERE]     at yetanotherx.bukkitplugin.ModTRS.command.CheckCommand.onCommand(CheckCommand.java:96)
2011-07-07 15:07:18 [SEVERE]     at yetanotherx.bukkitplugin.ModTRS.command.CommandHandler.onCommand(CommandHandler.java:147)
2011-07-07 15:07:18 [SEVERE]     at yetanotherx.bukkitplugin.ModTRS.ModTRS.onCommand(ModTRS.java:153)
2011-07-07 15:07:18 [SEVERE]     at org.bukkit.command.PluginCommand.execute(PluginCommand.java:35)
2011-07-07 15:07:18 [SEVERE]     at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:129)
2011-07-07 15:07:18 [SEVERE]     at org.bukkit.craftbukkit.CraftServer.dispatchCommand(CraftServer.java:298)
2011-07-07 15:07:18 [SEVERE]     at net.minecraft.server.NetServerHandler.handleCommand(NetServerHandler.java:711)
2011-07-07 15:07:18 [SEVERE]     at net.minecraft.server.NetServerHandler.chat(NetServerHandler.java:676)
2011-07-07 15:07:18 [SEVERE]     at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:669)
2011-07-07 15:07:18 [SEVERE]     at net.minecraft.server.Packet3Chat.a(Packet3Chat.java:33)
2011-07-07 15:07:18 [SEVERE]     at net.minecraft.server.NetworkManager.b(NetworkManager.java:226)
2011-07-07 15:07:18 [SEVERE]     at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:84)
2011-07-07 15:07:18 [SEVERE]     at net.minecraft.server.NetworkListenThread.a(SourceFile:105)
2011-07-07 15:07:18 [SEVERE]     at net.minecraft.server.MinecraftServer.h(MinecraftServer.java:451)
2011-07-07 15:07:18 [SEVERE]     at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:361)
2011-07-07 15:07:18 [SEVERE]     at net.minecraft.server.ThreadServerApplication.run(SourceFile:422)

happens when I do /check, and ingame it says 'contact an administrator'

 

This plugin is GENIUS! I'm going to put some money in Paypal and donate to you, sir.

My one request has to do with potential moderator incentives. My moderators don't really NEED an incentive to answer requests, but it would be nice to give back to them a little for taking up their game time. Moderation is usually such a thankless task. My idea would be to integrate this with iConomy or another economy plugin or /item spawning command. In the configuration, you could set ModTRS to either give a moderator money per a configurable number of requests completed or perhaps an item per configurable number of requests completed.

Another idea I had was the ability for users to give feedback when they're messaged about their ticket being completed. This could be logged with their feedback message (or even maybe a simple, "Were you helped? Use '/req yes' or '/req no') and with the request they made. This could potentially prevent moderators from using the /done command to just clear out tickets without getting caught by higher admins.

Again, though, ignore my desires. FANTASTIC plugin already! Great job!

 

oooo I love that idea

 

I think multiworld support for /tp-id would be great aswell

 

can you make it so once a ticket is claimed it tells the player its claimed just like when it gets completed

 

I'm going to do something naughty and not read the rest of the thread. Love the system, interesting design, but would it be possible to include a spam prevention and banning system into this plugin? Some people like to include personal messages and it'd be a shame if the admins / mods were offline and someone decided to make 50 requests