Adding a new line to a file every time a command is executed

ok so i have this code
dont know what all of this stuff is lol

Code:java

if(args[0].equalsIgnoreCase("put") && sender.hasPermission("log.put")){
try {
FileWriter fw = new FileWriter(log);
String msg = ChatColor.GREEN + "[" + ChatColor.AQUA+ sender.getName() + ChatColor.GREEN + "] " + ChatColor.RESET;
for(int i = 1; i < args.length; i++){
msg = msg.concat(args[I] + " ");[/I]
[I]}[/I]
[I]fw.write(msg + "\n");[/I]
[I]fw.close();[/I]
[I]sender.sendMessage(msg + ChatColor.GREEN + " Has been written to the Admin Log!");[/I]
[I]}catch(IOException e){[/I]
[I]sender.sendMessage(ChatColor.RED + "Something went wrong while attempting to write to the log!");[/I]
 
[I]}[/I]
[I]}[/I]

every time i use my command /log put.
it overwrites the existing text.
im probably doing somehting terribly wrong that i dont know about here but could someone pls help.

 

So what is it exactly your trying to do?
I have some code that i use to add lines to a file, it looks alot simpler than this, let me get the code for you, and i can explain it.

This Should work, i just wrote it up, didnt test it yet, so no guarantees. If theres something wrong just tell me. So just add this code inside the command parameters thing, in place of your old file create code.
Explanation:
So first it will create a folder in your plugins folder with the name of your plugin. Then it will create a new file log.yml
Everytime someone does the command it will write to the log file what you wanted, and it will send them a message.
The try and catch just mean TRY to make the file but if it cant, then catch the reason/error and it will display it.
Again this code SHOULD work, but if it doesnt then just tell me, and i can look at in more indepth in eclipse.

PHP:

                    Player player = (Player) sender;
                    File file = new File(Bukkit.getPluginManager().getPlugin("PLUGINNAMEGOESHERE").getDataFolder(),"log.yml");
                        if (!file.exists()) {
                            try {
                                String msg = ChatColor.GREEN + "[" + ChatColor.AQUA+ sender.getName() + ChatColor.GREEN + "] " + ChatColor.RESET;
                                file.createNewFile();
                                PrintWriter out = new PrintWriter(file);
                                out.println("[" + sender.getName() + "] ");
                                out.close();
                                sender.sendMessage(msg + ChatColor.GREEN + " Has been written to the Admin Log!");
                            } catch (IOException e) {
                                e.printStackTrace();
                               sender.sendMessage(ChatColor.RED + "Something went wrong while attempting to write to the log!");
                            }
            }

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

LOL im not an idiot but i did try this method too.
lol no no i have the file and everything its just writing to it multiple times.
xD
read the OP
its supposed to write the other arguements to the end of a file every time that command is executed
whole class

Show Spoiler Hide Spoiler

Code:java

package me.tommycake50.alog;
 
import java.io.File;
import java.io.FileNotFoundException;
import java.io.FileWriter;
import java.io.IOException;
import java.util.Scanner;
 
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.event.Listener;
import org.bukkit.plugin.java.JavaPlugin;
 
public class ALog extends JavaPlugin {
private File log;
public void onEnable(){
listFileChecks();
}
 
//method to see if the log file exists and if not create a new one
private void listFileChecks() {
if(!getDataFolder().exists()){
getDataFolder().mkdir();
File fl = new File(getDataFolder(), "logfile.log");
if(fl.exists()){
log = fl;
}else{
try {
fl.createNewFile();
log = fl;
} catch (IOException e) {
e.printStackTrace();
}
}
}else{
File fl = new File(getDataFolder(), "logfile.log");
if(fl.exists()){
log = fl;
}else{
try {
fl.createNewFile();
log = fl;
} catch (IOException e) {
e.printStackTrace();
}
}
}
}
 
 
@Override
public boolean onCommand(CommandSender sender, Command command,
String label, String[] args) {
if(label.equalsIgnoreCase("log")){
if(args.length == 1){
if(args[0].equalsIgnoreCase("read") && sender.hasPermission("alog.read")){
try {
Scanner fr = new Scanner(log);
while(fr.hasNextLine()){
sender.sendMessage(fr.nextLine());
}
fr.close();
} catch (FileNotFoundException e) {
e.printStackTrace();
}
}else if(args[0].equalsIgnoreCase("help")){
sender.sendMessage(ChatColor.YELLOW + "/log" + ChatColor.BLUE + " read" + ChatColor.GREEN + " -shows you everything in the log");
sender.sendMessage(ChatColor.YELLOW + "/log" + ChatColor.BLUE + " put" + ChatColor.GREEN + " -writes a line to the log");
sender.sendMessage(ChatColor.YELLOW + "/log" + ChatColor.BLUE + " help" + ChatColor.GREEN + " -displays this help screen");
sender.sendMessage(ChatColor.YELLOW + "/log" + ChatColor.BLUE + " clear" + ChatColor.GREEN + " -clears the log file of any logs");
}else if(args[0].equalsIgnoreCase("clear") && sender.hasPermission("log.clear")){
resetLog(sender);
}
}else if(args.length >= 2){
if(args[0].equalsIgnoreCase("put") && sender.hasPermission("log.put")){
try {
FileWriter fw = new FileWriter(log);
String msg = ChatColor.GREEN + "[" + ChatColor.AQUA+ sender.getName() + ChatColor.GREEN + "] " + ChatColor.RESET;
for(int i = 1; i < args.length; i++){
msg = msg.concat(args[I] + " ");[/I]
[I]}[/I]
[I]fw.write(msg + "\n");[/I]
[I]fw.close();[/I]
[I]sender.sendMessage(msg + ChatColor.GREEN + " Has been written to the Admin Log!");[/I]
[I]}catch(IOException e){[/I]
[I]sender.sendMessage(ChatColor.RED + "Something went wrong while attempting to write to the log!");[/I]
 
[I]}[/I]
[I]}[/I]
[I]}else if(args.length == 0){[/I]
[I]sender.sendMessage(ChatColor.YELLOW + "/log" + ChatColor.BLUE + " read" + ChatColor.GREEN + " -shows you everything in the log");[/I]
[I]sender.sendMessage(ChatColor.YELLOW + "/log" + ChatColor.BLUE + " put" + ChatColor.GREEN + " -writes a line to the log");[/I]
[I]sender.sendMessage(ChatColor.YELLOW + "/log" + ChatColor.BLUE + " help" + ChatColor.GREEN + " -displays this help screen");[/I]
[I]sender.sendMessage(ChatColor.YELLOW + "/log" + ChatColor.BLUE + " clear" + ChatColor.GREEN + " -clears the log file of any logs");[/I]
[I]}[/I]
[I]}[/I]
[I]return false;[/I]
[I]}[/I]
 
[I]private void resetLog(CommandSender s) {[/I]
[I]log.delete();[/I]
[I]try {[/I]
[I]log = new File(getDataFolder(), "logfile.log");[/I]
[I]log.createNewFile();[/I]
[I]s.sendMessage(ChatColor.GREEN + "Log cleared!");[/I]
[I]} catch (Exception e1) {[/I]
[I]s.sendMessage(ChatColor.RED + "Error resetting log");[/I]
[I]}[/I]
[I]}[/I]
[I]}[/I]
[I][/I]

 

So whats the thing you want to do? You want the user to execute the command, and then it outputs something to the log? Im pretty new to making bukkit plugins, so i may not know much, but i know a little, and may be able to help.

 

no my problem is with java not bukkit it overwrites the line in the file rather than writing a new line.
i should really be using printwriter tho.
even though i tried that it still overwrote.
so ima try a dataoutputstream

 

This is my preferred method of writing to a file.

Code:

public void logMessage(File file, String string) {
  BufferedWriter bw = new BufferedWriter(new FileWriter(file, true));
  bw.append(string);
  bw.newLine();
  bw.close();
}

The true part in the FileWriter is to set it to append. If you do not include that, it will overwrite what is in the file.
The bw.append method just writes to the last line of the file, which is a new line in this case because of the next line, bw.newLine();

 

thanks a lot!

 

Shouldn't you use Loggers for this