Solved 2 players can't use a wand at same time.

Hi all java programmers!

i made a wand plugin with 4 modes on. but when i change my mode, my freind's mode also change.
Somebaody have a solution for this bug?
Here is the code:

Code:java

public class eventfun extends JavaPlugin implements Listener{
 
    public final Logger Logger = java.util.logging.Logger.getLogger("Minecraft");
    public static eventfun plugin;
 
    public void onEnable(){
        PluginDescriptionFile pdfFile = this.getDescription();
        this.Logger.info(pdfFile.getName()+" v"+pdfFile.getVersion()+" Has Been Enabled!");
        this.getServer().getPluginManager().registerEvents(this, this);
    }
 
    public int wandmodes = 1;
    @EventHandler
    public void onPlayerInteract(PlayerInteractEvent e){
        Player p = e.getPlayer();
        if(p.getItemInHand().getType() == Material.BLAZE_ROD){
            if((e.getAction() == Action.RIGHT_CLICK_AIR) || (e.getAction() == Action.RIGHT_CLICK_BLOCK)){
                if(wandmodes < 4){
                    if(wandmodes == 1){
                        p.sendMessage(ChatColor.GOLD+"Lightning mode");
                    }else if(wandmodes == 2){
                        p.sendMessage(ChatColor.GOLD+"Teleport mode");
                    }else if(wandmodes == 3){
                        p.sendMessage(ChatColor.GOLD+"Explosion mode");
                    }else if(wandmodes == 0){
                        p.sendMessage(ChatColor.GOLD+"Fireball mode");
                    }
 
                    wandmodes++;
 
                }else if (wandmodes == 4){
                    wandmodes--;
                    wandmodes--;
                    wandmodes--;
                    wandmodes--;
                }
            }
            if((e.getAction() == Action.LEFT_CLICK_AIR) || (e.getAction() == Action.LEFT_CLICK_BLOCK)){
                if(wandmodes == 1){
 
 
                        p.launchProjectile(Fireball.class);
 
 
 
                }else if(wandmodes == 2){
 
 
                        Location loc = p.getTargetBlock(null, 500).getLocation();
                        p.getWorld().strikeLightning(loc);
 
                }else if(wandmodes == 3){
 
 
                        Location loc = p.getTargetBlock(null, 500).getLocation();
                        p.teleport(loc);
 
 
 
                }else if(wandmodes == 4){
 
                    Location loc = p.getTargetBlock(null, 500).getLocation();
                    p.getWorld().createExplosion(loc, 10);
 
 
                }
            }
 
        }
 
 
    }
 
 
}
 

 

Asgernohns
Make a map instead of a single int. map with <String, int> where the string is players name. at event check if player has entry, if not set to value, else set new value

 

Im sorry that it hits you now but why is it that so many people including you do define their plugin instance as static?

 

Asgernohns
Check your brackets...extra bracket after wandmode==0
And you can just do if (wandmode == 4) { wandmode=0; }

Also, don't have if(wandmode == blah) more than once
It creates a conflict

i.e.
if(wandmode == 4){
wandmode = 0;
//EXPLOSION STUFF

 

lycano i saw a tutorial where he did it.

Tarestudio can you give out a code for it so i understand it better?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Asgernohns
You really need to change this.

Code:

else if (wandmodes == 4){
    wandmodes--;
    wandmodes--;
    wandmodes--;
    wandmodes--;
}

to something more like this

Code:

else if (wandmodes == 4){
    wandmodes -= 4;
}

Edit: removed one sentence, missed the line in your code

Edit2: Or even to

Code:

else {
    wandmodes = 0;
}

 

This is because you have only one variable for wandmodes. All users share the same variable.

What you need, is one variable for every player. The solution which you can use is a HashMap. Basically you declare it like this:

Code:java

Map<Player, Integer> wandmodes = new HashMap<Player, Integer>();

Now you have an empty HashMap where you can put a player as the key and his wandmode as the value with the put(Player player, Integer wandmode) method. To get the wandmode of a player you would do

Code:java

if(!wandmodes.containsKey(e.getPlayer())){
    //If the player doesn't have a wandmode you'll need to set one.
    wandmodes.put(e.getPlayer(), 1);
}
//Now you can get the wandmode for the player
int wandmode = wandmodes.get(e.getPlayer());

Then you can use wandmode in the code.

 

Asgernohns
1. you can answer everyone in one post
2. instead of 'public int wandmodes = 1;' use 'HashMap<String, Integer> wandmodes = new HashMap<String, Integer>();'
After defining p in your eventhandler add 'int wandmode = wandmodes.containsKey(p.getName()) ? wandmodes.get(p.getName()) : 1;'
at the end of your rightclick-part add 'wandmodes.put(p.getName(), wandmode);'
And change every other 'wadmodes' to 'wandmode'

kuben0
You should NEVER store an instance of player to a longliving variable. this causes memoryleaks.

 

Asgernohns Can you give me the link to the tutorial? I want to slap his face.

Tarestudio never do HashMap<String, Integer> name = new HashMap<String, Integer>(); alsways use the base class to init it so you can convert it when needed. Map<String, Integer> varName = new HashMap<String, Integer>(); is the right way to do it.

Same for lists dont do ArrayList<String> ... = new ArrayList<String>(); use List<String> ... = new ArrayList<String>();

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

lycano
The best thing about that static variable is that it's actually never initialized.

 

raGan. i tried not to comment that as he might have gotten it from somewhere else but yes ... declaring unused variables makes me cry too.

 

Tarestudio I got one error. Should i remane 'contains' to 'containsKey' or 'containsValue'?

 

Asgernohns check out the java docs there is no contains for Maps only containsKey and containsValue

 

lycano is that i am saying and it's not just a map but a hashmap.

 

Asgernohns where do you think is containsKey coming from? The base is a Map ...

anyways when you want to get the key use containsKey, if you want to get all values use containsValue. In case of checking for the players name which is the key in the Map use containsKey.

 

Asgernohns
You were faster then I thought, I edited my code to containsKey 2min after posting it ^^

lycano
Yeah, perhaps I should switch to use Map. ^^

 

lycano sorry but never worked with maps before so i don't now much :/

thanks guys! It works now

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Asgernohns
Change thread to SOLVED.

 

Asgernohns don't get me wrong when i type stuff =) If you dont know it maybe you should look at the java docs from oracle ^^

 

lycano yes but i prefure videos