Friends can not connect to server?

Hello,

When my friends are wanting to connect to the server, they can't find my server.
I tried many things but nothing worked.
Here are some files that may are usefull:

Server.txt

Code:

#Minecraft server properties
#Wed Feb 22 21:28:54 CET 2012
allow-nether=true
level-name=world
enable-query=false
allow-flight=false
server-port=25565
level-type=DEFAULT
enable-rcon=false
level-seed=
server-ip=
spawn-npcs=true
white-list=false
spawn-animals=true
online-mode=true
pvp=false
difficulty=1
gamemode=0
max-players=40
spawn-monsters=true
view-distance=5
generate-structures=false
motd=A Deathc0mander Server

Run.bat

Code:

@ECHO OFF
SET BINDIR=%~dp0
CD /D "%BINDIR%"
"%ProgramFiles%\Java\jre7\bin\java.exe" -Xmx1024M -Xms1024M -jar craftbukkit-1.1-R4.jar
PAUSE

Please help.

 

Most common error is that you never fowarded your ports.
You can just google "How to foward my minecraft ports"
Other than that you should be fine

 

Well he didn't post the I.P either you might wanna fix that before port-fowarding

 

You shouldn't need to put the ip in server.properties unless you're using Hamachi.