Prevent guests from building on world

Hi, sorry if this is the wrong forum but it seemed like it fit best here. In my plugin I have this code which should only let non-op's build on a "guests" world I have:

Code:

    public void onPlayerInteract(PlayerInteractEvent event) {
        Player player = event.getPlayer();
        Server server = player.getServer();
        if (player.isOp() == false) {
            if (player.getLocation().getWorld().getName() != "guests") {
                event.setCancelled(true);
            } else {
                event.setCancelled(false);
            }
        }
    }

This code will prevent any non-op from breaking/placing any blocks, the problem is that even on the guests world, a guest cannot build/delete blocks. To be honest, I see no error in the coding which should prevent them from building/removing blocks on the guests world. Any help is appreciated. Thanks.

 

you could use

if (!player.isOp())
//do stuff

which means if player is not Op

 

Wouldn't if (player.isOp() == false) { be the same thing?

 

Why not use permissions aswell and default as Op?

if (!player.hasPermission("permission.something.hello"))
return;

meaning if the player doesnt have the permission don't do anything

also that is the bukkitPermissions or SuperPerms

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

get rid of the setCancel = false, theres no reason to say you're not going to cancel it.

 

It used to not have setCancel = false, but it still didn't work in that case so I added it in to see if it made a difference. It didn't.

 

You should do it like this:

Code:

    public void onPlayerInteract(PlayerInteractEvent event) {
        Player player = event.getPlayer();
        Server server = player.getServer();
        if (player.isOp()  && player.getLocation().getWorld().getName() =="guests") {
            event.setCancelled(true);

            } else {
                event.setCancelled(false);
         }
    }

I think this is correct

if player is an Op and the world name = "guests" cancel the event
else let it be

 

You don't compare strings using == that compares references.
Use .equals for exact case or .equalsIgnoreCase for non-case sensitive stuff

 

The op should be able to build in the guest world as well.

 

I thought that was what you wanted?

 

Thanks, Crash!

 

Code:

    public void onPlayerInteract(PlayerInteractEvent event) {
        Player player = event.getPlayer();
        Server server = player.getServer();
        if (player.isOp()  && player.getLocation().getWorld().getName().equalsIgnoreCase("guests")) {
            event.setCancelled(true);

            } else {
                event.setCancelled(false);
         }
    }

Corrected

 

Sorry hutch, I didn't mean to word it like that >.<

 

ok I was working on what you said, if it still wrong maybe I can change it?

 

I got it working hutch, thanks for all your help.

 

Your Welcome. It feels good knowing that I barely started Java a month ago and I can already help someone