Solved NullPointerException

Code: https://hastebin.com/owoninomif.cs

Error: https://hastebin.com/ojagegaqom.vbs

The plugin itself is working perfectly, but the console is being spammed when a player is interacting with anything in game (right, left click). Don't really know what the problem is.

Any help is appreciated.

 

https://hastebin.com/oyoqavemef.java

 

@timtower What do you mean by that? what would you replace it with.

 

Couple mistakes I noticed.

1. Don't use player#getItemInHand(); that method has been deprecated since minecraft introduced off-hands. Use player#getItemInMainHand() or player#getItemInOffHand() for each hands.​

2. To add on to timtower's suggestion, the item that the event is called from might not have an ItemMeta or a DisplayName in which case, those would be null causing your error. Before line 55, check to make sure the item has a meta with item#hasItemMeta() and if that passes, item#getItemMeta()#hasDisplayName().​

 

So instead of:
player.getItemInHand()

You would use:
player.getItemInMainHand() ? or what, because my plugin works. it does what it's supposed to. but when you have another item / no item in your hand on right or left click it spams that error in console. So i already know that getItemInHand passes the DisplayName, so i can compare it to a string to see if it should execute.

And btw getItemInMainHand() is not a thing, atleast to my knowledge / my IDE.

 

@Tencu It's Inventory#getItemInMainHand
They're also suggesting hasItemMeta and hasDisplayName since right now as you even said no item or no item with a display name will give errors. Add these checks to make sure there is actually a display name.

 

I have tried so many things now, i can't understand what the problem is.

My current code: https://hastebin.com/evijesenuk.cs
My current error when i use getItemInMainHand: https://hastebin.com/ucizizekoq.vbs
(I most likely cant use this as i'm running the plugin on a server where offHand isnt introduced.)
My current error when i use getItemInHand: https://hastebin.com/nebotodice.vbs

I have tried everything you guys have suggested, Í simply have no earthly clue why it does as it does.

@timtower @X1machinemaker1X @bwfcwalshy Any help would be so much appreciated because i have no clue why it's doing as it is.

 

Your current code will give errors when you interact with an empty hand. The material.Air itemstack doesn't have any ItemMeta, so before you check if the display name is null, you first have to check if the ItemMeta is null.

 

Why not first check if the item in hand isn't null, then check if it has an item meta and has a display name.

PHP:

    @EventHandler
    public void onPlayerInteractEvent(PlayerInteractEvent event) {
        Player p = event.getPlayer();
        ItemStack is = p.getItemInMainHand();
       
        if (is != null
            && is.hasItemMeta()
            && is.getItemMeta().hasDisplayName()
            && is.getItemMeta().getDisplayName().equals(Name)) {
           
        }
    }