Solved issue with sockets

currently I have a plugin that get's data from a database and adds said data to a sign, the issue is it crashes on the Socket with the stacktrace "socket timed out" all other code works. the socket gets the player count for that server that the sign is linked to.

Code:

    private void repeatingSignUpdater(){
       
        task = Bukkit.getScheduler().runTaskLaterAsynchronously(this, new Runnable(){

            @Override
            public void run() {
                System.out.println("time test 1");
                mysql.refreshConnection();
                //System.out.println("updating");
                for(Sign s : signs){                       
                    sign = s;
                        serverName = ChatColor.stripColor(s.getLine(0));
                       
                        //String server = mysql.getServers(serverName);   
                        port = mysql.getServerPort(serverName);
                        ip = mysql.getServerIp(serverName);
                        states =  mysql.getState(serverName);
                   
                    Bukkit.getScheduler().scheduleSyncDelayedTask(plugin, new Runnable(){

                        @Override
                        public void run() {
                            try {
                                System.out.println(ip + " "+ port);
                                Socket socket = new Socket();
                                socket.connect(new InetSocketAddress(ip , port), 1 * 1000);
                               
                                DataOutputStream out = new DataOutputStream(socket.getOutputStream());
                                DataInputStream in = new DataInputStream(socket.getInputStream());
                               
                                out.write(0xFE);
                               
                                StringBuilder str = new StringBuilder();
                               
                                int b;
                                while ((b = in.read()) != -1) {
                                    if (b != -1 && b > 16 && b != 255 && b != 23 && b != 24) {
                                        str.append((char) b);
                                    }
                                }
   
                                String[] data = str.toString().split("§");;
                                onlinePlayers = Integer.valueOf(data[1]);
                                int maxPlayers = 20; //Integer.valueOf(data[2]);
                                //int count = maxPlayers;
                                System.out.println(states);
                                if(states == null){
                                    socket.close();
                                    return;
                                }else
                                    if(serverName.equalsIgnoreCase("survival") || serverName.equalsIgnoreCase("skyblock")){
                                        sign.setLine(2, states);
                                        sign.setLine(3, onlinePlayers + "/" + 100);
                                        sign.update();
                                    }else{
                                        sign.setLine(2, states);
                                        sign.setLine(3, onlinePlayers + "/" + maxPlayers);
                                        sign.update();
                                       
                                    }

                                        //System.out.println(onlinePlayers);
                                                   
                                socket.close();
                            } catch (Exception e) {
                                sign.setLine(2, ChatColor.RED + "Error.");
                                sign.update();
                               
                            }
                           
                            sign.update();
                           
                        }});

 

Does the socket connection get established? Or does it just attempt to and fail?

The only thought that comes to mind is that you're connecting to a socket that is on the servers port and that the ServerSocket might be listening on another port.

 

@Ace_Wolf2
Add a little more time to the timeout may be.

If you wanna send data, you need to call the method flush()

 

After a bit of work and looking at the ports that the socket listened to as suggested. it seems my issue was in the for loop looping through before the socket was even called, resulting in only the last port being called by the socket which was a closed server. I removed the for loop in replaced it for repeating tasks. so far it seems my issue was solved. I also took @Caderape2 advice and added a bit more time to the timeout just to be safe. no lag or crashes Thanks