Give Player Snowball

I'm trying to give a player a snowball every second if he is in a certain area. I have other events running just fine in the same class, so that's not the problem.

Code:

Code:java

 
@EventHandler
    public void bombArea(PlayerMoveEvent e){
        Player p = e.getPlayer();
        if(p.getLocation().getWorld().getName().startsWith("Bomb")){
            for(double x = 0; x <= 10; x++){
                for(double y = 0; y <= 10; y++){
                    for(double z = 0; z <= 10; z++){
                        Location bombArea = new Location(p.getLocation().getWorld(), x, y, z);
                        if(p.getLocation().equals(bombArea)){
                            Bukkit.getScheduler().scheduleSyncDelayedTask(main, new Runnable(){
                                public void run(){
                                    ItemStack snowball = new ItemStack(Material.SNOW_BALL);
                                    p.getInventory().addItem(snowball);
                                }
                            }, 20);
                        }
                    }
                }
            }
        }
    }
 

This isn't working, am I getting the area wrong? All help is appreciated!

 

What specifically is not working

Sent from my SAMSUNG-SM-G935A using Tapatalk

 

@jobisingh

As far as I know, it's not giving me snowballs.

I'll do some debugging right now.

 

@GRocksMc Do you know how many times in one second this code can be called ? Leave this event alone and go for a scheduler every X seconds. this will be much better for the performance of the server.

Are u sure about it ? your arena is a cuboid of 10 blocks from the location 0 ?

 

@Caderape2

I'm using a scheduler:

Code:java

 
//Main Class
BukkitTask Snowball = new BomberEvents(null).runTaskTimer(this, 20, 20);
 
//extends BukkitRunnable
public void run(){
        for(Player p : Bukkit.getOnlinePlayers()){
            for(double x = 0; x <= 10; x++){
                for(double y = 0; y <= 10; y++){
                    for(double z = 0; z <= 10; z++){
                        if(p.getLocation().getWorld().getName().startsWith("Bomb")){
                            Location bombArea = new Location(p.getLocation().getWorld(), x, y, z);
                            if(p.getLocation().equals(bombArea)){
                                ItemStack snowball = new ItemStack(Material.SNOW_BALL);
                                p.getInventory().addItem(snowball);
                            }
                        }
                    }
                }
            }
        }
    }
 

It's still not giving me the snowball. The 10x10x10 is just for testing purposes.

 

So the bomb area is centered around (5,5,5) (coordinates)? Just making sure

 

@MCMastery

I will change the coordinates after those coordinates work. At the moment, to test I just run around in that 10x10x10 area to see if it will give me a snowball. It hasn't work once yet.

 

@GRocksMc
I am wondering if the equals method compare a, int value of the location or the double value.
if it's the double, that might be the problem. cuz double 10 != double 10.1

You should try something like that for check a cuboid, might be more efficient.

 

You are checking if their location exactly equals (10,10,10), (9,9,9) etc. It could be (9.5,10,10) for example.

(Very rarely would it actually be exactly 10 x 10 x 10)

Oh see @Caderape2's post

 

@Caderape2 @MCMastery @timtower @Zombie_Striker

To get the locations from the config would I do this?

Code:java

 
if(main.getConfig().get("BombSnowballLocation1") != null && main.getConfig().get("BombSnowballLocation") != null){
                String OGloc1 = main.getConfig().getString("BombSnowballLocation1");
                String[] locs1 = OGloc1.split(",");
                int X1 = Integer.parseInt(locs1[0]);
                int Y1 = Integer.parseInt(locs1[1]);
                int Z1 = Integer.parseInt(locs1[2]);
                String OGloc2 = main.getConfig().getString("BombSnowballLocation2");
                String[] locs2 = OGloc2.split(",");
                int X2 = Integer.parseInt(locs2[0]);
                int Y2 = Integer.parseInt(locs2[1]);
                int Z2 = Integer.parseInt(locs2[2]);
            if(p.getLocation().getWorld().getName().startsWith("Bomb")){
                if(X1 <= p.getLocation().getBlockX() && X2 >= p.getLocation().getBlockX()){
                    if(Y1 <= p.getLocation().getBlockY() && Y2 >= p.getLocation().getBlockY()){
                        if(Z1 <= p.getLocation().getBlockZ() && Z2 >= p.getLocation().getBlockZ()){
 
//config:
BombSnowballLocation1: 0,0,0
BombSnowballLocation2: 10,10,10
 

EDIT: Sorry, that was stupid of me, I accidentally only put in BombSnowballLocation for the first if statement.

 

@GRocksMc

You condition is wrong. You have to check if the player is between the minimum point and the maximum point, so if the player blockx is between 0 and 10.