Sign Shop (Buy and Sell)

At the moment, I'm making a plugin that if you click (right or left(just left right now)) it will buy/sell an item.
Sign would say:
[Sky]
cost of buying
item:data
how much you get for selling

I can't, for the life of me, figure out how to get the data off of the sign and apply it to an ItemStack

Code:java

 
if(event.getAction() == Action.LEFT_CLICK_BLOCK){
            if((block.getType() == Material.SIGN_POST) || (block.getType() == Material.WALL_SIGN)){
                Sign sign = (Sign) block.getState();
                if(sign.getLine(0).equals("§7[§3Sky§7]")){
                    String line3 = sign.getLine(3).replaceAll("§\\d", "");
                    String line2 = sign.getLine(2).replaceAll("§\\d", "");
                    int points = main.getConfig().getInt("SkyBlockScore." + p);    
                    if(isInt(line3)){
                        if(isInt(line2)){
                            int itemID = Integer.parseInt(line2);
                            int income = Integer.parseInt(line3);
                            String[] split2 = line2.split("\\:");
                            Material itemString = Material.getMaterial(itemID);
                            int data = Integer.parseInt(split2[1]);
                            ItemStack item = new ItemStack(itemString, 1, (short) data);
                            if(player.getInventory().contains(item)){
                                player.getInventory().removeItem(item);
                                int newpoints = points + income;
                                main.getConfig().set("SkyBlockScore." + p, newpoints);
                                main.saveConfig();
                                player.sendMessage(ChatColor.GRAY + "You just sold " + ChatColor.DARK_AQUA + item.toString().replaceAll("ItemStack\\{(\\w+)\\s+x\\s+\\d+\\}", "$1").toLowerCase());
                                player.sendMessage(ChatColor.GRAY + "You now have " + ChatColor.DARK_AQUA + newpoints + ChatColor.GRAY + " points");
                            }
                            else{
                                player.sendMessage(ChatColor.GRAY + "You don't have " + ChatColor.DARK_AQUA + line2);
                            }
                        }
                        else{
                            int income = Integer.parseInt(line3);
                            String[] split2 = line2.split("\\:");
                            Material itemString = Material.getMaterial(split2[0].toUpperCase());
                            int data = Integer.parseInt(split2[1]);
                            ItemStack item = new ItemStack(itemString, 1, (short) data);
                            //player.getInventory().addItem(new ItemStack(Material.getMaterial("stone".toUpperCase()), 1, (short) 0));
                            if(player.getInventory().contains(item)){
                                player.getInventory().removeItem(item);
                                int newpoints = points + income;
                                main.getConfig().set("SkyBlockScore." + p, newpoints);
                                main.saveConfig();
                                player.sendMessage(ChatColor.GRAY + "You just sold " + ChatColor.DARK_AQUA + split2[0]);
                                player.sendMessage(ChatColor.GRAY + "You now have " + ChatColor.DARK_AQUA + newpoints + ChatColor.GRAY + " points");
                            }
                            else{
                                player.sendMessage(ChatColor.GRAY + "You don't have " + ChatColor.DARK_AQUA + split2[0]);
                            }
                        }
                    }
                }
            }
        }
 

It probably look like a lot... just move you eyes towards the ItemStack part.

My problem is that when I sell (left click), it it takes a block if I have two different stacks of that block.

Thanks for your help!

 

ItemID includes both the material and the durability. What you want to do is split linte to at the ':'. The first bit will be the item id, and the second bit will be the id. You already did the data, now what you need to do is make sure itemID only parses the first bit.

 

@Zombie_Striker

Code:

Code:java

 
if(event.getAction() == Action.LEFT_CLICK_BLOCK){
            if((block.getType() == Material.SIGN_POST) || (block.getType() == Material.WALL_SIGN)){
                Sign sign = (Sign) block.getState();
                if(sign.getLine(0).equals("§7[§3Sky§7]")){
                    String line3 = sign.getLine(3).replaceAll("§\\d", "");
                    String line2 = sign.getLine(2).replaceAll("§\\d", "");
                    int points = main.getConfig().getInt("SkyBlockScore." + p);
                    String[] split2 = line2.split(":");
                    int income = Integer.parseInt(line3);
                    if(isInt(line3)){
                        if(isInt(split2[0])){
                            int itemID = Integer.parseInt(split2[0]);
                            int data = Integer.parseInt(split2[1]);
                            Material itemString = Material.getMaterial(itemID);
                            ItemStack item = new ItemStack(itemString, 1, (short) data);
                            if(player.getInventory().contains(item)){
                                player.getInventory().removeItem(item);
                                int newpoints = points + income;
                                main.getConfig().set("SkyBlockScore." + p, newpoints);
                                main.saveConfig();
                                player.sendMessage(ChatColor.GRAY + "You just sold " + ChatColor.DARK_AQUA + item.toString().replaceAll("ItemStack\\{(\\w+)\\s+x\\s+\\d+\\}", "$1").toLowerCase());
                                player.sendMessage(ChatColor.GRAY + "You now have " + ChatColor.DARK_AQUA + newpoints + ChatColor.GRAY + " points");
                            }
                            else{
                                player.sendMessage(ChatColor.GRAY + "You don't have minecraft:" + ChatColor.DARK_AQUA + split2[0]);
                            }
                        }
                        else{
                            Material itemString = Material.getMaterial(split2[0].toUpperCase());
                            int data = Integer.parseInt(split2[1]);
                            ItemStack item = new ItemStack(itemString, 1, (short) data);
                            //player.getInventory().addItem(new ItemStack(Material.getMaterial("stone".toUpperCase()), 1, (short) 0));
                            if(player.getInventory().contains(item)){
                                player.getInventory().removeItem(item);
                                int newpoints = points + income;
                                main.getConfig().set("SkyBlockScore." + p, newpoints);
                                main.saveConfig();
                                player.sendMessage(ChatColor.GRAY + "You just sold " + ChatColor.DARK_AQUA + split2[0]);
                                player.sendMessage(ChatColor.GRAY + "You now have " + ChatColor.DARK_AQUA + newpoints + ChatColor.GRAY + " points");
                            }
                            else{
                                player.sendMessage(ChatColor.GRAY + "You don't have " + ChatColor.DARK_AQUA + split2[0]);
                            }
                        }
                    }
                }
            }
        }
 

It tells me that I don't have that block. It's not seeing that block in my inventory.

It works for "grass:0" but not "stone:0"

EDIT: the problem above is because I had a single block of grass while I had an entire stack of stone. This is because I have the ItemStack amount set to 1. How do I have it remove 1 from a stack?

I think I can look for that item in the player's inventory with a for loop. If it's there, then get the amount. Subtract 1 from that amount. So... I know what to do, I just don't know how to do it.

 

@timtower

I don't know how to get the ItemStack and it's amount in order to lower it by 1.

 

This is what I've gotten so far...

Code:java

 
String line3 = sign.getLine(3).replaceAll("§\\d", "");
                    String line2 = sign.getLine(2).replaceAll("§\\d", "");
                    int points = main.getConfig().getInt("SkyBlockScore." + p);
                    String[] split2 = line2.split(":");
                    int data = Integer.parseInt(split2[1]);
                    int income = Integer.parseInt(line3);
                    if(isInt(line3)){
                        if(isInt(split2[0])){
                            int itemID = Integer.parseInt(split2[0]);
                            Material itemString = Material.getMaterial(itemID);
                            ItemStack item = new ItemStack(itemString, 1, (short) data);
                            int invamount = 0;
                            if(player.getInventory().contains(item)){
                                int invlength = player.getInventory().getContents().length;
                                for(int i = 0; i < invlength; i++){
                                    if(player.getInventory().getItem(i).equals(itemString)){
                                        invamount = player.getInventory().getItem(i).getAmount();
                                        break;
                                    }
                                    i++;
                                }
                                int newamount = invamount - 1;
                                player.getInventory().removeItem(item);
                                int newpoints = points + income;
                                main.getConfig().set("SkyBlockScore." + p, newpoints);
                                main.saveConfig();
                                player.sendMessage(ChatColor.GRAY + "You just sold " + ChatColor.DARK_AQUA + item.toString().replaceAll("ItemStack\\{(\\w+)\\s+x\\s+\\d+\\}", "$1").toLowerCase());
                                player.sendMessage(ChatColor.GRAY + "You now have " + ChatColor.DARK_AQUA + newpoints + ChatColor.GRAY + " points");
                            }
 

I don't know what to do with this, I'm not so good with loops.

 

@GRocksMc


You just have to loops player.getInventoty().GetContents().
Check for each itemstack if the material and the data is good, then set the amount with itemstack.setAmount(itemstack.getamount()-1)

 

Caderape2 timtower

I'm sorry to say this, but I don't know how to loop player.getInventory().getContents().

 

getContents() return a list of itemstack.
You can do a for loops for get each itemstack.
@GRocksMc

 

@Caderape2

Would this do it?

Code:java

 
int itemID = Integer.parseInt(split2[0]);
                            Material itemString = Material.getMaterial(itemID);
                            ItemStack item = new ItemStack(itemString, 1, (short) data);
                            int invamount = 0;
                            int itemNumber = 0;
                            if(player.getInventory().contains(item)){
                                int invlength = player.getInventory().getContents().length;
                                for(int i = 0; i < invlength; i++){
                                    if(player.getInventory().getItem(i).equals(itemString)){
                                        invamount = player.getInventory().getItem(i).getAmount();
                                        itemNumber = i;
                                        break;
                                    }
                                    i++;
                                }
                                int newamount = invamount - 1;
                                player.getInventory().getItem(itemNumber).setAmount(newamount);;
                                int newpoints = points + income;
                                main.getConfig().set("SkyBlockScore." + p, newpoints);
                                main.saveConfig();
                                player.sendMessage(ChatColor.GRAY + "You just sold " + ChatColor.DARK_AQUA + item.toString().replaceAll("ItemStack\\{(\\w+)\\s+x\\s+\\d+\\}", "$1").toLowerCase());
                                player.sendMessage(ChatColor.GRAY + "You now have " + ChatColor.DARK_AQUA + newpoints + ChatColor.GRAY + " points");
                            }
                            else{
                                player.sendMessage(ChatColor.GRAY + "You don't have minecraft:" + ChatColor.DARK_AQUA + split2[0]);
                            }
 

 

@GRocksMc
the loops is correct, even if you could do a 'for (ItemStack item : inventory.getcontents())'
Don't use equal, that will check the material, the data, the amount, and the itemMeta.
just check if the material and the durability are the same.

You may check the amount of the itemstack. I'm don't think it will remove the item if u set the amount to 0

 

@Caderape2

I want it to check the data of the item in case it's andesite or something like it.

Can you give me an example please.

 

@GRocksMc

I'm not sure if this could help you but take a look. I did this whilst creating a gui shop, I would set the price of 16 Wool to 4 Iron and get the players Iron amount in his inventory and if the player at least had 4 Iron then I would remove 4 Iron and it worked perfectly. You could loop it easily if you want like a sell all type of thing. Of course you would have to change it to fit your needs.

Code:

        ItemStack playerIron = new ItemStack(Material.IRON_INGOT);
        ItemStack priceIron = new ItemStack(Material.IRON_INGOT, 4);
        ItemStack wool = new ItemStack(Material.WOOL, 16);

        if (clicked == null || clicked.hasItemMeta() == false || clicked.getItemMeta().hasDisplayName() == false) {
            return;
        } else {
            if (inventory.getName().equals(ItemStacks.blocksshopInventory.getName())) {
                if (clicked.getType() == Material.WOOL && clicked.getAmount() == 16) {
                    if (player.getInventory().containsAtLeast(playerIron, 4)) {
                        player.getInventory().removeItem(priceIron);
                        player.getInventory().addItem(wool);
                        String name = clicked.getItemMeta().getDisplayName().toString();
                        player.sendMessage(purchase + ChatColor.GOLD + ChatColor.stripColor(name));
                    }
                }
            }
        

 

@SeniorCluckers

Thank you so much! I believe that this will solve my problems. I will test this ASAP when I get back to my computer. (I did not know there was a containsAtLeast()!!!)

Final Code (YAY!):

Code:java

 
package com.GRocks.ApplicationPlugin;
 
import org.bukkit.Bukkit;
import org.bukkit.Material;
import org.bukkit.block.Block;
import org.bukkit.block.Sign;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.Action;
import org.bukkit.event.player.PlayerInteractEvent;
import org.bukkit.inventory.ItemStack;
import org.bukkit.plugin.Plugin;
 
import net.md_5.bungee.api.ChatColor;
 
public class skyShop implements Listener{
 
    Plugin main = Bukkit.getPluginManager().getPlugin("GamerVerse");
    Main plugin;
    public skyShop(Main instance) {
    plugin = instance;
    }
 
    public static boolean isInt(String s) {
        try {
            Integer.parseInt(s);
        } 
        catch (NumberFormatException nfe) {
            return false;
        }
        return true;
    }
 
    @SuppressWarnings("deprecation")
    @EventHandler
    public void onPlayerInteractShopSign(PlayerInteractEvent event){
        if(event.getPlayer().getWorld().getName().equalsIgnoreCase("skyblock") || event.getPlayer().getWorld().getName().equalsIgnoreCase("Misc")){
            Player player = event.getPlayer();
            String p = player.getName();
            Block block = event.getClickedBlock();
            if(event.getAction() == Action.LEFT_CLICK_BLOCK){
              if((block.getType() == Material.SIGN_POST) || (block.getType() == Material.WALL_SIGN)){
                  Sign sign = (Sign) block.getState();
                  if(sign.getLine(0).equals("§7[§3Sky§7]")){
                      String line3 = sign.getLine(3).replaceAll("§\\d", "");
                      String line2 = sign.getLine(2).replaceAll("§\\d", "");
                      int points = main.getConfig().getInt("SkyBlockScore." + p);
                        String[] split2 = line2.split(":");
                        int data = Integer.parseInt(split2[1]);
                        int income = Integer.parseInt(line3);
                            if(isInt(split2[0])){
                                int itemID = Integer.parseInt(split2[0]);
                                Material itemString = Material.getMaterial(itemID);
                                ItemStack item = new ItemStack(itemString, 1);
                                item.setDurability((short) data);
                                if(player.getInventory().containsAtLeast(item, 1)){
                                    player.getInventory().removeItem(item);
                                    int newpoints = points + income;
                                    main.getConfig().set("SkyBlockScore." + p, newpoints);
                                    main.saveConfig();
                                    player.sendMessage(ChatColor.GRAY + "You just sold " + ChatColor.DARK_AQUA + item.toString().replaceAll("ItemStack\\{(\\w+)\\s+x\\s+\\d+\\}", "$1").toLowerCase());
                                    player.sendMessage(ChatColor.GRAY + "You now have " + ChatColor.DARK_AQUA + newpoints + ChatColor.GRAY + " points");
                                }
                                else{
                                    player.sendMessage(ChatColor.GRAY + "You don't have minecraft:" + ChatColor.DARK_AQUA + split2[0]);
                                }
                            }
                            else{
                                Material itemString = Material.getMaterial(split2[0].toUpperCase());
                                ItemStack item = new ItemStack(itemString, 1);
                                item.setDurability((short) data);
                                    if(player.getInventory().containsAtLeast(item, 1)){
                                        player.getInventory().removeItem(item);
                                    int newpoints = points + income;
                                    main.getConfig().set("SkyBlockScore." + p, newpoints);
                                    main.saveConfig();
                                    player.sendMessage(ChatColor.GRAY + "You just sold " + ChatColor.DARK_AQUA + split2[0]);
                                    player.sendMessage(ChatColor.GRAY + "You now have " + ChatColor.DARK_AQUA + newpoints + ChatColor.GRAY + " points");
                                }
                                else{
                                    player.sendMessage(ChatColor.GRAY + "You don't have " + ChatColor.DARK_AQUA + split2[0]);
                                }
                        }
              }
          }
          }
          else if(event.getAction() == Action.RIGHT_CLICK_BLOCK){
              if((block.getType() == Material.SIGN_POST) || (block.getType() == Material.WALL_SIGN)){
                  Sign sign = (Sign) block.getState();
                  if(sign.getLine(0).equals("§7[§3Sky§7]")){
                      String line2 = sign.getLine(2).replaceAll("§\\d", "");
                      String line1 = sign.getLine(1).replaceAll("§\\d", "");
                      int points = main.getConfig().getInt("SkyBlockScore." + p);
                        String[] split2 = line2.split(":");
                        int data = Integer.parseInt(split2[1]);
                        int price = Integer.parseInt(line1);
                            if(isInt(split2[0])){
                                int itemID = Integer.parseInt(split2[0]);
                                Material itemString = Material.getMaterial(itemID);
                                ItemStack item = new ItemStack(itemString, 1);
                                item.setDurability((short) data);
                                if(points >= price){
                                    player.getInventory().addItem(item);
                                    int newpoints = points - price;
                                    main.getConfig().set("SkyBlockScore." + p, newpoints);
                                    main.saveConfig();
                                    player.sendMessage(ChatColor.GRAY + "You just bought " + ChatColor.DARK_AQUA + item.toString().replaceAll("ItemStack\\{(\\w+)\\s+x\\s+\\d+\\}", "$1").toLowerCase());
                                    player.sendMessage(ChatColor.GRAY + "You now have " + ChatColor.DARK_AQUA + newpoints + ChatColor.GRAY + " points");
                                }
                                else{
                                    player.sendMessage(ChatColor.GRAY + "You need " + ChatColor.DARK_AQUA + price + ChatColor.GRAY + " points to buy that! You only have " + ChatColor.DARK_AQUA + points);
                                }
                            }
                            else{
                                Material itemString = Material.getMaterial(split2[0].toUpperCase());
                                ItemStack item = new ItemStack(itemString, 1);
                                item.setDurability((short) data);
                                if(points >= price){
                                    player.getInventory().addItem(item);
                                    int newpoints = points - price;
                                    main.getConfig().set("SkyBlockScore." + p, newpoints);
                                    main.saveConfig();
                                    player.sendMessage(ChatColor.GRAY + "You just bought " + ChatColor.DARK_AQUA + itemString);
                                    player.sendMessage(ChatColor.GRAY + "You now have " + ChatColor.DARK_AQUA + newpoints + ChatColor.GRAY + " points");
                                }
                                else{
                                    player.sendMessage(ChatColor.GRAY + "You need " + ChatColor.DARK_AQUA + price + ChatColor.GRAY + " points to buy that! You only have " + ChatColor.DARK_AQUA + points);
                                }
                            }
                  }
              }
          }
        }
    }
}