Solved Avoid take items

i have a block called collector thatt when is placed collect the items and put into a chest in a 10 block range, but if there are another collector in the range of another collector, when item is droped is duplicated in the chest because, the 2 collector take the item, my question is how i can avoid this?

PHP:

Bukkit.getScheduler().scheduleSyncRepeatingTask(Main.instance, new Runnable() {
                public void run() {
                   
                   
                    if(main.getCollectorConfig().contains("CollectorWorld." + "collectors")) {
                        for(String key : main.getCollectorConfig().getConfigurationSection("CollectorWorld." + "collectors").getKeys(false)) {
                            if(main.getCollectorConfig().get("CollectorWorld." + "collectors." + key) != null) {
                               
                               
                               
                               
                                World world = Bukkit.getWorld(main.getCollectorConfig().getString("CollectorWorld." + "collectors." + key + ".location.world"));
                                int x = main.getCollectorConfig().getInt("CollectorWorld." + "collectors." + key + ".location.x");
                                int y = main.getCollectorConfig().getInt("CollectorWorld." + "collectors." + key + ".location.y");
                                int z = main.getCollectorConfig().getInt("CollectorWorld." + "collectors." + key + ".location.z");
                               
                               
                               
                               
                               
                               
                               
                               
                               
                                Location loc = new Location(world, x, y, z);
                               
                               
                               
                                Block bl = world.getBlockAt(loc);
                               
                                if(bl != null) {
                                    if(bl.getType() == Material.DIAMOND_BLOCK) {
                                     Collection<Entity> ents = world.getNearbyEntities(bl.getLocation(), 10, 10, 10);
                                    
                                   
                                    
                                     for(Entity ent : ents) {
                                         if(ent instanceof Item) {
                                             ItemStack item = ((Item) ent).getItemStack();
                                            
                                             if(main.getCollectorConfig().contains("CollectorWorld." + "collectors." + key + ".atribbs.linked-chest.world")) //here i chek if there are a chest location by checking if exist a key called world {
                                                
                                                
                                                World world2 = Bukkit.getWorld(main.getCollectorConfig().getString("CollectorWorld." + "collectors." + key + ".atribbs.linked-chest.world"));
                                                 int x2 = main.getCollectorConfig().getInt("CollectorWorld." + "collectors." + key + ".atribbs.linked-chest.x");
                                                 int y2 = main.getCollectorConfig().getInt("CollectorWorld." + "collectors." + key + ".atribbs.linked-chest.y");
                                                 int z2 = main.getCollectorConfig().getInt("CollectorWorld." + "collectors." + key + ".atribbs.linked-chest.z");
                                                 Location locChest = new Location(world2, x2, y2, z2);
                                                
                                                    
                                                     if(locChest.getBlock().getType() == Material.CHEST) {
                                                     Chest ch = (Chest) locChest.getBlock().getState();
                                                     ch.getInventory().addItem(item);
                                                     ent.remove();
                                                    
                                                 } else {
                                                     return;
                                                 }
                                             }
                                            
                                            
                                         }
                                        
                                       
                                        
                                     }
                                    }
                                }
                               
                            }
                        }
                    } else return;
                   
                  
                }
            }, 0L, 20L);
            

 

@xelatercero

You could store the location of the collector chests, listen on the BlockPlaceEvent, and if a player places a collector block within a 10 block radius of a chest, cancel the BlockPlaceEvent and send a message.

Alternatively, a more complex solution could be mapping players with chests in a HashMap and only allowing players to store their "collected" items in their respective chests, given that they are within a 10 block radius. This would be a simple if statement in your code:

Code:

if (map.get(<reference to player object>).getBlockX() == locChest.getBlockX() && ...)

If you don't want to use HashMaps, you can also use Metadata to achieve the same result with the chests

 

@xelatercero
If you remove the item, the entity instance should be considered invalid. Make sure the item is not invalid before storing the item.

 

@Zombie_Striker i dont really understand you

 

After the instanceof Item, make another check to see if the Item is valid. It has a method for this.

 

@Lordloss and what is the clue to check if is valid, what returns? , no better question what is cheking? works great.

 

The clue is, it wont add the item if it is allready removed by your plugin. That was your problem, i dont really get your question.

 

@xelatercero
Are you asking for the method to use? The method Item#isValid() returns whether the item has been removed that tick. simply make sure the item is valid before adding the item to the inventory.