Solved How to get rid of InventoryCreative error

Hi so I have the following code:

Code:java

 @EventHandler
    public void onInventorymove(InventoryClickEvent e) {
        if (e.getCurrentItem().getItemMeta().getDisplayName().equals(ChatColor.GOLD + "Quest Pickaxe")) {
            e.setCancelled(true);
        }
 
    }

If I click or put a block in my inventory I get a NPE.

I tried doing something like this:

Code:java

if (e.getCurrentItem() == null) {
reutrn;
}

but it still gives me and error.
Any suggestions?

 

michael566
Try this:

Code:java

public void onClick(InventoryClickEvent e) {
ItemStack clicked = e.getCurrentItem();
String cName = clicked.getItemMeta().getDisplayName();
if(clicked.getType() == Material.IRON_PICKAXE && cName.equals(ChatColor.RED + "Quest Pickaxe") {
e.setCancelled(true);
}
}

Also, have you tried putting in some debug messages?

EDIT:

Could you show us the NPE?

 

Code:java

if(theItem == null || theItem.getType() == Material.AIR) return;
if(!(theItem.hasItemMeta() || theItem.getItemMeta().hasDisplayName())) return;

If you're using multiple plugins / events, don't return, use

Code:java

if(item != null && item.getType() == Material.YOURITEM){
  if(item.hasItemMeta() && item.getItemMeta().hasDisplayName()){
      //stuff
  }
}

 

WesJD Thanks it worked.

 

WesJD

You're making a variable w/o checking if the item actual has a DisplayName lol.
And you're guessing the player doesn't click outside of the inventory, look through your variables, because they don't solve anything. He's getting an NPE because he doesn't checks if the item has a displayname.

fireblast709

Typo

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Unica the first example needs to be &&, not || .

Code:java

if(!stack.hasItemMeta() || !stack.getItemMeta().hasDisplayName())

becomes

Code:java

if(!(stack.hasItemMeta() && stack.getItemMeta().hasDisplayName()))

Your method will try to check hasDisplayName() with no ItemMeta, since if(false || x) could still be true if x is true, hence Java will still check x.

(for a more in-depth explanation, you are applying De Morgan's laws here)

 

Unica
He wanted to check when a player clicked on an item with a certain name, that's what I gave him. Other things you stated might be needed in the future of what he does, but he doesn't state them to be needed here?

 

WesJD your version will throw a neat NullPointerException if the player clicks on an empty slot, or an ItemStack without name.

 

fireblast709
Oh, I'll fix it in a bit, currently I'm on mobile.

michael566
If you're able to, use Unica 's examples to create a fix.

Fix(Using Unica 's code):

Code:java

@EventHandler
public void onClick(InventoryClickEvene e) {
ItemStack clicked = e.getCurrentItem();
if(clicked != null && clicked.getType() == Material.IRON_PICKAXE) {
if(clicked.hasItemMeta() && clicked.getItemMeta().hasDisplayName() {
if(ChatColor.stripColor(clicked.getItemMeta().getDisplayName()).equals("Quest Pickaxe")) {
e.setCancelled(true);
}
}
}
}