Stop item break on cactus

BillyBobJoe168 "if entity isn't an instance of Player, and entity isn't an instance of Item, end the method" or in other words "if entity isn't a player or an item, end the method"

 

None of this helps me thou.

 

AdamQpzm I don't understand why you quoted me when fixing BillyBobJoe168...
He is wrong, but so are you. It is an 'and' statement -
If the entity is not a player and the entity is not an item don't continue the code
and not
If the entity is a player or the entity is an item, do continue the code.
These two are the same but the code contains the first one.

 

NonameSL I don't doubt the fact that the if statement contains an and, I was simply making the point that it's not a "if the entity is a player and an item". And I quoted you to point out could have been checking for fall damage for a player, not fall damage for an item.

 

This is great that people are starting to understand what I already changed, but you two are arguing about the same side of the answer and it still doesnt help me find a solution.

 

keeper317 Have you tried writing code to my pseudo code? Also, debug everything. Print out the cause, the material, everything you need to check for to make sure you are making the correct check.

 

My exact code is as follows:

Code:java

import org.bukkit.Bukkit;
import org.bukkit.entity.Item;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.EntityDamageEvent;
import org.bukkit.event.entity.EntityDamageEvent.DamageCause;
 
public class FallDamage implements Listener
{
@EventHandler
public void onFallDamage(EntityDamageEvent e)
{
if((e.getEntity() instanceof Player) && e.getCause() == DamageCause.FALL)
e.setCancelled(true);
else if(e.getEntity() instanceof Item && (e.getCause() == DamageCause.FIRE || e.getCause() == DamageCause.FIRE_TICK || e.getCause() == DamageCause.CONTACT))
e.setCancelled(true);
else
return;
Bukkit.broadcastMessage("Entity is: " + e.getEntityType().toString());
}
}

This is not working and says nothing about an entity taking damage when i drop an item on a cactus or into fire

 

keeper317 That return; is blocking the broadcastMessage() method. And there is no need to put return; at the end of a method since the method ends naturally when all the code inside is executed.
Did you register your event? Put in debug messages printing out everything you need to know. e.getCause(), getEntity, etc.

 

Without the return it still doesnt work and does not recognize the item as an entity taking damage

 

keeper317

 

I have a check for the damage cause and the entity damaged. Neither thing prints because it is not calling that method. When a player takes damage on cactus it says player is the entity and was damaged by contact

 

keeper317 Code please.

 

Code:java

@EventHandler
    public void onFallDamage(EntityDamageEvent e)
    {
        if((e.getEntity() instanceof Player) && e.getCause() == DamageCause.FALL)
            e.setCancelled(true);
        else if(e.getEntity() instanceof Item && (e.getCause() == DamageCause.FIRE || e.getCause() == DamageCause.FIRE_TICK || e.getCause() == DamageCause.CONTACT))
            e.setCancelled(true);
        Bukkit.broadcastMessage("Entity is: " + e.getEntityType().toString() + "\nEntity Damage: " + e.getCause().toString());
    }

 

keeper317 So this

Code:java

 Bukkit.broadcastMessage("Entity is: " + e.getEntityType().toString() + "\nEntity Damage: " + e.getCause().toString());

isn't printing?

 

yea

 

keeper317 What are you trying to do to fire the event? Are you sure you registered the event?

 

Yes i register the event. Fall Damage works just fine. The only problem is item. I test it by dropping an item on a cactus.

 

keeper317 That broadcast message should go off since you don't have it inside any if statement.

 

The only reason it wouldnt be firing is the method isnt being called.

 

keeper317 How about trying to use .equals() with the damagecauses? Try that.
BTW, try to print in the begginging of the method something to the console or broadcast a message just to be 100% sure that the event does indeed fire.

 

I will try it but fall damage works with == so the rest should too and the broadcast that exist already will fire no matter where in that method it is so long as the method fires. nothing will break out.

 

It made no difference and the event doesnt even fire.

 

keeper317 .equals() and == on enums has the same effect. == is just more efficient with enums. Try using this http://jd.bukkit.org/rb/apidocs/org/bukkit/event/entity/EntityEvent.html for debug purposes. Debug something in the event, then we at least know it is one of the subclasses of the event that fires the despawn of the item on a cactus.

 

@teej107 So i still don't have this set up properly. Any chance you know how to do it now?

 

@keeper317 Well I don't have it set up either. Is there a chance that you know how?

 

So i think i found a work around but i need to get the item damage value when an item spawns. I already have my item spawn event set up properly and it is set up to only see wool.
Any idea how to get these values
edit: so i got the data correctly but i need to spawn the associated item at a specific location

 

@keeper317 I found this: http://jd.bukkit.org/rb/apidocs/org/bukkit/event/entity/EntityDamageByBlockEvent.html

 

I already tried damage by block and it didnt fire