Solved TinyProtocol -> don't work

Hi, I have problem with TinyProtocol
https://github.com/aadnk/ProtocolLi.../com/comphenix/tinyprotocol/TinyProtocol.java

So... after some tests, I see that

Code:

private static final MethodInvoker getNetworkMarkers = Reflection.getTypedMethod(serverConnectionClass, null, List.class, serverConnectionClass);

is giving error (when it's used at 177 line) , because there is no method like that in most of build of CraftBukkit, I found it only in some Spigot builds.

Code:

 static List a(ServerConnection serverconnection)
  {
    return serverconnection.f;
  }

So, how to fix that?

Comphenix

bump

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Smerfa the method exists, even in CB. However, it seems he is trying to invoke it with a MinecraftServer instance instead of a ServerConnection instance.

 

o.o I check CraftBukkit R1, R2, R3, R4 and I don't see that method...
R1 from jd-Gui

Show Spoiler Hide Spoiler

Code:java

package net.minecraft.server.v1_7_R1;
 
import java.net.InetAddress;
import java.util.ArrayList;
import java.util.Collections;
import java.util.Iterator;
import java.util.List;
import net.minecraft.util.com.google.common.util.concurrent.ThreadFactoryBuilder;
import net.minecraft.util.io.netty.bootstrap.ServerBootstrap;
import net.minecraft.util.io.netty.channel.Channel;
import net.minecraft.util.io.netty.channel.ChannelFuture;
import net.minecraft.util.io.netty.channel.nio.NioEventLoopGroup;
import net.minecraft.util.io.netty.channel.socket.nio.NioServerSocketChannel;
import net.minecraft.util.io.netty.util.concurrent.GenericFutureListener;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
 
public class ServerConnection
{
  private static final Logger b = ;
  private static final NioEventLoopGroup c = new NioEventLoopGroup(0, new ThreadFactoryBuilder().setNameFormat("Netty IO #%d").setDaemon(true).build());
  private final MinecraftServer d;
  public volatile boolean a;
  private final List e = Collections.synchronizedList(new ArrayList());
  private final List f = Collections.synchronizedList(new ArrayList());
 
  public ServerConnection(MinecraftServer paramMinecraftServer)
  {
    this.d = paramMinecraftServer;
    this.a = true;
  }
 
  public void a(InetAddress paramInetAddress, int paramInt)
  {
    synchronized (this.e)
    {
      this.e.add(((ServerBootstrap)((ServerBootstrap)new ServerBootstrap().channel(NioServerSocketChannel.class)).childHandler(new ServerConnectionChannel(this)).group(c).localAddress(paramInetAddress, paramInt)).bind().syncUninterruptibly());
    }
  }
 
  public void b()
  {
    this.a = false;
    for (ChannelFuture localChannelFuture : this.e) {
      localChannelFuture.channel().close().syncUninterruptibly();
    }
  }
 
  public void c()
  {
    synchronized (this.f)
    {
      Iterator localIterator = this.f.iterator();
      while (localIterator.hasNext())
      {
        NetworkManager localNetworkManager = (NetworkManager)localIterator.next();
        if (!localNetworkManager.d())
        {
          localIterator.remove();
          if (localNetworkManager.f() != null) {
            localNetworkManager.getPacketListener().a(localNetworkManager.f());
          } else if (localNetworkManager.getPacketListener() != null) {
            localNetworkManager.getPacketListener().a(new ChatComponentText("Disconnected"));
          }
        }
        else
        {
          try
          {
            localNetworkManager.a();
          }
          catch (Exception localException)
          {
            if (localNetworkManager.c())
            {
              localObject1 = CrashReport.a(localException, "Ticking memory connection");
              CrashReportSystemDetails localCrashReportSystemDetails = ((CrashReport)localObject1).a("Ticking connection");
 
              localCrashReportSystemDetails.a("Connection", new CrashReportServerConnection(this, localNetworkManager));
 
 
 
 
 
 
              throw new ReportedException((CrashReport)localObject1);
            }
            b.warn("Failed to handle packet for " + localNetworkManager.getSocketAddress(), localException);
            Object localObject1 = new ChatComponentText("Internal server error");
            localNetworkManager.handle(new PacketPlayOutKickDisconnect((IChatBaseComponent)localObject1), new GenericFutureListener[] { new ServerConnectionFuture(this, localNetworkManager, (ChatComponentText)localObject1) });
 
 
 
 
 
            localNetworkManager.g();
          }
        }
      }
    }
  }
 
  public MinecraftServer d()
  {
    return this.d;
  }
}
 

I try another decompiler...
from another one:

Show Spoiler Hide Spoiler

Code:java

package net.minecraft.server.v1_7_R1;
 
 
 
import net.minecraft.util.io.netty.bootstrap.AbstractBootstrap;
 
import net.minecraft.util.com.google.common.util.concurrent.ThreadFactoryBuilder;
 
import org.apache.logging.log4j.LogManager;
 
import net.minecraft.util.io.netty.util.concurrent.GenericFutureListener;
 
import java.util.concurrent.Callable;
 
import java.util.Iterator;
 
import net.minecraft.util.io.netty.channel.ChannelFuture;
 
import net.minecraft.util.io.netty.channel.EventLoopGroup;
 
import net.minecraft.util.io.netty.channel.ChannelHandler;
 
import net.minecraft.util.io.netty.channel.Channel;
 
import net.minecraft.util.io.netty.channel.socket.nio.NioServerSocketChannel;
 
import net.minecraft.util.io.netty.bootstrap.ServerBootstrap;
 
import java.net.InetAddress;
 
import java.util.Collections;
 
import java.util.ArrayList;
 
import java.util.List;
 
import net.minecraft.util.io.netty.channel.nio.NioEventLoopGroup;
 
import org.apache.logging.log4j.Logger;
 
 
 
public class ServerConnection
 
{
 
    private static final Logger b;
 
    private static final NioEventLoopGroup c;
 
    private final MinecraftServer d;
 
    public volatile boolean a;
 
    private final List e;
 
    private final List f;
 
 
 
    public ServerConnection(final MinecraftServer d) {
 
        super();
 
        this.e = Collections.synchronizedList(new ArrayList<Object>());
 
        this.f = Collections.synchronizedList(new ArrayList<Object>());
 
        this.d = d;
 
        this.a = true;
 
    }
 
 
 
    public void a(final InetAddress inetHost, final int inetPort) {
 
        synchronized (this.e) {
 
            this.e.add(((AbstractBootstrap<ServerBootstrap, C>)((AbstractBootstrap<ServerBootstrap, Channel>)new ServerBootstrap()).channel(NioServerSocketChannel.class).childHandler(new ServerConnectionChannel(this)).group(ServerConnection.c)).localAddress(inetHost, inetPort).bind().syncUninterruptibly());
 
        }
 
    }
 
 
 
    public void b() {
 
        this.a = false;
 
        final Iterator<ChannelFuture> iterator = this.e.iterator();
 
        while (iterator.hasNext()) {
 
            iterator.next().channel().close().syncUninterruptibly();
 
        }
 
    }
 
 
 
    public void c() {
 
        synchronized (this.f) {
 
            final Iterator<NetworkManager> iterator = (Iterator<NetworkManager>)this.f.iterator();
 
            while (iterator.hasNext()) {
 
                final NetworkManager networkManager = iterator.next();
 
                if (!networkManager.d()) {
 
                    iterator.remove();
 
                    if (networkManager.f() != null) {
 
                        networkManager.getPacketListener().a(networkManager.f());
 
                    }
 
                    else {
 
                        if (networkManager.getPacketListener() == null) {
 
                            continue;
 
                        }
 
                        networkManager.getPacketListener().a(new ChatComponentText("Disconnected"));
 
                    }
 
                }
 
                else {
 
                    try {
 
                        networkManager.a();
 
                    }
 
                    catch (Exception throwable) {
 
                        if (networkManager.c()) {
 
                            final CrashReport a = CrashReport.a(throwable, "Ticking memory connection");
 
                            a.a("Ticking connection").a("Connection", new CrashReportServerConnection(this, networkManager));
 
                            throw new ReportedException(a);
 
                        }
 
                        ServerConnection.b.warn("Failed to handle packet for " + networkManager.getSocketAddress(), throwable);
 
                        final ChatComponentText chatComponentText = new ChatComponentText("Internal server error");
 
                        networkManager.handle(new PacketPlayOutKickDisconnect(chatComponentText), new ServerConnectionFuture(this, networkManager, chatComponentText));
 
                        networkManager.g();
 
                    }
 
                }
 
            }
 
        }
 
    }
 
 
 
    public MinecraftServer d() {
 
        return this.d;
 
    }
 
 
 
    static {
 
        b = LogManager.getLogger();
 
        c = new NioEventLoopGroup(0, new ThreadFactoryBuilder().setNameFormat("Netty IO #%d").setDaemon(true).build());
 
    }
 
}

so... where?

 

Smerfa I checked https://github.com/Bukkit/mc-dev

 

bump
Comphenix are you alive?


EDIT: fixed by changing method of getting Networks list, and delay TinyProtocol start.