Solved Dead code? And section doesn't seem to work...

Hi. I recently been combining plugin Fortune Blocks & Safe Mining into one plugin so (a. both work with each other, and (b. To, well combine two plugins together

So, I seem to be getting a few errors with what I have. It never seems that the item going straight to inventory does not work (after implementing code for fortune blocks)

I have commented code to make it easier to find sections i'm talking about

Code:

Code:java

 {
Random random = new Random();
public void onEnable()
{
Bukkit.getPluginManager().registerEvents(this, this);
getLogger().info("Plugin enabled.");
}
 
@SuppressWarnings("deprecation")
@EventHandler(priority = EventPriority.HIGHEST)
public void onBreak(BlockBreakEvent e)
{
Player p = e.getPlayer();
Block block = e.getBlock();
Collection<ItemStack> drops = e.getBlock().getDrops();
if (block.getType() == null) {
return;
}
if ((block.getType() != Material.IRON_BLOCK) && (block.getType() != Material.EMERALD_BLOCK) && (block.getType() != Material.DIAMOND_BLOCK) && (block.getType() != Material.GOLD_BLOCK) && (block.getType() != Material.REDSTONE_BLOCK) && (block.getType() != Material.COAL_BLOCK) && (block.getType() != Material.LAPIS_BLOCK)) {
return;
}
ItemStack hand = p.getItemInHand();
if (hand == null) {
return;
}
if ((hand.getType() != Material.WOOD_PICKAXE) && (hand.getType() != Material.STONE_PICKAXE) && (hand.getType() != Material.IRON_PICKAXE) && (hand.getType() != Material.DIAMOND_PICKAXE)) {
return;
}
int enchantlvl = hand.getEnchantmentLevel(Enchantment.LOOT_BONUS_BLOCKS);
if (enchantlvl < 1) {
return;
}
 
 
ItemStack fortune = (ItemStack) new ItemStack(block.getType(), Math.max(3, this.random.nextInt(15)));
 
//Putting items into inventory.
if (p.hasPermission("safemine.use"))
{
if(fortune != null){
 
if (p.getInventory().firstEmpty() != -1)
{
p.getInventory().addItem(new ItemStack[] { fortune });
}
else
{
p.getWorld().dropItemNaturally(p.getLocation(), fortune);
p.updateInventory();
}
p.playSound(p.getLocation(), Sound.CHICKEN_EGG_POP, 1.0F, 1.0F);
p.giveExp(e.getExpToDrop());
p.updateInventory();
block.setType(Material.AIR);
e.setCancelled(true);
}
else
//Dead code(as Eclipse says)
{
if(isPick(block.getType())) {
for (ItemStack finaldrop : drops)
{
if (p.getInventory().firstEmpty() != -1)
{
p.getInventory().addItem(new ItemStack[] { finaldrop });
}
else
{
p.getWorld().dropItemNaturally(p.getLocation(), finaldrop);
p.updateInventory();
}
p.playSound(p.getLocation(), Sound.CHICKEN_EGG_POP, 1.0F, 1.0F);
p.updateInventory();
block.setType(Material.AIR);
e.setCancelled(true);
}
}
 
}
}
}
 
 
 

Neither with, or without the fortune aspect occurring does the code seem to work. And yes, it does fire

Now, again, I will say this. I am relatively new to Coding in java/using bukkit api, so it may just be a novice mistake.

Thanks in advance for reading and possibly helping!

 

You have an "if null then blah, else other blah" fortune is never null since you defined it as something before that if statement. The else is being labeled as dead code since its not possible for it to be ran as fortune is never null.

 

MCaeolus Gamecube762 To be more precise as to why eclipse declared the block dead:
Giving a value to a variable like you do doesn't automatically mean that the variable won't point to null, because it might. But since you made a new object there and assigned that to the variable, there is no way your variable will ever point to null, hence why eclipse says the code is dead (not reachable).

PS: Your cast to ItemStack is entirely redundant, as the object you are creating already is one and can never not be one.

 

I fixed it, sorry about that XD Thank you. I realized I needed to rewrite the way I implemented fortune blocks, and now it fully works! Thanks, again