Solved Generating a cube with two corners.

Right, so I am trying to make (Just out of my own enjoyment) something similar to the world edit selection, where someone can select two corners, and every block inside those corners will be turned into a different block.

So far, I have this, but it does not work. This code below seems to only change a few blocks. ('pos1' being one corner, and 'pos2' being the second)

Code:java

public void setRegion(Location pos1, Location pos2, Player player) {
 
        double minX;
        double maxX;
        double minY;
        double maxY;
        double minZ;
        double maxZ;
 
        if (pos1.getX() > pos2.getX()) {  minX = pos2.getX();  maxX = pos1.getX(); } else {  minX = pos1.getX();  maxX = pos2.getX(); }
        if (pos1.getY() > pos2.getY()) {  minY = pos2.getY();  maxY = pos1.getY(); } else {  minY= pos1.getY();  maxY = pos2.getY(); }
        if (pos1.getZ() > pos2.getZ()) {  minZ = pos2.getZ();  maxZ = pos1.getZ(); } else {  minZ = pos1.getZ();  maxZ = pos2.getZ(); }
 
        for (; minX < maxX; minX++) {
            for (; minY < maxY; minY++) {
                for (; minZ < maxZ; minZ++) {
                    Location loc = new Location(player.getWorld(), minX, minY, minZ);
                    loc.getBlock().setType(Material.DIAMOND_BLOCK);
                }
            }
        }
 
    }

I am not sure if this is the right approach to it, and if it is, I may have made a silly logic error, but if anyone could help me out, it would be much appreciated.

 

bkleinman1
Your general approach is good. But your loops are just wrong (does that even compile? )
If you look at the Location you are creating, you are using the same values every time, so it will never get them all.

You will need to create 3 new int values representing x, y and z and not change the min values.
Luckly inside the for loop you can easly create those values that will range from the min to the max value.
If you look at it it should make a lot of sence, it would look like this:

Code:java

for(int x = minX; x <= maxX; x++) {
    for(int y = minY; y <= maxY; y++) {
    for(int z = minZ; z <= maxZ; z++) {
        Location loc = new Location(world, x, y, z);
        // Do stuff
 
    }
}
}

 

Ah, I see where I went wrong. Thank you for the help.

 

bkleinman1
If this works, don't forget to mark it as solved!