Die instantly when touch lava

Glass_Eater84
Since that class extends JavaPlugin, you can just do:
Bukkit.getServer().getPluginManager().registerEvents(this, this);

 

Jaaakee224 But it also implements Listener. Also, my other classes
SignCommand:

Code:java

publicclassSignCommandimplementsListener{
 
Main m;
publicSignCommand(Maininstance)
{
m=instance;
}

Main:

Code:java

public class Main extends JavaPlugin
{
public final Logger logger = Logger.getLogger("Minecraft");
public void onEnable()
 
 
{
this.saveDefaultConfig();
this.level = getConfig().getInt("Knockback");
getConfig().options().copyDefaults(true);
Bukkit.getServer().getPluginManager().registerEvents(new SignCommand(this), this);

 

Glass_Eater84 Something like this would work, you just have the manage it only killing the player once because now it spams that the player died.

Code:java

public class Tester extends JavaPlugin implements Listener {
 
    @Override
    public void onEnable() {
        Bukkit.getServer().getPluginManager().registerEvents(this, this);
    }
 
    @EventHandler
    public void onPlayerDamageEvent(EntityDamageEvent e) {
        Player p = (Player) e.getEntity();
        if (p.getLastDamageCause().getCause() ==  DamageCause.LAVA) {
            if (e.getEntity() instanceof Player) {
                p.setHealth(0.0);
            }
        }
 
    }
}

 

Jaaakee224 Very weird still not working.

Code:java

import org.bukkit.Bukkit;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.EntityDamageEvent;
import org.bukkit.event.entity.EntityDamageEvent.DamageCause;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Lava extends JavaPlugin implements Listener{
 
@Override
public void onEnable() {
Bukkit.getServer().getPluginManager().registerEvents(this, this);
}
 
@EventHandler
public void onPlayerDamageEvent(EntityDamageEvent e) {
Player p = (Player) e.getEntity();
if (p.getLastDamageCause().getCause() == DamageCause.LAVA) {
if (e.getEntity() instanceof Player) {
p.setHealth(0.0);
}
}
 
}
}

I've tried debugging many times, with no success.
EDIT: It works in its own plugin, but I would like to implement it.

 

Glass_Eater84 You're probably implementing your listeners wrong.

 

Jaaakee224 What do you mean? Should I change the way I register my events in all classes? to like this?

Code:java

this.getServer().getPluginManager().registerEvent(listener instance, this);

Or how should I do it?

 

No. Let's get down to the basics to make sure we aren't missing anything stupid. Is your plugin even loading? Stacktrace? And in your most current posted class, you aren't safely casting.

Yes, but in his example, he wasn't even calling anything from the Damageable. He was calling it from the Player.

 

This can be completed easily, I dunno why you are using player damage event.

Code:java

  @EventHandler
  public void onPlayerMove(PlayerMoveEvent event)
  {
    final Player player = event.getPlayer();
    Material m = event.getPlayer().getLocation().getBlock().getType();
    if ((m == Material.STATIONARY_LAVA) || (m == Material.LAVA)) {
player.setHealth(0);
}
}

was that really hard?

 

Jimfutsu This would only work for the feet of the player; they could have their head in lava but feet out of lava and not be killed. Also it is a bad idea to use PlayerMoveEvent when you don't have to.

 

coasterman10
Then you can easily check the location of the head. getLocation.add(0, 1, 0);

 

teej107 Jimfutsu coasterman10 Plugin is loading fine. All commands work. The only thing that isn't working is the death with contact with lava. It works in its own plugin. However, does not work when its implemented into my current plugin, which is the issue. As Jaaakee224 said I could be implementing my listeners wrong, but don't think I am. Thanks for the help so far, and I hope we can squash this bug! (Don't even think it's a bug.)
I can post the beginning of my code so you can see how I implement listeners, and what not.
Main:

Code:java

public class Main extends JavaPlugin
{
static String permdenied = ChatColor.RED + "Sorry, you can't do this!";
 
int level;
 
 
public void onDisable()
{
System.out.println(disabled);
}
public final Logger logger = Logger.getLogger("Minecraft");
public void onEnable()
 
 
{
this.saveDefaultConfig();
this.level = getConfig().getInt("Knockback");
getConfig().options().copyDefaults(true);
Bukkit.getServer().getPluginManager().registerEvents(new SignCommand(this), this); // This is what i've changed.
}

That is only the beginning of the Main class (The most important)

SignCommand:

Code:java

public class SignCommand implements Listener {
 
Main m;
public SignCommand(Main instance)
{
m= instance;
}

I do not register my events in my SignCommand Class. Because I do not need to.
(ALSO, I AM TRYING TO DO THIS IN A SEPARATE CLASS)
- Glass

 

I would recommend putting debug messages.

 

Jimfutsu Reason why he is using EntityDamageEvent:

Glass_Eater84

Yes put in debug code.

 

teej107 Jimfutsu Already have, I got nothing from it. :/

 

Absolutely nothing? not even the first message?

 

Glass_Eater84 Post current code with debug?

 

Check to see if it is still lava too?

 

connorlinfoot
Wait a second. Forget about the PlayerMoveEvent. Keep what you have.

Post the full code again. You say it's not your main class? Why does it extend JavaPlugin??

 

By the way: you have to check for Material.LAVA and for Material.STATIONARY_LAVA

 

AoH_Ruthless

Code:java

public class Main extends JavaPlugin
{
 
static String enabled = " Has been enabled!";
static String disabled = " Has been disabled!";
int level;
 
 
public void onDisable()
{
System.out.println(disabled);
}
public final Logger logger = Logger.getLogger("Minecraft");
public void onEnable()
 
 
{
this.saveDefaultConfig();
this.level = getConfig().getInt("Knockback");
getConfig().options().copyDefaults(true);
Bukkit.getServer().getPluginManager().registerEvents(new SignCommand(this), this); // This is what i've changed.
}
 
@SuppressWarnings("deprecation")
public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args)
{
if (cmd.getName().equalsIgnoreCase("*****")) {
if (sender.hasPermission("feather.use")) {
sender.sendMessage(featherswag);
Player player = (Player)sender;
ItemStack ****** = new ItemStack(Material.******, 1);
featherswag.addUnsafeEnchantment(Enchantment.******, level);
player.getInventory().addItem(new ItemStack[] { featherswag });
player.updateInventory();
return false;
}
if (!sender.hasPermission("*****")) {
sender.sendMessage(*****);
return false;
}
}
else if (cmd.getName().equalsIgnoreCase("******")) {
if (sender.hasPermission("****")) {
sender.sendMessage(*****);
Player player = (Player)sender;
ItemStack featherswag1 = new ItemStack(Material.*****, 1);
featherswag1.addUnsafeEnchantment(Enchantment.******, 2);
featherswag1.addUnsafeEnchantment(Enchantment.*****, level);
player.getInventory().addItem(new ItemStack[] { featherswag1 });
player.updateInventory();
return false;
}
if (!sender.hasPermission("****")) {
sender.sendMessage(*****);
return false;
}
}
return false;
}

This is my main class. (yes I put stars there for a reason. Why should it implement Listener?

 

Glass_Eater84

• Do not use Logger.getLogger("Minecraft"), use the getLogger() method you get by extending JavaPlugin
• No need for printing enabled/disabled messages, Bukkit does this for you
• Just use the EntityDamageEvent like mentioned before. Properly implementing it with the methods found in the documentation is not rocket science.
• If something doesn't work, debug it. Debug it till the point where you can see every single method call and every single logical operation/assignment, and you are guaranteed to find the cause for any bug.
• Do not perform any cast before you can guarantee that the instance is indeed the subclass you cast it to.
  Code:java

  instanceof

  will provide you that check in most cases, and in the case you need to check if something is a certain Material (for example if you want a chest inventory), Material comparison is more efficient than constructing a BlockState.
  Code:java

  block.getType() == Material.CHEST

For the rest of the people: if you spoonfeed, get out.

 

Glass_Eater84
You are extending JavaPlugin in your listener class. Don't do that .... Only one class can inherit JavaPlugin. This is your main class.

 

Glass_Eater84 Learn basic Java and Bukkit is what you should do, a problem as simple as this doesn't need a 2-paged thread. I'm sorry.

Glass_Eater84 Stating that you are a beginner at java doesn't change the fact that it is not good to start coding Bukkit if you don't know basic Java.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

AoH_Ruthless fireblast709 teej107 Ok cool! So this worked. However its by every entity.

Code:java

 @EventHandler
public void onPlayerDamageEvent(EntityDamageEvent e) {
Player p = (Player) e.getEntity();
if (p.getLastDamageCause().getCause() == DamageCause.LAVA){
p.setHealth(0.0);
}
}
}

EDIT: its only when you spawn them

 

Glass_Eater84 the only thing that you miss is an instanceof Player check ;3

 

fireblast709 thanks bud! Its working! teej107 Also, it spams the chat... http://i.imgur.com/hYiHzse.jpg I think its because essentials is registering it as someone dying every time they lose a heart. Is there anyway to fix this within the code? Or is it something with essentials, that can not be fixed.

 

Glass_Eater84 Add in debug code in your event. In your event, the player doesn't lose hearts. You are just setting their health to 0.