Configs with Multiple classs

My question is how can I use getConfig(); from not a main class? Thanks

 

B3N909
Create an instance of the main plugin that is static or, pass the plugin through to the class in the constructor then do "Main.getConfig()"

 

TGRHavoc You cannot create a new instance of JavaPlugin, in fact the plugin loader will now forbid you from doing so.

B3N909 You invoke the method an a variable that points to your java plugin

 

Sagacious_Zed could you show a small example of doing just that?

 

Sagacious_Zed

Code:

public static MainClass mainClass;
 
public void onEnable(){
mainClass = this;
}

So this isn't instancing the main class?

 

TGRHavoc No, that is an assignment, of this instance to the variable mainClass, also it really should not be static.


https://github.com/Bukkit/SamplePlu...om/dinnerbone/bukkit/sample/SamplePlugin.java

 

Sagacious_Zed Sagacious_Zed

Could anyone show me a example of that?

 

Create an instance of the class that needs your config from your plugin and pass it the config in the constructor

Code:java

public class MyClassThatNeedsConfiguration {
private final Configuration _configuration;
 
public MyClassThatNeedsConfiguration(Configuration configuration) {
_configuration = configuration;
}
}
 
 
public class MyPlugin : JavaPlugin {
public MyPlugin() {
MyClassThatNeedsConfiguration myClass = new MyClassThatNeedsConfiguration(this.getConfig());
}
}

If you don't need to mutate the settings you could go one further and inject only the settings you need from the configuration into the class instead which would be a better practice.

Yes, you are leaking a reference to the instance of the Plugin outside of the plugin via a static field. Not only is this not safe but it is also violating encapsulation. This is really bad code and you should never use that approach.

You should use the dependency injection approach I listed above, and you should constrain the dependencies you inject the most you can. So in this case, if you need the Configuration of the plugin, you inject the Configuration of the plugin, rather than the plugin itself.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

aredherring thanks for the help but I am stuck a little.
Main Class:

Code:java

public class Main extends JavaPlugin implements Listener {
 
    ConfigClass myClass = ConfigClass(this.getConfig());
 
//On enable, on disable and other junk goes down here
 
 

ConfigClass (It needs getConfig()):

Code:java

public class ConfigClass {
 
    private final Configuration _configuration;
 
    public ConfigClass(Configuration configuration) {
        _configuration = configuration;
      }
//Rest of code goes here
//Blah blah blah blah etc. etc.

I am getting a error on the main class where I put the "ConfigClass myClass = ETC. ETC" Thanks

 

You need to use new to create new instances of a class. Sorry I omitted it.

 

Both of these will work
1:

Code:

public static Main main;
 
public void onEnable(){
main = this;
}
public void onDisable(){
main = null;
}
//In second class
Main.main.getConfig();

Or in your second class

Code:java

private Main main;
public ClassName(Main pl){
pl = main;
}
//In second class
main.getConfig();

 

The first one is awful, it should never be used.
The second one is exactly what I just said but you are making it so the class is coupled to the plugin which is unnecessary.