My Staff plugin just went all wrong HELP?

hi,

so i have recently been making my very first plugin, it was going great, everything was working perfectly... then i tried to add in

Code:java

if (args[2] == "?") {
sender.sendMessage(ChatColor.RED + "/Staff Add <player>");
}

so that if you typed /staff <add/remove> ? it would show you how to use the command but instead it stoped the /modlist and the /staff remove from working so i removed them, went back in to test the plugin and now "/staff add" is removing staff and "/staff remove" doesnt do anything and also "/moidlist" now give me an error null even though i have put in the code that if it equalls null send a message but clearly it doesnt like me, here is all the code for my plugin it is in one file

the only things that work are "/staff" send you a message on how to use the command and "/modlist <anything>" replys too many arguments!

if someone could be so great to just tell me what i have done wrong, everything sems fine but i dont know how to fix it

"/staff remove <player>" doesnt give me any error, it just does nothing i only get an error when i type "/modlist"

Code:java

package com.Cretincraft.staff;
 
import java.util.List;
 
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.plugin.java.JavaPlugin;
 
public class main extends JavaPlugin {
 
    @Override
    public void onEnable() {
        getLogger().info("CretinStaff has been Successfully Enabled!");
 
        this.saveDefaultConfig();
 
    }
    @Override
    public void onDisable() {
        getLogger().info("CretinStaff has been Disabled!");
    }
    public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
 
        if (cmd.getName().equalsIgnoreCase("Staff")) {
 
            if(args.length == 0) {
            sender.sendMessage(ChatColor.RED + "Too few arguments!");   
            sender.sendMessage(ChatColor.DARK_RED + "Usage: " + ChatColor.RED + "/staff <add/remove>");   
            }
 
 
                else if (args[0].equalsIgnoreCase("remove")) {
                    if (this.getConfig().getStringList("staff") == null) {
                        sender.sendMessage(ChatColor.GRAY + "[" + ChatColor.DARK_PURPLE + "CRETIN" + ChatColor.GRAY + "]" + ChatColor.RED + " There are no staff added to remove!");
                        sender.sendMessage(ChatColor.GRAY + "[" + ChatColor.DARK_PURPLE + "CRETIN" + ChatColor.GRAY + "]" + ChatColor.WHITE + " Staff names are case SeNsAtiVE!");
                    }
                    } else {
                        List<String> staff = this.getConfig().getStringList("staff");
                        staff.remove(args[1]);
                        this.getConfig().set("staff", staff);
                        this.saveConfig();
                        sender.sendMessage(ChatColor.GRAY + "[" + ChatColor.DARK_PURPLE + "CRETIN" + ChatColor.GRAY + "]" + ChatColor.RED + " You successfully removed " + ChatColor.DARK_RED + args[1] + ChatColor.RED + " from the staff list!" );
                    }
                    }
 
                else if (args[0].equalsIgnoreCase("add")) {
                    List<String> add = getConfig().getStringList("staff");
                    add.add(args[1]);
                    getConfig().set("staff", add);
                    this.saveConfig();
                    sender.sendMessage(ChatColor.GRAY + "[" + ChatColor.DARK_PURPLE + "CRETIN" + ChatColor.GRAY + "]" + ChatColor.GREEN + " You successfully added " + ChatColor.DARK_GREEN + args[1] + ChatColor.GREEN + " to the staff list!" );
                    return false;
                }
                else if(args.length > 2) {
                    sender.sendMessage(ChatColor.RED + "Too many arguments!");
                }
 
        if (cmd.getName().equalsIgnoreCase("modlist")) {
            if (args.length == 0) {
                this.reloadConfig();
                sender.sendMessage(ChatColor.GRAY + "[" + ChatColor.DARK_PURPLE + "CRETIN" + ChatColor.GRAY + "] " + ChatColor.GOLD + "Staff: " + ChatColor.GRAY + this.getConfig().getStringList("staff"));
                sender.sendMessage(ChatColor.GOLD + "You can use " + ChatColor.RED + "/mail send <player>" + ChatColor.GOLD + " to MSG an Admin at anytime!");
            }
            else {
                sender.sendMessage(ChatColor.RED + "Too many arguments!");
                sender.sendMessage(ChatColor.DARK_RED + "Usage: " + ChatColor.RED + "/Modlist");
            }
        }
        return true;
    }
}

this is my plugin.yml

Code:

name: CCMCStaff
main: com.Cretincraft.staff.main
version: 1.0
description: List staff members of the server
commands:
  staff:
      description: /Staff <add/Remove>
      usage: Usage - /<command> add/remove
      permission: CStaff.change
      permission-message: You don't have permission to change the staff list
  modlist:
      description: Shows all staff listed in the Config.yml
      usage: /<command>
      permission: CStaff.use
      permission-message: You don't have permission to list staff

this is my config.yml

Code:

Staff:

 

This is how commands and arguments are structured

/command args[0] args[1] args[2] ...

with /staff <add/remove> ?, ? is the second argument and is args[1] not args[2]

 

Don't you Ned to check of what args is is a player because if I type /staff add thisisnotaplayerbutastring
This will add it to the config but its useless

 

Error appears to be the extra } at line 37. Reindent your code and make sure all brakcets are proper.

 

mine-care If you wanted to add an offline player, you couldn't check that. Its fine how it is probably. No point in over complicating things for now.

 

TopTobster5 you can, the players folder of bukkit contains .dat files whith uuid's of players. There is a method too i am not sure about its name tho :/ but you always can check in the dir of the main world where players are held

 

A String is an object. If you check args[2] == "?", you check if args[2] and "?" is THE SAME. You have to do this.

args[2].equals("?").

 

Slikey args[1].equals("?");

 

Ninja'd 1-4 hours later >.>
Psst. bwfcwalshy is right, args[1]

 

He's talking about string comparisons. == compares memory values (or rather, their "reference value"), so unless those two string instances are the exact same instance (which you can not guarantee), then you need to compare by value. You can use:

Code:java

if ("?".equalsIgnoreCase(args[1])) {
    //second argument is '?'
}

http://stackoverflow.com/questions/513832/how-do-i-compare-strings-in-java

 

1Rogue I was just correcting him.

 

Ahh, get an avatar

LeePMC My post was meant for you.