[NMS] Disguise help!

Guys, hello! I'm making a disguise plugin! I have this class for the disguise:

Code:java

package com.fantazzyline.belka.pb;
import java.lang.reflect.Field;
import java.util.HashMap;
import java.util.Map;
import java.util.Random;
import org.bukkit.Bukkit;
import org.bukkit.Location;
import org.bukkit.entity.EntityType;
import org.bukkit.entity.Player;
import org.bukkit.craftbukkit.v1_7_R1.entity.CraftPlayer;
import net.minecraft.server.v1_7_R1.DataWatcher;
import net.minecraft.server.v1_7_R1.PacketPlayOutEntityDestroy;
import net.minecraft.server.v1_7_R1.PacketPlayOutRelEntityMoveLook;
import net.minecraft.server.v1_7_R1.PacketPlayOutSpawnEntityLiving;
 
public class DisguiseFactory {
 
public static Map<String, Integer> ids = new HashMap<String, Integer>();
 
@SuppressWarnings("deprecation")
public static void disguisePlayer(Player initiator, EntityType e) {
PacketPlayOutSpawnEntityLiving mobPacket = new PacketPlayOutSpawnEntityLiving();
Location loc = initiator.getLocation();
int id = new Random().nextInt(5000 - 1000) + 1000;
ids.put(initiator.getName(), id);
setPrivateField(PacketPlayOutSpawnEntityLiving.class, mobPacket, "a",
(int) id);
setPrivateField(PacketPlayOutSpawnEntityLiving.class, mobPacket, "b",
(byte) e.getTypeId());
setPrivateField(PacketPlayOutSpawnEntityLiving.class, mobPacket, "c",
(int) Math.floor(loc.getBlockX() * 32.0D));
setPrivateField(PacketPlayOutSpawnEntityLiving.class, mobPacket, "d",
(int) Math.floor(loc.getBlockY() * 32.0D));
setPrivateField(PacketPlayOutSpawnEntityLiving.class, mobPacket, "e",
(int) Math.floor(loc.getBlockZ() * 32.0D));
setPrivateField(PacketPlayOutSpawnEntityLiving.class, mobPacket, "f",
(byte) 0);
setPrivateField(PacketPlayOutSpawnEntityLiving.class, mobPacket, "g",
(byte) 0);
setPrivateField(PacketPlayOutSpawnEntityLiving.class, mobPacket, "h",
(byte) 0);
setPrivateField(PacketPlayOutSpawnEntityLiving.class, mobPacket, "i",
(byte) 0);
setPrivateField(PacketPlayOutSpawnEntityLiving.class, mobPacket, "j",
(byte) 0);
setPrivateField(PacketPlayOutSpawnEntityLiving.class, mobPacket, "k",
(byte) 0);
DataWatcher watcher = new DataWatcher(null);
watcher.a(0, (Byte) (byte) 0);
watcher.a(5, "Spooky");
watcher.a(6, (Float) (float) 1);
setPrivateField(PacketPlayOutSpawnEntityLiving.class, mobPacket, "l",
watcher);
for (final Player player : Bukkit.getServer().getOnlinePlayers()) {
if (player != initiator) {
((CraftPlayer) player).getHandle().playerConnection
.sendPacket(mobPacket);
((CraftPlayer) player).getHandle().playerConnection
.sendPacket(new PacketPlayOutEntityDestroy(
((CraftPlayer) initiator).getHandle().getId()));
}
}
}
public static void walk(Player pl) {
if (ids.containsKey(pl.getName())) {
PacketPlayOutRelEntityMoveLook packet = new PacketPlayOutRelEntityMoveLook(ids.get(pl.getName()),
(byte) pl.getLocation().getX(),
(byte) pl.getLocation().getY(),
(byte) pl.getLocation().getZ(),
(byte) pl.getLocation().getYaw(),
(byte) pl.getLocation().getPitch());
for(Player p : Bukkit.getServer().getOnlinePlayers()) {
((CraftPlayer)p).getHandle().playerConnection.sendPacket(packet);
}
}
}
public static void deleteDisguise(Player p) {
if (ids.containsKey(p.getName())) {
PacketPlayOutEntityDestroy mobPacket = new PacketPlayOutEntityDestroy(
ids.get(p.getName()));
for (Player player : Bukkit.getServer().getOnlinePlayers()) {
((CraftPlayer) player).getHandle().playerConnection
.sendPacket(mobPacket);
}
ids.remove(p.getName());
}
}
private static void setPrivateField(Class<?> type, Object object, String name,
Object value) {
try {
Field f = type.getDeclaredField(name);
f.setAccessible(true);
f.set(object, value);
f.setAccessible(false);
} catch (Exception ex) {
ex.printStackTrace();
}
}
}

And this class works fine! But entity moves wrong. I use walk(p) at the PlayerMoveEvent, and when I just rotate my had, my created entity "flying" far away. Help me, please, what's wrong?

 

xXBeLkAXx http://wiki.vg/Protocol#Entity_Look_and_Relative_Move
The X/Y/Z aren't actually x/y/z values, rather the change in them.

 

xTigerRebornx
What are u talking about? getX() and getBlockX()?

 

xXBeLkAXx
xTigerRebornx means the x, y, z do not correspond to the location of the entity but the change from the original/previous position.

 

rbrick
So, what I should do?

 

Bump! Please, help!

 

xXBeLkAXx Calculate the change in their x, y, and z and use those.

 

xTigerRebornx
Don't know how to do it. My walk packet -

Code:java

public static void walk(Player pl) {
if (ids.containsKey(pl.getName())) {
PacketPlayOutRelEntityMoveLook packet = new PacketPlayOutRelEntityMoveLook(ids.get(pl.getName()),
(byte) pl.getLocation().getBlockX(),
(byte) pl.getLocation().getY(),
(byte) pl.getLocation().getZ(),
(byte) pl.getLocation().getYaw(),
(byte) pl.getLocation().getPitch());
for(Player p : Bukkit.getServer().getOnlinePlayers()) {
((CraftPlayer)p).getHandle().playerConnection.sendPacket(packet);
}
}
}

 

xXBeLkAXx Its basic math, difference = subtraction. Subtract previous location values from new ones.

 

xTigerRebornx
I tried. But nothing changed Could you please type a code?

 

xXBeLkAXx I refuse to write your code if you can't do simple subtraction.

 

Why u no Delta?

 

xTigerRebornx
My code:

Code:java

@EventHandler
    public void onMove(PlayerMoveEvent e) {
        DisguiseFactory.walk(e.getPlayer());
    }

 

xXBeLkAXx

Code:java

 
public static void walk( String playerName, Location old, Location newLoc )
{
  if( ids.containsKey( playerName ) )
  {
    PacketPlayOutRelEntityMoveLook packet = new PacketPlayOutRelEntityMoveLook(
    ids.get( playerName ),
    (byte) ((newLoc.getBlockX() - oldLoc.getBlockX()) * 32), // Fixed Point Format
    (byte) ((newLoc.getBlockY() - oldLoc.getBlockY()) * 32), // Fixed Point Format
    (byte) ((newLoc.getBlockZ() - oldLoc.getBlockZ()) * 32), // Fixed Point Format
    (byte) ((newLoc.getYaw() + 180) / 360), // Site says "fraction of 360", might need tweaking
    (byte) ((newLoc.getPitch() + 180) / 360); // Site says "fraction of 360", might need tweaking
    for( Player p : Bukkit.getServer().getOnlinePlayers() )
    {
      ((CraftPlayer)p).getHandle().playerConnection.sendPacket(packet);
    }
  }
}

@Edit: Changed to fixed point and "fraction of 360."
If yaw and pitch go from -180 to 180, then adding 180 changes to a scale of 0 to 360. Then you divide to get "fraction of 360."

 

TheDummy Changes are in Fixed Point Numbers to support small changes I'd assume.

 

xTigerRebornx Fixed. Thank you.

 

TheDummy
Thak you! And xTigerRebornx thank you too!