Logging Certain Blocks

Hello Bukkit Community! I am looking for a way to log certain blocks that have been broken.

For instance, I break a diamond ore block, I want it to get saved into a .yml file, and then can be referenced later with a command, and each time a player breaks a diamond ore, it increases the number of diamond ore blocks broken in the config file, by one.

How exactly would I go about doing that?

Code:

Code:java

package net.marc.xray;
 
import org.bukkit.Material;
import org.bukkit.block.Block;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.BlockBreakEvent;
 
public class LogBlocks implements Listener
{
    @EventHandler
    public void logBlocks(BlockBreakEvent event)
    {
        Player player = event.getPlayer();
        Block block = event.getBlock();
 
        if (block.getType().equals(Material.STONE))
        {
            player.sendMessage("You have broken stone! This is a test.");
        }
    }
}

 

onBlockBreakEvent, check if the block is diamond ore, then increase in config for each player or one global one.

 

I have tried that, it just keeps resetting the value in the config file each time, only setting it to 1 each time a block is broken, I have added my current code to the main post.

Think of the stone as the diamond_ore I am referencing.

Still looking for a bit of help with this, if possible.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

As LordVakar said:
Increase one global one

Code:java

String num = getConfig().getString("globalcount.diamond");
num = (int)num + 1;

or do the same just for players.

 

Could you explain a little more?
You are somehow converting a String into an int here...

Code:java

 
package net.marc.xray;
 
import org.bukkit.Material;
import org.bukkit.block.Block;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.BlockBreakEvent;
 
public class LogBlocks implements Listener
{
public static int stone = XRayChecker.getInstance().getConfig().getInt(".Stone");
public static int diamond = XRayChecker.getInstance().getConfig().getInt(".Diamond");
public static int emerald = XRayChecker.getInstance().getConfig().getInt(".Emerald");
 
public static void loadConfigs()
{
XRayChecker.getInstance().getConfig().set(".Stone", stone);
XRayChecker.getInstance().getConfig().set(".Diamond", diamond);
XRayChecker.getInstance().getConfig().set(".Emerald", emerald);
}
 
@EventHandler
public void logBlocks(BlockBreakEvent event)
{
Block block = event.getBlock();
/*Player player = event.getPlayer();*/
 
if (block.getType().equals(Material.STONE))
{
//Player Breaking Stone
stone = (int)stone + 1;
XRayChecker.getInstance().saveConfig();
}
else if (block.getType().equals(Material.DIAMOND_ORE))
{
//Player Breaking Diamond Ore
}
else if (block.getType().equals(Material.EMERALD_ORE))
{
//Player Breaking Emerald Ore
}
}
}
 

Still need some help with this, no idea why it isn't saving the values, it just returns it to 0, instead of counting upwards.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Well, first of all, you're attempting to access a JavaPlugin instance statically. Before it exists.
Second, why the periods in front of the paths? I doubt YAML likes that very much.

What...

 

Code:

package net.marc.xray;
 
import org.bukkit.Material;
import org.bukkit.block.Block;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.BlockBreakEvent;
 
public class LogBlocks implements Listener {
private XRayChecker plugin;
private int stone;
private int diamond;
private int emerald;
 
public LogBlocks() {
    // Store the plugin instance to avoid calling XRayChecker.getInstance() 226236 times
    // and generally making the code look awful. Really you should pass it in as a parameter but whatever.
    plugin = XRayChecker.getInstance();
    // Get the current values - if they don't exist they are assumed to be 0
    stone = plugin.getConfig().getInt("Stone", 0);
    diamond = plugin.getConfig().getInt("Diamond", 0);
    emerald = plugin.getConfig().getInt("Emerald", 0);
}
 
private void save() {
// Set the values in the config
plugin.getConfig().set("Stone", stone);
plugin.getConfig().set("Diamond", diamond);
plugin.getConfig().set("Emerald", emerald);
// Use Bukkit's saveConfig() method to save the config
plugin.saveConfig();
}
 
@EventHandler
public void onBlockBreak(BlockBreakEvent event) {
Block block = event.getBlock();
 
if (block.getType().equals(Material.STONE)) {
// The player broke a stone block
// Increment the stone value by one
stone++;
// Write the values to the configuration
save();
} else if (block.getType().equals(Material.DIAMOND_ORE)) {
// The player broke a diamond ore block
// Increment the diamond value by one
diamond++;
// Write the values to the configuration
save();
} else if (block.getType().equals(Material.EMERALD_ORE)) {
// The player broke an emerald ore block
// Increment the emerald value by one
emerald++;
// Write the values to the configuration
save();
}
}
}

This will increase the value and write it every time a block of the type is broken by any player (I don't guarantee this compiles or works 100% - it's not hard to change). I'll leave you to figure out how to store a different value for each player.

 

New to the configuration syntax. :/
And I see what you're saying, I didn't think that one through, I will change it around.

Edit:
It works, woo, finally!

Code:java

package net.marc.xray;
 
import org.bukkit.Material;
import org.bukkit.block.Block;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.BlockBreakEvent;
 
public class LogBlocks implements Listener
{   
    public static XRayChecker getInstance = XRayChecker.getInstance();
 
    @EventHandler
    public void logBlocks(BlockBreakEvent event)
    {
        Block block = event.getBlock();
 
        int stone = getInstance.getConfig().getInt("Stone");
        int diamond = getInstance.getConfig().getInt("Diamond");
        int emerald = getInstance.getConfig().getInt("Emerald");
 
        if (block.getType().equals(Material.STONE))
        {
            //Player Breaking Stone
            stone = (int)stone + 1;
            getInstance.getConfig().set("Stone", stone);
            getInstance.saveConfig();
        }
        else if (block.getType().equals(Material.DIAMOND_ORE))
        {
            //Player Breaking Diamond Ore
            diamond = (int)diamond + 1;
            getInstance.getConfig().set("Diamond", diamond);
            getInstance.saveConfig();
        }
        else if (block.getType().equals(Material.EMERALD_ORE))
        {
            //Player Breaking Emerald Ore
            emerald = (int)emerald + 1;
            getInstance.getConfig().set("Emerald", emerald);
            getInstance.saveConfig();
        }
    }
}

Yea, that's what I'm trying to figure out now.
I'm guessing I have to use hash maps, but that's just my guess.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

SilentThief Maps with a key of each player UUID is an option, but you would have to figure out a way to have a value for the Map which holds three different integers (hint, make an object).

 

I came up with this (from what you said):

Code:java

 
package net.marc.xray;
 
import java.util.HashMap;
import java.util.Map;
import java.util.UUID;
 
import org.bukkit.Material;
import org.bukkit.block.Block;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.BlockBreakEvent;
 
public class LogBlocks implements Listener 
{
public static Map<UUID, LogBlocks> playerMap = new HashMap<UUID, LogBlocks>();
 
private XRayChecker plugin;
private int stone;
private int diamond;
private int emerald;
LogBlocks blocks = new LogBlocks(stone, diamond, emerald);
 
public LogBlocks(int s, int d, int e) 
{
plugin = XRayChecker.getInstance();
 
stone = plugin.getConfig().getInt("Player.Stone", 0);
diamond = plugin.getConfig().getInt("Player.Diamond", 0);
emerald = plugin.getConfig().getInt("Player.Emerald", 0);
 
stone = s;
diamond = d;
emerald = e;
}
 
private void save() 
{
plugin.getConfig().set("Player.Stone", stone);
plugin.getConfig().set("Player.Diamond", diamond);
plugin.getConfig().set("Player.Emerald", emerald);
 
plugin.saveConfig();
}
 
@EventHandler
public void onBlockBreak(BlockBreakEvent event)
{
Block block = event.getBlock();
 
if (block.getType().equals(Material.STONE)) 
{
stone++;
save();
} 
else if (block.getType().equals(Material.DIAMOND_ORE)) 
{
diamond++;
save();
} 
else if (block.getType().equals(Material.EMERALD_ORE)) 
{
emerald++;
save();
}
}
}
 

Hash maps are not my strong suit. As you can probably tell.

 

SilentThief That's not what I meant by make an object. Your object should be of a class looking something like this:

Code:

private class XRayData {
    UUID playerId;
    int stone, diamond, emerald;
 
    XRayData(UUID playerId) {
        this.playerId = playerId;
 
        stone = 0;
        diamond = 0;
        emerald = 0;
    }
 
    void load(ConfigurationSection sec) {
        playerId = UUID.fromString(sec.getString("uuid"));
        stone = sec.getInt("stone");
        diamond = sec.getInt("diamond");
        emerald = sec.getInt("emerald");
    }
 
    void save(ConfigurationSection sec) {
        sec.set("uuid", playerId.toString());
        sec.set("stone", stone);
        sec.set("diamond", diamond);
        sec.set("emerald", emerald);
    }
}

Define this class inside your LogBlocks class (inner classes).

Create one of these objects whenever the player joins (PlayerJoinEvent). Call load(ConfigurationSection) only if the player has data already. To get a ConfigurationSection, call plugin.getConfig().getConfigurationSection("player-uuid"); If it doesn't exist, this will be null. Only call load if it isn't null. When a player quits, do likewise. Call getConfigurationSection(), but this time if it doesn't exist, create it with createSection("player-uuid");

When a player breaks a block, look them up in your HashMap - defined as below:

private final Map<UUID, XRayData> map = new HashMap<>();

Because this is an inner class, don't worry about getters / setters - just do data.stone++; or whatever.

This approach eliminates the need to save every time a block is broken. However, you should save all currently loaded players' data when the plugin disables (create a saveAll() in your listener, call it in onDisable(). saveAll() loops through map.values() and calls save() for all of them, in the same way I described before).