While causing problems when on multiplier

Hi!

I'm having a problem with this code snippet...
basically it works perfectly with one player but then when another player runs the same while it repeats the StartThat.get(player); constantly creating a large negative number crashing the server.

I tried to make everything "Player Specific" in the case that everything would be set to the player not just a general array which I thought would solve my problem, and it did not.

I'm hoping the Bukkit community can help me out in my time of need as I have run out of options and ideas .

Thank you very much in advance.

Code:java

                    /* Method to Repair Cobble Walls */
 
    public HashMap<String, Location> ocation = new HashMap();
    public HashMap<String, Integer> startThat = new HashMap();
    public ArrayList brokenBlocks = new ArrayList();     
 
                    if (ocation.containsKey(player.getName())) {
                        if (brokenBlocks.isEmpty() == false) {
                            double start = ocation.get(player.getName()).getY();
                            int startt = (int) start;
                            startThat.put(player.getName(), startt);
                            double current = 1 + block.getY();
                            while (startThat.get(player.getName()) != current) {
                                int i = startThat.get(player.getName());
                                i --;
                                startThat.put(player.getName(), i);
 
                                //Printing - [StartThat.get(x)]; constantly when dealing with 2 players running the operation
                                //Although current stays the same
 
                                System.out.println(startThat.get(player.getName()) + " -- " + current);
                                Location airchk = new Location(player.getWorld(), ocation.get(player.getName()).getX(), startThat.get(player.getName()), ocation.get(player.getName()).getZ());
                                if (brokenBlocks.contains(airchk)) {
                                    if (airchk.getBlock().getType().equals(Material.AIR)) {
                                        if (airchk.getX() == ocation.get(player.getName()).getX()) {
                                            player.sendMessage(ChatColor.RED + "Broken Parts");
                                            checkRemove(player);
                                            //no reason to keep checking for more broken blocks
                                            break;
                                        }

 

I'd say the problem is that you're comparing integer and double, but I'm not 100% sure. You should try to floor the double before comparing. This line is the problem:

Code:java

startThat.get(player.getName()) != current

startThat.get(player.getName()) can also return null, so you should do a null-check before comparing, because double is always different than null.