Create circle around player

i tried to create a particle circle around a player for like a spell but it kinda doesn't work.
also i find this code a little bit weird, there has to be a different and easier way to do it.

Code:java

/*
    * - - - - x x x - - - -
    * - - x x - - - x x - -
    * - x - - - - - - - x -
    * - x - - - - - - - x -
    * x - - - - - - - - - x
    * x - - - - O - - - - x
    * x - - - - - - - - - x
    * - x - - - - - - - x -
    * - x - - - - - - - x -
    * - - x x - - - x x - -
    * - - - - x x x - - - -
    */
 
    public void run() {
        if (amDone >= 75) done = true;
        if (player.isDead() || player == null || done) cancel();
        ParticleEffect.MOB_SPELL.display(player.getLocation().add(0, 1, 5), 0, 0, 0, 3, parAm);                               
        ParticleEffect.MOB_SPELL.display(player.getLocation().add(1, 1, 5), 0, 0, 0, 3, parAm);
        ParticleEffect.MOB_SPELL.display(player.getLocation().add(-1, 1, 5), 0, 0, 0, 3, parAm);
        ParticleEffect.MOB_SPELL.display(player.getLocation().add(0, 1, -5), 0, 0, 0, 3, parAm);                               
        ParticleEffect.MOB_SPELL.display(player.getLocation().add(1, 1, -5), 0, 0, 0, 3, parAm);
        ParticleEffect.MOB_SPELL.display(player.getLocation().add(-1, 1, -5), 0, 0, 0, 3, parAm);
        ParticleEffect.MOB_SPELL.display(player.getLocation().add(5, 1, 0), 0, 0, 0, 3, parAm);                               
        ParticleEffect.MOB_SPELL.display(player.getLocation().add(5, 1, 1), 0, 0, 0, 3, parAm);
        ParticleEffect.MOB_SPELL.display(player.getLocation().add(5, 1, -1), 0, 0, 0, 3, parAm);
        ParticleEffect.MOB_SPELL.display(player.getLocation().add(-5, 1, 0), 0, 0, 0, 3, parAm);                               
        ParticleEffect.MOB_SPELL.display(player.getLocation().add(-5, 1, 1), 0, 0, 0, 3, parAm);
        ParticleEffect.MOB_SPELL.display(player.getLocation().add(-5, 1, -1), 0, 0, 0, 3, parAm);
        ParticleEffect.MOB_SPELL.display(player.getLocation().add(4, 1, 2), 0, 0, 0, 3, parAm);                               
        ParticleEffect.MOB_SPELL.display(player.getLocation().add(4, 1, 3), 0, 0, 0, 3, parAm);
        ParticleEffect.MOB_SPELL.display(player.getLocation().add(3, 1, 4), 0, 0, 0, 3, parAm);
        ParticleEffect.MOB_SPELL.display(player.getLocation().add(2, 1, 4), 0, 0, 0, 3, parAm);
        ParticleEffect.MOB_SPELL.display(player.getLocation().add(-4, 1, 2), 0, 0, 0, 3, parAm);                               
        ParticleEffect.MOB_SPELL.display(player.getLocation().add(-4, 1, 3), 0, 0, 0, 3, parAm);
        ParticleEffect.MOB_SPELL.display(player.getLocation().add(-3, 1, 4), 0, 0, 0, 3, parAm);
        ParticleEffect.MOB_SPELL.display(player.getLocation().add(-2, 1, 4), 0, 0, 0, 3, parAm);
        ParticleEffect.MOB_SPELL.display(player.getLocation().add(4, 1, -2), 0, 0, 0, 3, parAm);                               
        ParticleEffect.MOB_SPELL.display(player.getLocation().add(4, 1, -3), 0, 0, 0, 3, parAm);
        ParticleEffect.MOB_SPELL.display(player.getLocation().add(3, 1, -4), 0, 0, 0, 3, parAm);
        ParticleEffect.MOB_SPELL.display(player.getLocation().add(2, 1, -4), 0, 0, 0, 3, parAm);
        ParticleEffect.MOB_SPELL.display(player.getLocation().add(-4, 1, -2), 0, 0, 0, 3, parAm);                               
        ParticleEffect.MOB_SPELL.display(player.getLocation().add(-4, 1, -3), 0, 0, 0, 3, parAm);
        ParticleEffect.MOB_SPELL.display(player.getLocation().add(-3, 1, -4), 0, 0, 0, 3, parAm);
        ParticleEffect.MOB_SPELL.display(player.getLocation().add(-2, 1, -4), 0, 0, 0, 3, parAm);
        amDone++;
    }

i want to close those gaps between the particles and make the circle more round but in the way that i dont have to use the same line of code with decimal numbers over and over again. seems a bit unnecessary.

 

You can try this little code I wrote now, it's based on a circle definition of a distance from the circle center, so it should work just fine. basicly what it does, is checking all the blocks in the square around the player where the circle should be and if the block is in the right distance it makes the particles apear there.

Code:java

/*
* - - - - x x x - - - -
* - - x x - - - x x - -
* - x - - - - - - - x -
* - x - - - - - - - x -
* x - - - - - - - - - x
* x - - - - O - - - - x
* x - - - - - - - - - x
* - x - - - - - - - x -
* - x - - - - - - - x -
* - - x x - - - x x - -
* - - - - x x x - - - -
*/
 
public void run() {
if (amDone >= 75) done = true;
if (player.isDead() || player == null || done) cancel();
int radius = RAD;
for(int x = player.getLocation().getBlockX() - radius ; x <= player.getLocation().getBlockX() + radius ; x++)
  for(int z = player.getLocation().getBlockZ() - radius ; x <= player.getLocation().getBlockZ() + radius ; z++)
    if(Math.round(Math.sqrt(Math.pow(player.getLocation().getBlockX() - x, 2) +
        Math.pow(player.getLocation().getBlockZ() - z, 2))) == radius)
          ParticleEffect.MOB_SPELL.display(new Location(player.getWorld(), x, player.getLocation().getBlockY() + 1, z), 0, 0, 0, 3, parAm);
 
amDone++;
}

 

Woef2001

why do you not loop to create a circle?

int size = 30;
for(int i = 0.0; i < 360.0;i++) {

double angle = (i*Math.PI - 180);
int x = (int) size*Math.cos(angle);
int z = (int) size*Math.sin(angle);
Block block = p.getLocation().getWorld().getBlockAt(x, p.getLocation().getY() , z);
}

 

hmm i implemented your code but it doesnt seems to work:

Code:java

private void createCircle() {
        double size = 5;
        for(int i = 0; i < 360; i++) {
            double angle = (i*Math.PI - 180);
            double x = size*Math.cos(angle);
            double z = size*Math.sin(angle);
            Location loc = player.getLocation().add(x, 1, z);
            ParticleEffect.MOB_SPELL.display(loc, 0, 0, 0, 3, parAm);
        }
    }

 

xize Woef2001 Degree to radian conversion can be done with degrees * Math.PI / 180 (xise misspelled?), or Math#toRadians(double). You could even create a constant for Math.PI / 180 as an attempt for micro-optimisation or create a cache for the sine and cosine results.

 

Traks
yea I see ive misspelled alot more D: its indeed / 180 and I forgot to use loc.add() to

 

can som1 plss give the code for this? i'm trying to find the right code for weeks now...

 

okay i've been working with this code for a while but one thing bothers me a lot.
when i start the thread that will display the particles every time it displays new particles it removes the other particles spawned in earlier!

code:

Code:java

 
private Player player;
    private boolean done = false;
    private int amDone = 0;
    private int parAm = 5;
    private double size = 7;
 
    public MageSpecial(Mage kit) {
        player = kit.getPlayer();
        runTaskTimer(Main.plugin, 0l, 4l);
    }
 
    public void run() {
        if (amDone >= 75) done = true;
        if (player.isDead() || player == null || done) cancel();
 
        for (int i = 0; i < 360; i++) {
            double angle = (i * Math.PI / 180);
            double x = size * Math.cos(angle);
            double z = size * Math.sin(angle);
            Location loc = player.getLocation().add(x, 1, z);
            ParticleEffect.MOB_SPELL.display(loc, 0, 0, 0, 1, parAm);
            ParticleEffect.WITCH_MAGIC.display(loc, 0, 0, 0, 1, parAm);    
        }
 
        amDone++;
    }
 

it looks like this all the time:
View attachment 21430

you dont get those particles above the particles that display the ring:
View attachment 21432

they don't fade away they just disappear.

srr but my browser wont let me edit the replies.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

I tried your code with hearts but its way too fast...

 

bump

 

With this code how would you detect players within the circle created?

 

Vorqe loop over players, check if the distanceSquared is smaller than the radius squared

 

can't som1 just give me the code?

 

Woef2001 nickpowns

Code:java

int points = 12 //amount of points to be generated
for (int i = 0; i < 360; i += 360/points) {
            double angle = (i * Math.PI / 180);
            double x = size * Math.cos(angle);
            double z = size * Math.sin(angle);
            Location loc = player.getLocation().add(x, 1, z);
            ParticleEffect.MOB_SPELL.display(loc, 0, 0, 0, 1, parAm);
            ParticleEffect.WITCH_MAGIC.display(loc, 0, 0, 0, 1, parAm);   
        }

This is a bit modified code by Woef2001

 

can you fit it in an playerjoin event plss

 

nickpowns try writing your own, instead of asking to be spoonfed... Then you might actually learn something new