Solved Need help with my TeleportToRandomLocation plugin!

Hey everybody, My name is PeterSa and I really need help with my new plugin which is TeleportToRandomLoaction.
Everything is al-right in this plugin! Everything is fine.
Whenever you do /tprandom it teleports you to a random location.
and it will send you a message that everything is successfully done and how many blocks you are away from your previous location and how many blocks you are away from the spawnpoint.
But my problem is, I want it to spawn on grass, sand, stone..
Not water. So please help.
Here's the code :

Code:java

package me.petersa.Teleport;
 
import java.util.Random;
 
import org.bukkit.ChatColor;
import org.bukkit.Location;
import org.bukkit.Material;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.Listener;
import org.bukkit.plugin.java.JavaPlugin;
 
 
public class TeleportPlayerRandomLocation extends JavaPlugin implements Listener {
@Override
public void onEnable(){
  System.out.println("[TeleportPlayerRandomLocation] teleport-random plugin by PeterSa has been enabled!");
  this.getServer().getPluginManager().registerEvents(this, this);
}
@Override
public void onDisable(){
  System.out.println("[TeleportPlayerRandomLocation] teleport-random plugin by PeterSa has been disabled!");
}
public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
  if (cmd.getName().equalsIgnoreCase("tprandom")) {
  if (!sender.hasPermission("psa.tprandom")) {
  sender.sendMessage(ChatColor.RED + "You are not allowed to use that command! permission node: psa.tprandom");
  }else{
  Player player = (Player) sender;
  Location originalLocation = player.getLocation();
  Location spawnLocation = player.getWorld().getSpawnLocation();
 
  Random random = new Random();
 
  int x = random.nextInt(10000) + 1;
      int y = 100;
      int z = random.nextInt(10000) + 1;
 
      Location teleportLocation = new Location(player.getWorld(), x, y, z);
 
      player.teleport(teleportLocation);
 
      player.sendMessage(ChatColor.GREEN + "You have been teleported " + ChatColor.RED + (int)teleportLocation.distance(originalLocation) + ChatColor.GREEN + " blocks away from your last location and " + ChatColor.RED +  (int)teleportLocation.distance(spawnLocation) + ChatColor.GREEN + " blocks away from spawn!");
  player.sendMessage(ChatColor.GRAY + "this moment will lag you just a bit and everything will be alright then. Please let the chunks load for you! Also if you got spawned in the water, Just do the command again!");
 
  return true;
  }
 
}
 
  return false;
  }
}

 

Peter25715
You could use a while loop. While the location is not grass,sand, or stone, recalculate x, y, and z.

Or if you are preventing teleporting to water only (and probably lava), check if the block is liquid (Location#getBlock()#isLiquid() )

That's just the first thought that came to my mind.

 

Hmm.. @AoH_Ruthless,
Thanks for replying to this thread, Can you please show me the (Location#getBlock()#isLiquid() ) in code? I mean How to block the teleporting if the block was liquid.
Thanks,
Peter.

 

Right after you instantiate the location, check to see if it's a liquid using location.getBlock().isLiquid().

 

Also, @AoH_Ruthless, I don't want the code to be; If the block was liquid then stop everything. I want to make the player spawn on a block which not liquid :/

@PogoStick29, I don't want the event to stop and the player should do the command again.. :\ What should I do?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Peter25715 Make a if statement if its a liquid redo the random location and if its not teleport them.

 

Maybe use a loop and see if the location (-1) is a liquid, Redo.

Thats how I think

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Use a do...while loop.

Code:java

Location loc;
 
do {
  loc = new Location(...);
} while (!loc.getBlock().isLiquid());

 

Thanks a lot for helping