Solved Leveling System Help

Hello bukkit, I have recently been working on a server and found a bug that I cannot squash:

This is how I make my config.yml:

Code:java

@EventHandler
    public void playerJoin(PlayerJoinEvent e) {
        if(!getConfig().isSet(e.getPlayer().getName() + ".WoodXp")) {
            getConfig().set(e.getPlayer().getName() + ".WoodXp", 0);
            saveConfig();
            reloadConfig();
        }
        if(!getConfig().isSet(e.getPlayer().getName() + ".WoodLevel")) {
            getConfig().set(e.getPlayer().getName() + ".WoodLevel", 0);
        }
    }

This makes the config look like so:

NinjaRoyal:
WoodXp: 1600
WoodLevel: 0
This is my code for leveling up woodcutting xp:

Code:java

@EventHandler
    public void onWoodcutting(BlockBreakEvent e) {
        int w1 = 100;
        if (e.getBlock().getType() == Material.LOG) {
            Player p = (Player) e.getPlayer();
            e.setCancelled(true);
            Random r = new Random();
            double chance = r.nextDouble();
            if (chance <= 0.10 && p instanceof Player) {
                p.sendMessage(ChatColor.DARK_AQUA + "100" + ChatColor.AQUA + " XP has been added to: " + ChatColor.GREEN.toString() + ChatColor.BOLD + "Woodcutting");
                getConfig().set(p.getName() + ".WoodXp", getConfig().getInt(p.getName() + ".WoodXp", 0) + 100);
                saveConfig();
                return;
            }
            if (chance <= 0.20 && p instanceof Player) {
                p.sendMessage(ChatColor.DARK_AQUA + "110" + ChatColor.AQUA + " XP has been added to: " + ChatColor.GREEN.toString() + ChatColor.BOLD + "Woodcutting");
                getConfig().set(p.getName() + ".WoodXp", getConfig().getInt(p.getName() + ".WoodXp", 0) + 110);
                saveConfig();
                return;
            }
            if (chance <= 0.30 && p instanceof Player) {
                p.sendMessage(ChatColor.DARK_AQUA + "120" + ChatColor.AQUA + " XP has been added to: " + ChatColor.GREEN.toString() + ChatColor.BOLD + "Woodcutting");
                getConfig().set(p.getName() + ".WoodXp", getConfig().getInt(p.getName() + ".WoodXp", 0) + 120);
                saveConfig();
                return;
            }
            if (chance <= 0.40 && p instanceof Player) {
                p.sendMessage(ChatColor.DARK_AQUA + "130" + ChatColor.AQUA + " XP has been added to: " + ChatColor.GREEN.toString() + ChatColor.BOLD + "Woodcutting");
                getConfig().set(p.getName() + ".WoodXp", getConfig().getInt(p.getName() + ".WoodXp", 0) + 130);
                saveConfig();
                return;
            }
            if (chance <= 0.50 && p instanceof Player) {
                p.sendMessage(ChatColor.DARK_AQUA + "140" + ChatColor.AQUA + " XP has been added to: " + ChatColor.GREEN.toString() + ChatColor.BOLD + "Woodcutting");
                getConfig().set(p.getName() + ".WoodXp", getConfig().getInt(p.getName() + ".WoodXp", 0) + 140);
                saveConfig();
                return;
            }
            if (chance <= 0.60 && p instanceof Player) {
                p.sendMessage(ChatColor.DARK_AQUA + "150" + ChatColor.AQUA + " XP has been added to: " + ChatColor.GREEN.toString() + ChatColor.BOLD + "Woodcutting");
                getConfig().set(p.getName() + ".WoodXp", getConfig().getInt(p.getName() + ".WoodXp", 0) + 150);
                saveConfig();
                return;
            }
            if (chance <= 0.70 && p instanceof Player) {
                p.sendMessage(ChatColor.DARK_AQUA + "160" + ChatColor.AQUA + " XP has been added to: " + ChatColor.GREEN.toString() + ChatColor.BOLD + "Woodcutting");
                getConfig().set(p.getName() + ".WoodXp", getConfig().getInt(p.getName() + ".WoodXp", 0) + 160);
                saveConfig();
                return;
            }
            if (chance <= 0.80 && p instanceof Player) {
                p.sendMessage(ChatColor.DARK_AQUA + "170" + ChatColor.AQUA + " XP has been added to: " + ChatColor.GREEN.toString() + ChatColor.BOLD + "Woodcutting");
                getConfig().set(p.getName() + ".WoodXp", getConfig().getInt(p.getName() + ".WoodXp", 0) + 170);
                saveConfig();
                return;
            }
            if (chance <= 0.90 && p instanceof Player) {
                p.sendMessage(ChatColor.DARK_AQUA + "180" + ChatColor.AQUA + " XP has been added to: " + ChatColor.GREEN.toString() + ChatColor.BOLD + "Woodcutting");
                getConfig().set(p.getName() + ".WoodXp", getConfig().getInt(p.getName() + ".WoodXp", 0) + 180);
                saveConfig();
                return;
            }
            if (chance <= 1 && p instanceof Player) {
                p.sendMessage(ChatColor.DARK_AQUA + "190" + ChatColor.AQUA + " XP has been added to: " + ChatColor.GREEN.toString() + ChatColor.BOLD + "Woodcutting");
                getConfig().set(p.getName() + ".WoodXp", getConfig().getInt(p.getName() + ".WoodXp", 0) + 190);
                saveConfig();
                return;
            }
 
 
            }
        }

All of this works perfectly fine except for 1 thing that I want to add.
Basicly I want to detect if WoodXp is equal to a certain integer (say 500) then it would send me a message saying you have leveled up and maybe play a sound effect. Everything I try seems to give me errors like cannot go from string to int or something like that.
How it should work:
After my WoodXp reachs a certain int such as 500 it would change my WoodLevel to 2.
Sort of like this:

Code:java

if (config.getInt(p.getName + ".WoodXp") == 500) {
    config.set(p.getName + ".WoodLevel", 2);
}

but that seems to give me an error? If there is a better way to do this please tell me or if you know why it wont work.

 

whats the error your getting?

 

You should look into using SQL instead of configs. As for your problem you should first go about posting the StackTrace.

 

NinjaRoyal
also, use saveConfig();
(if you using default one)

 

Skionz
IkBenHarm
LavaisWatery

Code:

if (config.getInt(p.getName() + ".WoodXp") == 500 && config.getInt(p.getName() + ".WoodXp") < 1000) {
                config.set(p.getName() + ".WoodLevel", 2);
                Bukkit.getServer().broadcastMessage("debug");
            }

That code seems to work except how would I make it so it doesn't broadcast a debug msg everytime? Because I want it to do some code ONLY ONE when the WoodXp reachs 500 or more. If I do it this way it would only do it if the xp is 500 and if it is above then it would do nothing. So something like WoodXp >= 500 but then it would broadcast everytime I mine wood from 500-1000 which would be extremely annoying

 

I'm not sure if im understanding correctly but you want it to only broadcast when you are at level 1 and at 500 xp? If this is the case then you could do something like this

Code:

if(config.getInt(p.getName() + ".WoodXp") >= 500 && config.getInt(p.getName() + ".WoodLevel") == 1) {
    //do stuff
}

 

Skionz
Ah! Didn't think about that one Now I feel like I'm stupid. Thanks so much for the help though. Still yet to test so will post results and the working code soon.

Skionz
http://prntscr.com/4binp7

Getting a weird exception whenever I punch ?

Code:java

@EventHandler
    public void onInteract(PlayerInteractEvent e) {
        final Player p = (Player) e.getPlayer();
        if (p.getItemInHand().getItemMeta().getDisplayName().equals(ChatColor.WHITE + "Rag") && e.getAction().equals(Action.RIGHT_CLICK_AIR)) {
            if (!(bleed.contains(p.getName()))) {
                p.sendMessage(ChatColor.RED + "I am not wounded!");
                return;
            }
            p.sendMessage(ChatColor.GREEN + "You begin to bandage yourself.");
            patching.add(p.getName());
            Bukkit.getServer().getScheduler().scheduleSyncDelayedTask(this, new Runnable() {
                  public void run() {
                      if (bleed.contains(p.getName()) && patching.contains(p.getName())){
                          ItemStack is = p.getItemInHand();
                          if(is != null) {
                              if(is.getAmount() > 1)
                                    is.setAmount(is.getAmount() - 1);
                                else p.setItemInHand(null);
                          }
                            p.updateInventory();
                            bleed.remove(p.getName());
                            patching.remove(p.getName());
                            p.sendMessage(ChatColor.GREEN + "You temporarily patch up your wounds.");
                        }
                  }
                }, 200L);

That is my code for where the error might be? Idk it says something about line 149 and this is the code there. Sorry not so good at reading stack traces.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

NinjaRoyal
It looks like it is just a null pointer error which means you forgot to check if something was null before checking for a value or something around those lines. Anyway which line is 149? From what I'm seeing you should probably check if the item hasItemMeta before checking for the display name

Code:

 if (p.getItemInHand().hasItemMeta && p.getItemInHand().getItemMeta().getDisplayName().equals(ChatColor.WHITE + "Rag") && e.getAction().equals(Action.RIGHT_CLICK_AIR)) {
  //stuff
}

 

Skionz
Ok I will test this later but in a more important matter another thing I am having trouble with is:

Code:java

//give xp\\
                //woodcutting
                if (cmd.getName().equalsIgnoreCase("woodcutting")) {
                    if (args.length < 2) {
                        sender.sendMessage(ChatColor.RED + "/woodcutting [player] [amount]");
                        return true;
                    }
                    @SuppressWarnings("deprecation")
                    Player xp = (Player) Bukkit.getServer().getPlayer(args[1]);
                    Player p = (Player) sender;
                    int newxp = config.getInt(xp.getName() + ".WoodXp" + args[3]);
                    if (!(xp instanceof Player)) {
                        return true;
                    }
                    if (!(p instanceof Player)) {
                        return true;
                    }
                    getConfig().set(p.getName() + ".WoodXp", newxp);
                    saveConfig();
                    reloadConfig();
                    return true;
                }

That is my code for setting the WoodXp on a player. But when i do the command it gives me a error in the console:
http://prntscr.com/4bj763
A unhandled exception error.
Also the code for the error when I punch doesn't work either. Still giving me an exception when I punch.

 

Code:

/woodcutting [player] [amount]

/woodcutting is the command, [player] is args[0] and amount is args[1]. the arguments start at 0 not 1.

But one question, currently you are setting the woodcutting xp to the player who sent the command, shouldn't you be setting the woodcutting xp to whoever is args[0]? Sorry if this is confusing ill give an example

player1 executes the command /woodcutting player2 500. Right now this would give player1 500 xp not player2.
so to fix this you would change

Code:

 getConfig().set(p.getName() + ".WoodXp", newxp);

to

Code:

 getConfig().set(xp.getName() + ".WoodXp", newxp);

right now p is the player who sent the command and xp is args[0]

EDIT: and i believe this line

Code:

int newxp = config.getInt(xp.getName() + ".WoodXp" + args[3]);

should be this

Code:

int newxp = config.getInt(xp.getName() + ".WoodXp") + args[1];

 

Skionz
Oooooh ok I understand. Let me test this out

Skionz Ok so it works but it always sets it to 0?
code:

Code:java

//give xp\\
                //woodcutting
                if (cmd.getName().equalsIgnoreCase("woodcutting")) {
                    if (args.length < 1) {
                        sender.sendMessage(ChatColor.RED + "/woodcutting [player] [amount]");
                        return true;
                    }
                    @SuppressWarnings("deprecation")
                    Player xp = (Player) Bukkit.getServer().getPlayer(args[0]);
                    Player p = (Player) sender;
                    int newxp = config.getInt(xp.getName() + ".WoodXp" + args[1]);
                    if (!(xp instanceof Player)) {
                        return true;
                    }
                    if (!(p instanceof Player)) {
                        return true;
                    }
                    getConfig().set(xp.getName() + ".WoodXp", newxp);
                    p.sendMessage(ChatColor.DARK_AQUA + ");
                    saveConfig();
                    reloadConfig();
                    return true;
                }

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

What do you mean it always sets it to 0?
and you have a little error right here, you forgot an end quote

Code:

p.sendMessage(ChatColor.DARK_AQUA + ");

so the quote is stopping your config from saving and reloading.

 

Skionz
I just did that to test but it isn't working without it. And basicly when ever I do the command it sets my "WoodXp" In the config to 0 no matter what. So if I do the command /woodcutting ninjaboy323 100 it would set it to 0 rather then 100.

 

NinjaRoyal

Code:

config.getInt(xp.getName() + ".WoodXp" + args[1]);

Not sure what you are doing here, but I am guessing this path doesn't exist, returning 0.

 

xTigerRebornx
If you are talking about the WoodXp path it exists because it is setting it to 0. But it should be setting it to what I specify in arg 1.

 

NinjaRoyal
I'm not sure but I think args[1] is currently a string so you would have to use Integer.parseInt(args[1]) to change it to a int. Although im not sure

 

Skionz
xTigerRebornx
I tryed parsing and did some debug test and it seems that it thinks arg[1] is equal to 0. I did some message tests and that was the result.

Code:java

//give xp\\
                //woodcutting
                if (cmd.getName().equalsIgnoreCase("woodcutting")) {
                    if (args.length < 1) {
                        sender.sendMessage(ChatColor.RED + "/woodcutting [player] [amount]");
                        return true;
                    }
                    @SuppressWarnings("deprecation")
                    Player xp = (Player) Bukkit.getServer().getPlayer(args[0]);
                    Player p = (Player) sender;
                    Integer.parseInt(args[1]);
                    int newxp = config.getInt(xp.getName() + ".WoodXp" + args[1]);
                    if (!(xp instanceof Player)) {
                        return true;
                    }
                    if (!(p instanceof Player)) {
                        return true;
                    }
                    getConfig().set(xp.getName() + ".WoodXp", newxp);
                    p.sendMessage(ChatColor.DARK_AQUA.toString() + args[1] + ChatColor.AQUA + " has been added to " + ChatColor.GREEN.toString() + ChatColor.BOLD + args[0]);
                    saveConfig();
                    reloadConfig();
                    return true;
                }

This is all my current code. I need someone to help me please

 

I believe you have to set parseInt to a variable, try this.

Code:

Int xpToAdd = Integer.parseInt(args[1]);
int newxp = config.getInt(xp.getName() + ".WoodXp" + xpToAdd);

 

Skionz
Int cannot be resolved to a type. But integer works shall I do that?

 

NinjaRoyal it was a typo sorry "Int" should be "int" so change it to

Code:

int xpToAdd = Integer.parseInt(args[1]);

 

Skionz
Oh ok, integer didn't work so let me try that and I will get back to you

Skionz
Still sets it to 0

Skionz
I don't really need this command is there a way I can change this in the config? Because if I try to change the values in the config it just resets it. I also tryed making a command with the code:

Code:java

saveConfig();
reloadConfig();

But doesn't seem to work

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

NinjaRoyal do you have saveConfig() on disable?

 

Skionz
Yep

 

NinjaRoyal get rid of it, that should fix it

 

Skionz

Code:java

@EventHandler
    public void playerJoin(PlayerJoinEvent e) {
        if(!getConfig().isSet(e.getPlayer().getName() + ".WoodXp")) {
            getConfig().set(e.getPlayer().getName() + ".WoodXp", 0);
            saveConfig();
            reloadConfig();
        }
        if(!getConfig().isSet(e.getPlayer().getName() + ".WoodLevel")) {
            getConfig().set(e.getPlayer().getName() + ".WoodLevel", 1);
        }
    }

I have that code but when I reset the config.yml and relogged it only created WoodXp and not WoodLevel?
Also if I remove saveConfig(); on disable wouldn't that make it so it never saves if I disable server?

Skionz
hmmm it seems that It makes WoodLevel when I run the command that saves and reloads config.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Save whenever you change something something with getConfig.set() but don't save onDisable() because if you save onDisable() it will get rid of any changes you made to the config by hand

 

Everything is solved. Thanks for everyone who commented and helped me