After reading config from plugin in static - It bugs my plugin

Hey guys.
So i got the following code:

Code:java

    public static Inventory GambleMenu =  Bukkit.createInventory(null, 18, "Gambling Menu");
        static {
            //ItemStacks.
            //FirstPot
                ItemStack Pot1 = new ItemStack(Material.POTION, 1);
                ItemMeta Potion1 = Pot1.getItemMeta();
                Potion1.setDisplayName(plugin.getConfig().getString("FirstPotionName"));
                Potion1.setLore(Arrays.asList(plugin.getConfig().getString("FirstPotionPrice"), ChatColor.RED + "" + ChatColor.BOLD + "40% To win!"));
                Pot1.setItemMeta(Potion1);
 
            //SecondPot
                ItemStack Pot2 = new ItemStack(Material.POTION, 1);
                ItemMeta Potion2 = Pot2.getItemMeta();
                Potion2.setDisplayName(plugin.getConfig().getString("SecondPotionName"));
                Potion1.setLore(Arrays.asList(plugin.getConfig().getString("SecondPotionPrice"), ChatColor.RED + "" + ChatColor.BOLD + "40% To win!"));
                Pot2.setItemMeta(Potion2);
 
            //ThirdPot
                ItemStack Pot3 = new ItemStack(Material.POTION, 1);
                ItemMeta Potion3 = Pot3.getItemMeta();
                Potion3.setDisplayName(plugin.getConfig().getString("ThirdPotionName"));
                Potion1.setLore(Arrays.asList(plugin.getConfig().getString("ThirdPotionPrice"), ChatColor.RED + "" + ChatColor.BOLD + "40% To win!"));
                Pot3.setItemMeta(Potion3);
 
            //4'thPot
                ItemStack Pot4 = new ItemStack(Material.POTION, 1);
                ItemMeta Potion4 = Pot4.getItemMeta();
                Potion4.setDisplayName(plugin.getConfig().getString("FourthPotionName"));
                Potion1.setLore(Arrays.asList(plugin.getConfig().getString("FourthPotionPrice"), ChatColor.RED + "" + ChatColor.BOLD + "40% To win!"));
                Pot4.setItemMeta(Potion4);
 
            //5'thPot
                ItemStack Pot5 = new ItemStack(Material.POTION, 1);
                ItemMeta Potion5 = Pot5.getItemMeta();
                Potion5.setDisplayName(plugin.getConfig().getString("FifthPotionName"));
                Potion1.setLore(Arrays.asList(plugin.getConfig().getString("FifthPotionPrice"), ChatColor.RED + "" + ChatColor.BOLD + "40% To win!"));
                Pot5.setItemMeta(Potion5);
            //6'thPot
                ItemStack Pot6 = new ItemStack(Material.POTION, 1);
                ItemMeta Potion6 = Pot6.getItemMeta();
                Potion6.setDisplayName(plugin.getConfig().getString("SixPotionName"));
                Potion6.setLore(Arrays.asList(plugin.getConfig().getString("SixPotionPrice"), ChatColor.RED + "" + ChatColor.BOLD + "40% To win!"));
                Pot6.setItemMeta(Potion6);
            //7'thPot
                ItemStack Pot7 = new ItemStack(Material.POTION, 1);
                ItemMeta Potion7 = Pot7.getItemMeta();
                Potion7.setDisplayName(plugin.getConfig().getString("SevenPotionName"));
                Potion7.setLore(Arrays.asList(plugin.getConfig().getString("SevenPotionPrice"), ChatColor.RED + "" + ChatColor.BOLD + "40% To win!"));
                Pot7.setItemMeta(Potion7);
            //8'thPot
                ItemStack Pot8 = new ItemStack(Material.POTION, 1);
                ItemMeta Potion8 = Pot8.getItemMeta();
                Potion8.setDisplayName(plugin.getConfig().getString("EightPotionName"));
                Potion8.setLore(Arrays.asList(plugin.getConfig().getString("EightPotionPrice"), ChatColor.RED + "" + ChatColor.BOLD + "40% To win!"));
                Pot8.setItemMeta(Potion8);
                //9Th Pot
                ItemStack Pot9 = new ItemStack(Material.POTION, 1);
                ItemMeta Potion9 = Pot9.getItemMeta();
                Potion9.setDisplayName(plugin.getConfig().getString("NinePotionName"));
                Potion9.setLore(Arrays.asList(plugin.getConfig().getString("NinePotionPrice"), ChatColor.RED + "" + ChatColor.BOLD + "40% To win!"));
                Pot9.setItemMeta(Potion9);
            //PICK1
                ItemStack Pickaxe15 = new ItemStack(Material.DIAMOND_PICKAXE, 1);
                ItemMeta Pick15 = Pickaxe15.getItemMeta();
                Pick15.setDisplayName(plugin.getConfig().getString(ChatColor.RED + "" + ChatColor.BOLD + "15" + ChatColor.DARK_GRAY + "" + ChatColor.BOLD + " Pickaxe"));
                Pick15.setLore(Arrays.asList(plugin.getConfig().getString("PickaxePrice15"), ChatColor.RED + "" + ChatColor.BOLD + "10% To win!"));
                Pickaxe15.setItemMeta(Pick15);
 
                //PICK2
                ItemStack Pickaxe20 = new ItemStack(Material.DIAMOND_PICKAXE, 1);
                ItemMeta Pick20 = Pickaxe20.getItemMeta();
                Pick20.setDisplayName(plugin.getConfig().getString(ChatColor.RED + "" + ChatColor.BOLD + "20" + ChatColor.DARK_GRAY + "" + ChatColor.BOLD + " Pickaxe"));
                Pick20.setLore(Arrays.asList(plugin.getConfig().getString("PickaxePrice20"), ChatColor.RED + "" + ChatColor.BOLD + "10% To win!"));
                Pickaxe20.setItemMeta(Pick20);
 
            //PICK3
                ItemStack Pickaxe25 = new ItemStack(Material.DIAMOND_PICKAXE, 1);
                ItemMeta Pick25 = Pickaxe25.getItemMeta();
                Pick25.setDisplayName(plugin.getConfig().getString(ChatColor.RED + "" + ChatColor.BOLD + "25" + ChatColor.DARK_GRAY + "" + ChatColor.BOLD + " Pickaxe"));
                Pick25.setLore(Arrays.asList(plugin.getConfig().getString("PickaxePrice20"), ChatColor.RED + "" + ChatColor.BOLD + "10% To win!"));
                Pickaxe25.setItemMeta(Pick25);
 
            //PICK4
                ItemStack Pickaxe30 = new ItemStack(Material.DIAMOND_PICKAXE, 1);
                ItemMeta Pick30 = Pickaxe30.getItemMeta();
                Pick30.setDisplayName(plugin.getConfig().getString(ChatColor.RED + "" + ChatColor.BOLD + "30" + ChatColor.DARK_GRAY + "" + ChatColor.BOLD + " Pickaxe"));
                Pick30.setLore(Arrays.asList(plugin.getConfig().getString("PickaxePrice20"), ChatColor.RED + "" + ChatColor.BOLD + "10% To win!"));
                Pickaxe30.setItemMeta(Pick30);
 
            //PICK5
                ItemStack Pickaxe35 = new ItemStack(Material.DIAMOND_PICKAXE, 1);
                ItemMeta Pick35 = Pickaxe35.getItemMeta();
                Pick35.setDisplayName(plugin.getConfig().getString(ChatColor.RED + "" + ChatColor.BOLD + "35" + ChatColor.DARK_GRAY + "" + ChatColor.BOLD + " Pickaxe"));
                Pick35.setLore(Arrays.asList(plugin.getConfig().getString("PickaxePrice20"), ChatColor.RED + "" + ChatColor.BOLD + "10% To win!"));
                Pickaxe35.setItemMeta(Pick35);
 
            //PICK6
                ItemStack Pickaxe40 = new ItemStack(Material.DIAMOND_PICKAXE, 1);
                ItemMeta Pick40 = Pickaxe40.getItemMeta();
                Pick40.setDisplayName(plugin.getConfig().getString(ChatColor.RED + "" + ChatColor.BOLD + "40" + ChatColor.DARK_GRAY + "" + ChatColor.BOLD + " Pickaxe"));
                Pick40.setLore(Arrays.asList(plugin.getConfig().getString("PickaxePrice20"), ChatColor.RED + "" + ChatColor.BOLD + "10% To win!"));
                Pickaxe40.setItemMeta(Pick40);
            //PICK7
                ItemStack Pickaxe45 = new ItemStack(Material.DIAMOND_PICKAXE, 1);
                ItemMeta Pick45 = Pickaxe45.getItemMeta();
                Pick45.setDisplayName(plugin.getConfig().getString(ChatColor.RED + "" + ChatColor.BOLD + "45" + ChatColor.DARK_GRAY + "" + ChatColor.BOLD + " Pickaxe"));
                Pick45.setLore(Arrays.asList(plugin.getConfig().getString("PickaxePrice20"), ChatColor.RED + "" + ChatColor.BOLD + "10% To win!"));
                Pickaxe45.setItemMeta(Pick45);
            //PICK8
                ItemStack Pickaxe50 = new ItemStack(Material.DIAMOND_PICKAXE, 1);
                ItemMeta Pick50 = Pickaxe50.getItemMeta();
                Pick50.setDisplayName(plugin.getConfig().getString(ChatColor.RED + "" + ChatColor.BOLD + "50" + ChatColor.DARK_GRAY + "" + ChatColor.BOLD + " Pickaxe"));
                Pick50.setLore(Arrays.asList(plugin.getConfig().getString("PickaxePrice20"), ChatColor.RED + "" + ChatColor.BOLD + "10% To win!"));
                Pickaxe50.setItemMeta(Pick50);
            //PICK9       
                ItemStack Pickaxe60 = new ItemStack(Material.DIAMOND_PICKAXE, 1);
                ItemMeta Pick60 = Pickaxe60.getItemMeta();
                Pick60.setDisplayName(plugin.getConfig().getString(ChatColor.RED + "" + ChatColor.BOLD + "50" + ChatColor.DARK_GRAY + "" + ChatColor.BOLD + " Pickaxe"));
                Pick60.setLore(Arrays.asList(plugin.getConfig().getString("PickaxePrice20"), ChatColor.RED + "" + ChatColor.BOLD + "10% To win!"));
                Pickaxe60.setItemMeta(Pick60);
            //EndOfItemstacks
                GambleMenu.setItem(0, new ItemStack(Pot1));
                GambleMenu.setItem(1, new ItemStack(Pot2));
                GambleMenu.setItem(2, new ItemStack(Pot3));
                GambleMenu.setItem(3, new ItemStack(Pot4));
                GambleMenu.setItem(4, new ItemStack(Pot5));
                GambleMenu.setItem(5, new ItemStack(Pot6));
                GambleMenu.setItem(6, new ItemStack(Pot7));
                GambleMenu.setItem(7, new ItemStack(Pot8));
                GambleMenu.setItem(8, new ItemStack(Pot9));
                GambleMenu.setItem(9, new ItemStack(Pickaxe15));
                GambleMenu.setItem(10, new ItemStack(Pickaxe20));
                GambleMenu.setItem(11, new ItemStack(Pickaxe25));
                GambleMenu.setItem(12, new ItemStack(Pickaxe30));
                GambleMenu.setItem(13, new ItemStack(Pickaxe35));
                GambleMenu.setItem(14, new ItemStack(Pickaxe40));
                GambleMenu.setItem(15, new ItemStack(Pickaxe45));
                GambleMenu.setItem(16, new ItemStack(Pickaxe50));           
                GambleMenu.setItem(17, new ItemStack(Pickaxe60));       
        }
 

Thats how i set plugin:

Code:java

private static Main plugin;
    @SuppressWarnings("static-access")
    public void CensoredWordProcess(Main plugin) {
    this.plugin = plugin;
    }

So, How can i fix it?
I tested and Im pretty sure that the config causes it.
Thanks in advance,
Tamir

 

Tamir Only make the variable "main" static in your MAIN class, in every other class don't include the static, you can then remove the SuppressWarning.

 

Niknea
Well, I changed it to this in my MAIN class:

Code:java

    private static Main plugin;
    public void CensoredWordProcess(Main plugin) {
    Main.plugin = plugin;
    }
 

Still bugged.

 

Tamir In your main class you don't need to create a constructor like you did. Only in the other classes your trying to get an instance of the main class.

 

Niknea
Well, If i don't, It can't really read "plugin".
EDIT: Nvm, I understood you worng.
SECOND EDIT: Still not working, I tried whatever you told me to.

 

Tamir Can I see your new code?

 

Niknea
I created another class to storage it,

Code:java

 private static InventoryManager plugin = new InventoryManager();
 

It dosen't work, It keeps bugging stuff.
Actully, Intilazer Error.

 

Tamir

Have this in your main class :

Code:java

public static ClassName plugin;

In all the classes you want to get an instance of the main class, add the following:

Code:java

MainClassName plugin;
 
public ClassName(Main plugin){
this.plugin = plugin;
}

 

Potions 1 - 5 have
Potion1.setLore() instead of 1, 2, 3, 4, 5.
That's not the problem but just pointing that out.

 

The problem is that the static initializer invokes plugin.getConfig() before the 'plugin' variable has been initialised, thus 'plugin' is null and a NullPointerException is thrown. There are several ways to fix this, although I recommend getting rid of statics completely, since they violate the main concept of object orientated programming, in my opinion. By the way, utilising an instance initializer block wouldn't make it work either.

 

Tamir
Kind of offtopic but you could make your class from main post (with static constructor) a lot cleaner by:

• Using loops and mapping (instead of pot1,pot2, pot3, etc...)
• Have separate methods for many of these and call these methods in the constructor.

However, as Traks pointed out, you haven't yet initialized your plugin variable ... so it is null -> NPE.

 

Niknea
It gives me an error when i use the command
"An internal error eccourd..."

Code:java

 public static InventoryManager plugin;
 
public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args){
Player player = (Player) sender;
if(commandLabel.equalsIgnoreCase("Gamble")){
// &8&lTh&4&li&8&lef
player.openInventory(plugin.GambleMenu);
 
LivingEntity entity1 = (LivingEntity) player.getWorld().spawnEntity(player.getLocation(), EntityType.VILLAGER);
entity1.setCustomName(ChatColor.DARK_GRAY + "" + ChatColor.BOLD + "Th" + ChatColor.DARK_RED + "" + ChatColor.BOLD + "i" + ChatColor.DARK_GRAY + "" + ChatColor.BOLD + "ef");
 
}
return false;
}
 

Unhandled exception error.

 

Tamir StackTrace please.

 

your ClassName declaration in the main class needs to be initialised or assigned to some value, other wise it will throw null.

in OnEnable add:

Code:java

plugin = this;

Thats one of two approaches you can take. I generally avoid static completly where possible. There are occasions where you will actually need to use them.

 

teozfrank
Its still throwing NPE :l
Edit: It seems like the line

Code:java

            player.openInventory(plugin.GambleMenu);
 

Is bugging it

 

Tamir

Your GambleMenu Inventory is null or uninstantiated. Or your plugin variable.

 

Dragonphase
What can i use instead of null then?

Code:java

    public static Inventory GambleMenu =  Bukkit.createInventory(null, 18, "Gambling Menu"));
 

 

The 'plugin' variable is null, I believe I told you this earlier on in this thread. Just create an instance variable and set its value through a constructor, and pass the active instance of your main class through it. Or if the onCommand method (and 'plugin' variable) is in your main class, use plugin = this.

 

Tamir

You have two closing parentheses at the end of that line.

 

Traks
Tried, Didnt help.
Dragonphase
Its a little mistake that i didnt notice, After i had a problem i fixed it in a second.
But i cant set it to anything else except null
EDIT: If i switch to one class back, How do i define plugin there?

 

Tamir

Pass the plugin by value and make sure it isn't static:

Code:java

private Main plugin;
 
public void CensoredWordProcess(Main plugin){
    this.plugin = plugin;
}

It's best to avoid statics where they aren't necessary.

 

If there is a missing parentheses or not enough the plugin wont even complile you know

 

teozfrank

I know, but it's still better to point it out and make them aware of any mistakes they've made.