Signs with all the lines.

Hello,
I've got this plugin where you can create new signs and set the sign to say something, I'm now trying to make use all the lines the sign has, and I'm stuck!

Example: User types "/signs new <sign name>" to create a sign.
User types "/signs set <sign name> message" to write on the sign.

The problem is the the user can only write on the first line of the sign, and not on all the other lines!

Code:java

public class NamedSigns extends JavaPlugin {
  private static Logger log = Logger.getLogger("Minecraft");
  private static Map<String,Location> signs = new HashMap<String,Location>();
 
  private void usage(Player me) {
    me.sendMessage("Usage: signs new name");
    me.sendMessage("      signs set name message");
  }
 
  private boolean parseArgs(Player me, String [] args) {
    if (args.length < 2) {
      usage(me);
      return false;
    }
    if (args[0].equalsIgnoreCase("new")) {
      return makeNewSign(me, args);
    }
    if (args[0].equalsIgnoreCase("set")) {
      if (args.length < 3) {
        usage(me);
        return false;
      }
      return setSign(me, args);
    }
    return false;
  }
 
  // signs new sign_name
  private boolean makeNewSign(Player me, String [] args) {
    Location loc = me.getLocation();
    loc.setX(loc.getX() + 1); // Not right on top of player
    Block block = loc.getWorld().getHighestBlockAt(loc);
    signs.put(args[1], block.getLocation());
    block.setType(Material.SIGN_POST);
    log.info("Made new sign named " + args[1]);
    return true;
  }
 
  // signs set sign_name line1
  private boolean setSign(Player me, String [] args) {//(6)
    String name = args[1];
    String msg = args[2];
    if (!signs.containsKey(name)) {
      // No such named sign
      me.sendMessage("No sign named " + name);
      return false;
    }
    Location loc = signs.get(name);
    Sign sign = (Sign)loc.getWorld().getBlockAt(loc).getState();
    sign.setLine(0, msg);
    sign.update();
    log.info("Set sign named " + name + " to " + msg);
    return true;
  }
 
  public boolean onCommand(CommandSender sender, Command command,
                          String commandLabel, String[] args) {       
    if (commandLabel.equalsIgnoreCase("signs")) {
      if (sender instanceof Player) {
        Player me = (Player)sender;
        return parseArgs(me, args);
      }
    }
    return false;
  }
}
 

I'm new to HashMaps and stuff, and I would really like you help.

Thanks!

 

kipodu
Line 50 says

Code:

sign.setLine(0, msg);

That's why it's always on line 1. (Because line 0 is line 1, lines 1 is line 2 etc.)

 

DJSkepter
Thanks for the reply, but I think I got misunderstood,
I want this to happen: If the user types in a message that's longer than what 1 line of a sign can display, the rest of his message will go to the other lines on the sign.

 

I would really appreciate if some would try and help,
I'm still stuck with this problem.

 

If the string is longer than one line on a sign (15 characters), just split it into a substring and put that substring on the next line.

 

If you want to split the string nicely on word boundaries, Bukkit provides a handy utility method for this: http://jd.bukkit.org/dev/apidocs/org/bukkit/util/ChatPaginator.html#wordWrap(java.lang.String, int)

Of course, if that returns more than four lines, only copy the first four onto the sign.

 

desht
Hm, I don't really know what to do with it though, but I will try to figure it out!
Thanks!

 

wordWrap() gives you a String array, which could contain any number of lines. You want to copy at most four lines from that array into the sign. Code snippet (untested):

PHP:

// 15 is the max number of characters that will fit on one sign line
String[] lines = ChatPaginator.wordWrap("This is a very long sentence which won't fit on one line of a sign", 15);
for (int i = 0; i < 4 && i < lines.length; i++) {
  sign.setLine(i, lines[i]);
}


Of course this will all get a lot harder in 1.8, where signs can store more than 15 characters per line (the length will be variable, depending on character glyph width), but the above should work fine for 1.7.