Solved BlockBreakEvent issue

I break a block (lapis) which is in the config with its id but when i break it nothing drops.

Error code:

Code:

[13:30:34 ERROR]: Could not pass event BlockBreakEvent to BlockFortune v1.0
org.bukkit.event.EventException
        at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.ja
va:320) ~[custom.jar:git-Bukkit-1.7.2-R0.3-b3020jnks]
        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.jav
a:62) ~[custom.jar:git-Bukkit-1.7.2-R0.3-b3020jnks]
        at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.j
ava:486) [custom.jar:git-Bukkit-1.7.2-R0.3-b3020jnks]
        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.j
ava:471) [custom.jar:git-Bukkit-1.7.2-R0.3-b3020jnks]
        at net.minecraft.server.v1_7_R1.PlayerInteractManager.breakBlock(PlayerI
nteractManager.java:263) [custom.jar:git-Bukkit-1.7.2-R0.3-b3020jnks]
        at net.minecraft.server.v1_7_R1.PlayerInteractManager.a(PlayerInteractMa
nager.java:191) [custom.jar:git-Bukkit-1.7.2-R0.3-b3020jnks]
        at net.minecraft.server.v1_7_R1.PlayerConnection.a(PlayerConnection.java
:548) [custom.jar:git-Bukkit-1.7.2-R0.3-b3020jnks]
        at net.minecraft.server.v1_7_R1.PacketPlayInBlockDig.a(SourceFile:53) [c
ustom.jar:git-Bukkit-1.7.2-R0.3-b3020jnks]
        at net.minecraft.server.v1_7_R1.PacketPlayInBlockDig.handle(SourceFile:8
) [custom.jar:git-Bukkit-1.7.2-R0.3-b3020jnks]
        at net.minecraft.server.v1_7_R1.NetworkManager.a(NetworkManager.java:146
) [custom.jar:git-Bukkit-1.7.2-R0.3-b3020jnks]
        at net.minecraft.server.v1_7_R1.ServerConnection.c(SourceFile:134) [cust
om.jar:git-Bukkit-1.7.2-R0.3-b3020jnks]
        at net.minecraft.server.v1_7_R1.MinecraftServer.u(MinecraftServer.java:6
55) [custom.jar:git-Bukkit-1.7.2-R0.3-b3020jnks]
        at net.minecraft.server.v1_7_R1.DedicatedServer.u(DedicatedServer.java:2
50) [custom.jar:git-Bukkit-1.7.2-R0.3-b3020jnks]
        at net.minecraft.server.v1_7_R1.MinecraftServer.t(MinecraftServer.java:5
45) [custom.jar:git-Bukkit-1.7.2-R0.3-b3020jnks]
        at net.minecraft.server.v1_7_R1.MinecraftServer.run(MinecraftServer.java
:457) [custom.jar:git-Bukkit-1.7.2-R0.3-b3020jnks]
        at net.minecraft.server.v1_7_R1.ThreadServerApplication.run(SourceFile:6
17) [custom.jar:git-Bukkit-1.7.2-R0.3-b3020jnks]
Caused by: java.lang.IllegalArgumentException: No enum constant org.bukkit.Mater
ial.22
        at java.lang.Enum.valueOf(Unknown Source) ~[?:1.7.0_51]
        at org.bukkit.Material.valueOf(Material.java:64) ~[custom.jar:git-Bukkit
-1.7.2-R0.3-b3020jnks]
        at com.bwfcwalshy.blockfortune.FortuneBlock.onBreak(FortuneBlock.java:27
) ~[?:?]
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.7.0
_51]
        at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.7.0
_51]
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1
.7.0_51]
        at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.7.0_51]
        at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.ja
va:318) ~[custom.jar:git-Bukkit-1.7.2-R0.3-b3020jnks]

code:

Code:java

@EventHandler
public void onBreak(BlockBreakEvent e){
Player player = e.getPlayer();
@SuppressWarnings("deprecation")
int blockid = e.getBlock().getTypeId();
String sblockid = String.valueOf(blockid);
 
if (player.hasPermission("blockfortune.use")){
if(player.getGameMode().equals(GameMode.SURVIVAL)) {
if(Main.pl.getConfig().getIntegerList("BlockIds").contains(Integer.valueOf(blockid))){
if(player.getItemInHand().containsEnchantment(Enchantment.LOOT_BONUS_BLOCKS)){
int fortune = player.getItemInHand().getEnchantmentLevel(Enchantment.LOOT_BONUS_BLOCKS);
e.getBlock().setType(Material.AIR);
e.getBlock().getDrops().clear();
Material bId = Material.valueOf(sblockid);
ItemStack drops = new ItemStack(bId, fortune);
player.getWorld().dropItem(e.getBlock().getLocation(), drops);
}
}
}
   }
}
}
}

and yes i have registered the listener

 

NEVER use IDs anymore. Use material names.
It is saying there is no Material.22.
There IS a Material.LAPIS_BLOCK
So do Material.getMaterialById(22)

 

bwfcwalshy
You are using Material.valueOf(); which needs the Material name, not the material ID.

 

Ok so my new code is this:

Code:java

package com.bwfcwalshy.blockfortune;
 
import org.bukkit.GameMode;
import org.bukkit.Material;
import org.bukkit.enchantments.Enchantment;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.BlockBreakEvent;
import org.bukkit.inventory.ItemStack;
 
public class FortuneBlock implements Listener{
 
    @EventHandler
    public void onBreak(BlockBreakEvent e){
        Player player = e.getPlayer();
        @SuppressWarnings("deprecation")
        int blockid = e.getBlock().getTypeId();
        String sblockid = String.valueOf(blockid);
 
        if (player.hasPermission("blockfortune.use")){
            if(player.getGameMode().equals(GameMode.SURVIVAL)) {
                if(Main.pl.getConfig().getIntegerList("BlockIds").contains(Integer.valueOf(blockid))){
                    if(player.getItemInHand().containsEnchantment(Enchantment.LOOT_BONUS_BLOCKS)){
                        int fortune = player.getItemInHand().getEnchantmentLevel(Enchantment.LOOT_BONUS_BLOCKS);
                        e.getBlock().setType(Material.AIR);
                        e.getBlock().getDrops().clear();
                        Material bId = Material.getMaterial(sblockid);
                        ItemStack drops = new ItemStack(bId, fortune);
                        player.getWorld().dropItem(e.getBlock().getLocation(), drops);
                    }
                }
            }
        }
    }
}

But it still isn't working, do i need to change the config?

xmarinusx MCMastery know how to fix it?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

bwfcwalshy
Yes, the problem is in the sblockid object. sblockid should be the name of the material.

 

xmarinusx how would i fix it? what should the line be? Material needs a id and the id is blockid.

 

bwfcwalshy
Just change 'Material bId = Material.getMaterial(sblockid);'
to
'Material bID = e.getBlock().getType();'

 

bwfcwalshy BTW the e.getBlock().setMaterial(Material.AIR) I don't think it does anything, since the event says it was broken anyway

 

It does do something though, it will remove the block before the server does actually count it as a block break, so no items will be dropped etc.

 

Ok thats fixed now its just a issue of it wont set it to Air
Line causing issue

Code:java

e.getBlock().setType(Material.AIR);

MCMastery if i remove it both the fortune ones and the normal block drop as 2 seperate drops and bug out.

xmarinusx any ideas how to fix it?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Bump

So what is the issue now, well when i remove this line: e.setBlock().setType(Material.AIR); it drops 2 different item stacks it drops the fortune one and the one from the block originally problem is 1.it looks weird 2.it bugs out. When i add the line it doesn't drop anything. Need help!

 

It looks like you're setting the block to AIR before getting the drops. Just move the line all the way to the bottom of the event.

 

xmarinusx Worked. Is there a way for it to randomly pick how many blocks?

So for example Fortune 1: 2-5, Fortune 2: 3-7, Fortune 5-12
Any way to do that and set it in the config?

 

bwfcwalshy
You can create a random integer using:

Code:java

 
Random rand = new Random();
int i = rand.nextInt(max);
 

'max' will be the max value of the random integer, exclusive. So if max = 10, i will be max 9. I hope that makes sense

 

xmarinusx ok is there a way to set minimum? and for different fortunes?

 

There's no method which uses minimum, but you can do it yourself. If you want a minimum of 3, just add 3 to the integer and make the max 3 less.

Different fortunes can be achieved in different ways, depending on how you want it. You could e.g. use if checks, or you could add the fortune level to the min/max. I'm sure you can create an algorythm for it yourself.