Get all online players with permission

Hey all, I was developing a plugin called BossMessage, and I faced a problem: I need to get all online players with a permission node. EX:

Code:java

        List<Player> output = new ArrayList<Player>();
        for (Player player : Bukkit.getOnlinePlayers()) {
            if (player.hasPermission("my.permission.node") {
                output.add(player);
            }
        }
        return output;

But is there a better way of doing it, without having to go through every single player that is online, and checking if he has that permission? And does BukkitAPI already have a method for that, or do I have to implement it myself? Please reply if you have any info about it. Thanks.

 

Considering that the CB method for sending a message to all players with a permission does just this, i'd say no.

Regardless, internally if they had a way to do this, it would likely be functionally identical to this.

 

This. Your code isn't hacky and doesn't look hacky (to me)

 

Paradrakor I agree.
victor2748 I think ur code is right, but just a correction, don't use player object in maps/lists ect. Or if you do make sure you dispose it properly on disconnect and on server restart/shut Down ect...

 

victor2748

Your code is fine.

 

You need an O(n) time complexity because you need to verify every single player on the server. So, logically, checking each player once would be the most efficient (which you've done).