Solved More Config help :)

Hi, so I am creating a plugin so if a Player has more than or equal to 100 points, they get leveled up. The only thought I had to check if the player had more than 100 points was to check every time a Player moved. Any ideas on how to check if the player has more than 100 points without having to check every time?

Back on topic, I get an NPE on line 13 of the Update class

Here is my code:

Code:java

package org.zodiactheories.pandorm;
 
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerMoveEvent;
 
public class Update implements Listener {
 
    @EventHandler
    public void onMove(PlayerMoveEvent e) {
        Player p = e.getPlayer();
        if(Core.getInstance().getConfig().getInt("players." + p.getName() + ".points") >= 100) {
            LevelMethods.levelup(p);
        }
    }
 
}

JoinEvent:

Code:java

package org.zodiactheories.pandorm;
 
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerJoinEvent;
 
public class JoinEvent implements Listener {
 
    @EventHandler
    public void onJoin(PlayerJoinEvent e) {
        Player p = e.getPlayer();
        LevelMethods.setLevel(p, 0);
        LevelMethods.setPoints(p, 0);
        Core.getInstance().getConfig().set("players." + p.getName(), ".level" + LevelMethods.getLevel(p));
        Core.getInstance().getConfig().set("players..level.points", LevelMethods.getPoints(p));
    }
}

Thanks

 

Or, you can schedule an event that goes every minute and checks.

edit: You're getting an NPE because you didn't check if the player is even in the config.

 

Try checking if such a field exists in the config before trying to access it.

Code:java

if (!Core.getInstance().contains("players." + p.getName() + ".points")) {
    Core.getInstance().getConfig().createSection("players." + p.getName() + ".points");
}
 
// continue code as normal

 

ZodiacTheories
Check when they receive the points the total amount is 100 or more than level up (If they aren't already)

 

Gater12
Just as a note, you don't need to tahg people on their own threads. They automatically are watched unless explicitly un-watched.

 

rohan576

Not true actually.

 

ZodiacTheories
What are you talking about? He's right.

 

rohan576 Gater12 hankered

Still getting an NPE on line 13 of Update

Code:java

package org.zodiactheories.pandorm;
 
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerMoveEvent;
 
public class Update implements Listener {
 
    @EventHandler
    public void onMove(PlayerMoveEvent e) {
        Player p = e.getPlayer();
        if (!Core.getInstance().getConfig().contains("players." + p.getName() + ".points")) {
            Core.getInstance().getConfig().createSection("players." + p.getName() + ".points");
        }
        if(Core.getInstance().getConfig().getInt("players." + p.getName() + ".points") >= 100) {
            LevelMethods.levelup(p);
        }
    }
 
}

Code:java

package org.zodiactheories.pandorm;
 
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerJoinEvent;
 
public class JoinEvent implements Listener {
 
    @EventHandler
    public void onJoin(PlayerJoinEvent e) {
        Player p = e.getPlayer();
        LevelMethods.setLevel(p, 0);
        LevelMethods.setPoints(p, 0);
        if (!Core.getInstance().getConfig().contains("players." + p.getName() + ".points")) {
            Core.getInstance().getConfig().createSection("players." + p.getName() + ".points");
        }
        Core.getInstance().getConfig().set("players." + p.getName(), ".level" + LevelMethods.getLevel(p));
        Core.getInstance().getConfig().set("players..level.points", LevelMethods.getPoints(p));
    }
}
 

hankered

Well not for me then, I didn't get an alert when either of you posted, and I haven't explicitly unwatched all my threads

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

You really shouldn't be storing players as an object.

Use their names.

 

Either Core#getInstance() or Core#getConfig() return null. What is the source code of the Core class? Also, please pass an instance of your Core class to a custom constructor (in Update and JoinEvent), which requires a Core object, instead of invoking static methods.

 

What's your setLevel method? I think I know why.

 

Traks hankered

Code:java

package org.zodiactheories.pandorm;
 
import org.bukkit.entity.Player;
 
public class LevelMethods {
 
    public static int getLevel(Player p) {
        return Core.getInstance().getConfig().getInt("players." + p.getName() + ".level");
    }
 
    public static void setLevel(Player p, int level) {
        Core.getInstance().getConfig().set("players." + p.getName(), ".level" + level);
        return;
    }
 
    public static int getPoints(Player p) {
        return Core.getInstance().getConfig().getInt("players." + p.getName() + ".points");
    }
 
    public static void setPoints(Player p, int points) {
        Core.getInstance().getConfig().set("players." + p.getName(), ".points" + points);
        return;
    }
 
    public static void levelup(Player p) {
        setLevel(p, getLevel(p) + 1);
        return;
    }
}

Core class:

Code:java

package org.zodiactheories.pandorm;
 
import org.bukkit.ChatColor;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Core extends JavaPlugin {
 
    public final String PREFIX = ChatColor.GOLD + "" + ChatColor.BOLD + "[Pandorm]";
 
    private static Core instance;
 
    public static Core getInstance() {
        return instance;
    }
 
    @Override
    public void onEnable() {
        getConfig().options().copyDefaults(true);
        saveConfig();
        getServer().getPluginManager().registerEvents(new JoinEvent(), this);
        getServer().getPluginManager().registerEvents(new King(), this);
        getServer().getPluginManager().registerEvents(new Update(), this);
        getCommand("king").setExecutor(new King());
        getCommand("level").setExecutor(new King());
    }
}

 

When in doubt, null check everything.
You know you are doing methods on something that is null on that line, why not do some debug?

 

ZodiacTheories
You never assigned instance variable to any reference thus it is null.

 

Gater12

Ah, I ALWAYS forget that

Gater12

Thanks a lot!

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Yeah, in your setLevel method, you concatenate their level to the path name, eg:
players.rohan576.level1337

Therefore, as you figured out, you should get players.player.level and use setInt(int).