Wither chance of dropping problem

Code:java

 @EventHandler
    public void onEntityDeath(EntityDeathEvent e) {
            if (e.getEntity() instanceof Wither) {
                Random random = new Random();
 
                ItemStack witherbow = new ItemStack(Material.BOW, 1);
                witherbow.addUnsafeEnchantment(Enchantment.ARROW_DAMAGE, 5);
                witherbow.addUnsafeEnchantment(Enchantment.ARROW_FIRE, 1);
                witherbow.addUnsafeEnchantment(Enchantment.ARROW_INFINITE, 1);
                ItemMeta itemMeta = witherbow.getItemMeta();
                itemMeta.setDisplayName("§lWither Bow");
                itemMeta.setLore(Arrays.asList("§bRare"));
                witherbow.setItemMeta(itemMeta);
                int Chance = random.nextInt(3);
                if(Chance == 1) {
                    e.getDrops().clear();
                    e.getEntity().getWorld().dropItem(e.getEntity().getLocation(), witherbow);
                }
                if(Chance > 1) {
                    e.getDrops().clear();
                    e.getEntity().getWorld().dropItem(e.getEntity().getLocation(), new ItemStack(Material.NETHER_STAR));
                }
            }
    }
 
}
 

This is the code, whenever I kill a wither it only drops a netherstar, I have tried removing the nether star but it still only drops it. There is no stacktrace but it still doesn't work, any ideas?

 

Ur code looks nice, r u registering events?

 

I have all my events registered in the main class

 

xxPatterson
Random of 3 is exclusive of 3. So possible outcomes are: 0,1,2.

 

xxPatterson

Code:java

random.nextInt(3) 

generates a random number that can be 0, 1 or 2. So, there's a chance that your code doesn't run (when it's 0).
And you should only create the bow if the chance is equal to 1:

Code:java

 if(Chance == 1) {
ItemStack witherbow = new ItemStack(Material.BOW, 1);
witherbow.addUnsafeEnchantment(Enchantment.ARROW_DAMAGE, 5);
witherbow.addUnsafeEnchantment(Enchantment.ARROW_FIRE, 1);
witherbow.addUnsafeEnchantment(Enchantment.ARROW_INFINITE, 1);
ItemMeta itemMeta = witherbow.getItemMeta();
itemMeta.setDisplayName("§lWither Bow");
itemMeta.setLore(Arrays.asList("§bRare"));
witherbow.setItemMeta(itemMeta);
e.getDrops().clear();
e.getEntity().getWorld().dropItem(e.getEntity().getLocation(), witherbow);
}

 

Code:java

    @EventHandler
    public void onEntityDeath(EntityDeathEvent e) {
            if (e.getEntity() instanceof Wither) {
                Random random = new Random();
 
                ItemStack witherbow = new ItemStack(Material.BOW, 1);
                witherbow.addUnsafeEnchantment(Enchantment.ARROW_DAMAGE, 5);
                witherbow.addUnsafeEnchantment(Enchantment.ARROW_FIRE, 1);
                witherbow.addUnsafeEnchantment(Enchantment.ARROW_INFINITE, 1);
                ItemMeta itemMeta = witherbow.getItemMeta();
                itemMeta.setDisplayName("§lWither Bow");
                itemMeta.setLore(Arrays.asList("§bRare"));
                witherbow.setItemMeta(itemMeta);
                int Chance = random.nextInt(3) + 1;
                if(Chance == 1) {
                    e.getDrops().clear();
                    e.getEntity().getWorld().dropItem(e.getEntity().getLocation(), witherbow);
                }
                if(Chance > 1) {
                    e.getDrops().clear();
                    e.getEntity().getWorld().dropItem(e.getEntity().getLocation(), new ItemStack(Material.NETHER_STAR));
                }
            }
    }
 
}
 

Fixed that and still only receive nether star drop

 

xxPatterson
Try adding debug lines to make sure the event actually fires when the wither dies.

Show Spoiler Hide Spoiler

Debug lines are simply messages that print out some message saying that the lock of code they're put in actually fires

 

Code:java

@EventHandler
    public void onEntityDeath(EntityDeathEvent e) {
            if (e.getEntity() instanceof Wither) {
                Random random = new Random();
                Bukkit.broadcastMessage("Plugin Works");
                ItemStack witherbow = new ItemStack(Material.BOW, 1);
                witherbow.addUnsafeEnchantment(Enchantment.ARROW_DAMAGE, 5);
                witherbow.addUnsafeEnchantment(Enchantment.ARROW_FIRE, 1);
                witherbow.addUnsafeEnchantment(Enchantment.ARROW_INFINITE, 1);
                ItemMeta itemMeta = witherbow.getItemMeta();
                itemMeta.setDisplayName("§lWither Bow");
                itemMeta.setLore(Arrays.asList("§bRare"));
                witherbow.setItemMeta(itemMeta);
                int Chance = random.nextInt(3) + 1;
                if(Chance == 1) {
                    e.getDrops().clear();
                    e.getEntity().getWorld().dropItem(e.getEntity().getLocation(), witherbow);
                }
                if(Chance > 1) {
                    e.getDrops().clear();
                    e.getEntity().getWorld().dropItem(e.getEntity().getLocation(), new ItemStack(Material.NETHER_STAR));
                }
            }
    }
 
}
 

I added a debug line and it turns out it isn't broadcasting anything when the wither is killed

 

xxPatterson Broadcast the message outside of instanceof if statement to see if your event is even firing. If not, then you need to register your events. And if you did, double check to make sure. If you could post code of where you registered your events then we could help.