Muting Chat Isn't Working

I can never seen to get this thing right, my mute chat NEVER works hopefully one of you can help out. No errors or nothing, just wont work.

Code:java

package com.MrBJC412.bServer;
 
import java.util.ArrayList;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.World;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.AsyncPlayerChatEvent;
import org.bukkit.event.player.PlayerJoinEvent;
import org.bukkit.event.server.ServerListPingEvent;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Main extends JavaPlugin implements Listener{
 
    private boolean chatDisabled = false;
    public ArrayList<String> worlds = new ArrayList();
 
    public void onEnable() {
        Bukkit.getPluginManager().registerEvents(this, this);
    }
 
    public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String [] args ) {
        Player p = (Player) sender;
        if(cmd.getName().equalsIgnoreCase("mutechat")) {
            if(p.hasPermission("Basic.mutechat")) {
                this.worlds.removeAll(this.worlds);
 
                this.chatDisabled = false;
                Bukkit.broadcastMessage(ChatColor.RED + "Chat has been muted!");
                return true;
            }
        }
        if(cmd.getName().equalsIgnoreCase("unmutechat")) {
            if(p.hasPermission("Basic.unmutechat")) {
                this.chatDisabled = true;
                Bukkit.broadcastMessage(ChatColor.RED + "Chat has been unmuted!");
            }
        }
        return false;
    }
 
 
    @EventHandler
    public void onChat(AsyncPlayerChatEvent e) {
        Player p = e.getPlayer();
        World w = p.getWorld();
        String world = w.toString();
        if (((this.chatDisabled) || (this.worlds.contains(world))) &&
                  (!p.hasPermission("mchat.bypass")))
                {
                  e.setCancelled(true);
                }
              }
 

 

BJCxMC if you wanna get the name of the world the player is in, then you will need to call w.getName();

 

All that did was give me an error in console while loading the plugin.

 

BJCxMC did you add anything else to the code than that? Because it seems to have trouble finding the main class

 

All I changed was this:

Code:java

 String world = w.toString();

to:

Code:java

String world = w.getName();

 

BJCxMC it seems quite odd because that piece of code doesn't even get executed at that point. Are you sure you didn't modify the plugin.yml or change anything other in your IDE/workspace than that piece of code?

 

I dun know if its the cause, but you don't need a method onDisable() ? Even if it's empty

 

BJCxMC

Check your plugin.yml, check for that class, you could of changed one little letter.

 

BJCxMC
Bukkit says that that class doesn't exist, try checking to make sure it's exporting correctly, and the fully-qualified name is typed EXACTLY in the plugin.yml.

Now, about the name. The package name should be all lower case, and you shouldn't begin it with a domain name you don't own, i.e. unless you own mrbjc412.com, you shouldn't use that as a package name (alternative: me.mrbjc412.bserver.Main as the fully-qualified name).

Next, about your variables. There is no reason (at least, in the code that you have shown us) that you have the toString() value of worlds stored, and you shouldn't be storing the toString() value of worlds anyways, use the UUID of the world, World#getUid() I believe it is.

Finally, you can't just use Player#hasPermission(String) in an async method (in this case, onChat()). You must make the call thread safe, I've described one method for doing so here: http://forums.bukkit.org/threads/real-quick-asyncplayerchatevent-question.288386/#post-2637595

 

caderape Your main: in your plugin.yml is pointing to a non-existant JavaPlugin extended class

EDIT: Ninja'D

 

Okay I fixed the error, but I can still chat when it's supposed to be muted, heres a picture.
http://gyazo.com/d14425064859f61d023447c1958d9112
**The code has already been posted for new viewers**

 

Make lines 53-54 each separate if statements and add different behaviour for each to determine where your code is failing, also see my post above.

 

BJCxMC you need to swap the two true and false in the onCommand