Solved Block Regeneration

Hi there everyone!
So, i need to make a system that regenerates resources is a place that they are limited, something similar to annihilation where you break, for example a log and the log is replaced by air, goes to your inventory, gives you exp and then run a timer that in a time of 3 or 4 seconds the block magicaly appears again! My code seams prety logic to me, thats why i can't solve this problem beacause what happens is that every thing goes right until the part when the runnable comes into play and the log just does not apear any more
Here is some of my code...

Code:java

@EventHandler
    public void OnBlockBreak(BlockBreakEvent event){
        Player player = event.getPlayer();
        final Block block = event.getBlock();
 
        if(block.getType().equals(Material.LOG)){
            block.getDrops().clear();
            ItemStack Log = new ItemStack (Material.LOG);
            player.getInventory().addItem(Log);
            block.setType(Material.AIR);
            player.giveExp(2);
            new BukkitRunnable(){
                public void run(){
                    block.setType(Material.LOG);
                }
            }.runTaskLater(plugin, 600L);
        }
}

Please anwser i realy need help with this...
Telmovieira

PS: This is in a different class other than the main one of the plugin.
And another thing... Events are registered and Listener is implemented...(I am not an idiot...).

 

Don't you need to cancel the event?

 

Telmovieira You putted 600l it means 30 seconds, nothing appears after this time?
And cancel the event at first

 

Your problem is likely in the fact that you can't store an instance of a Block, it just doesn't work. Read the JavaDocs on Block for why it isn't possible and what the proper alternative is (BlockState).

 

HungerCraftNL, CynutsBR and mythbusterma
Thank you very much for your sugestions i will try them i will give some feedback if it worked or not!

@mythbusterma
Could you write some pseudo code for me to have an ideia of what i should, like, should i use Hash maps and those sorts of things....

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Just use BlockState instead of Block in your code, Block has a getState() method for this, and you can call BlockState#update(boolean) Medford for changing the block to the BlockState's state.

 

mythbusterma
I was able to make it so the block appeared again using the block state, showing that the problem resides in the bukkit runnable.... Could you give me some assistance with that?
Here is the updated code:

Code:java

@EventHandler
public void OnBlockBreak(BlockBreakEvent event){
Player player = event.getPlayer();
final BlockState block = event.getBlock().getState();
if(block.getType().equals(Material.LOG)){
event.setCancelled(true);
block.getBlock().getDrops().clear();
ItemStack Log = new ItemStack (Material.LOG);
player.getInventory().addItem(Log);
block.setType(Material.AIR);
player.giveExp(2);
new BukkitRunnable(){
public void run(){
block.setType(Material.LOG);
}
}.runTaskLater(plugin, 600L);
}
}

Thank you in advance!

 

Doing BlockState#setType(Material) does nothing, it only changes the BlockState, not the actual Block in the world. You need to use update(boolean) like I said before....

 

In the run method, use block.update(true); instead of block.setType(Material.LOG);

 

mythbusterma endoml
Good news! I found out what the problem was... Bad news, I don't know how to solve it
The bukkt runnable does not work because of a IllegalArgumentException: Plugin cannot be null
I researched about it and the solutions i found said to use this.plugin = this in the onEnable() and other stuff in the Listener class like putting a constructor in there, etc.... In summary i did EVERYTHING in my reach and keeps throwing the goddam exception over and over again!
I am starting to panic here and i realy need some help!
There is all the code you need to do so... If you need more I will provide it to you

Part of the BlockListener class including the event and the constructor:

Code:java

public class BlockListener implements Listener {
 
    public Main plugin;
 
    public BlockListener(Main instance){
            instance = plugin;
        }
 
 
    @EventHandler
    public void OnBlockBreak(BlockBreakEvent event) {
        Player player = event.getPlayer();
        final BlockState block = event.getBlock().getState();
        if (block.getType().equals(Material.LOG)) {
            event.setCancelled(true);
            block.getBlock().getDrops().clear();
            ItemStack Log = new ItemStack(Material.LOG);
            player.getInventory().addItem(Log);
            block.setType(Material.AIR);
            block.update(true);
            player.giveExp(2);
            new BukkitRunnable() {
                public void run() {
                    block.update(true);
                }
            }.runTaskLaterAsynchronously(plugin, 100L);//Error is thrown here...
 
        }
}

OnEnable and listener constructors:

Code:java

public class Main extends JavaPlugin implements Listener {
    public final Logger logger = Logger.getLogger("Minecraft");
    public Main plugin;
    public boolean freeze = false;
    public final PlayerListener pl = new PlayerListener();
    public final BlockListener bl = new BlockListener(this);
    public final SoulboundListeners sl = new SoulboundListeners();
    public final Domination dom = new Domination();
    public int onlinePlayers = Bukkit.getOnlinePlayers().length;//Don't mind this
    public int number = 10;//Don't mind this
    public Scoreboard timerBoard = null;//Don't mind this
    public Objective timerObj = null;//Don't mind this
 
      @Override
    public void onEnable() {
        PluginDescriptionFile pdfFile = this.getDescription();
        this.logger.info(pdfFile.getName() + " Version " + pdfFile.getVersion()
                + "Has been enabled");
        this.plugin = this;
        PluginManager pm = getServer().getPluginManager();
        pm.registerEvents(this.pl, this);
        pm.registerEvents(this.bl, this);
        pm.registerEvents(this.sl, this);
        pm.registerEvents(this.dom, this);
        pm.registerEvents(this, this);
        this.getServer().getPluginManager().registerEvents(this, this);
        me.Telmovieira.Liberatum.Team.clearTeams();
        ScoreboardManager sbManager = Bukkit.getScoreboardManager();
        for (Player p : Bukkit.getOnlinePlayers()) {
            p.setScoreboard(sbManager.getNewScoreboard());
            p.setDisplayName(ChatColor.RESET + p.getName());
            p.setPlayerListName(ChatColor.RESET + p.getName());
        }
        GameState.setState(GameState.IN_LOBBY);
        Runtime.getRuntime().traceInstructions(false);//Don't mind this
        Runtime.getRuntime().traceMethodCalls(false);//Don't mind this
                //Desableing stack traces reduces lag... of course they are enabled when i am developing the plugin...
 
 
    }

I am hopping you give me an answer soon

Thank you once again!

 

Try To Use This Code

Code:java

  //The BlockBreak Event
  @EventHandler
  public void breakingBlock(BlockBreakEvent event) {
      Block b = event.getBlock();
          //Material
      if(b.getType() == Material.LOG) {
          // Block Regeneration
      final BlockState restorePoint = event.getBlock().getState();
      Bukkit.getServer().getScheduler().scheduleSyncDelayedTask(this.plugin, new Runnable() {
          public void run() {
      restorePoint.update(true, false);
          }
          }, 320L);
                  //320L = 15 Seconds
  }
  }
}
 

 

I think the problem is that you are not initializing the plugin variable, but I'm not sure.

 

Telmovieira

DON'T EVER DO THIS ASYNCHRONOUSLY, IT IS NOT SAFE. Use synchronous methods instead.

Second, you're trying to update it to air again, which isn't going to do anything, you need to update it to a log.

Third, all of your instance variables should be private, not public.

Fourth, the assignment in the constructor is going the wrong way, so you're setting a temporary value to null, and not the other way around.

 

mythbusterma
Thx for the help but what do you mean by the assignment in the constructor is going the wrong way?

Sorry for the inconvinence...

 

Should be "plugin = instance" not the other way around.

 

Ok thx

It worked.... Finaly!
Thank you so much for your help!!!

EDIT by Moderator: merged posts, please use the edit button instead of double posting.