Solved Get dyed armor color

Hi! I want to get a armors color. There are several posts in Bukkit but I haven't found the solution. This is what I have tryed

Code:java

          if (e.getCurrentItem () == new ItemStack(Material.LEATHER_HELMET)){
              if (e.getCurrentItem().getItemMeta().getColor() == Color.RED)){
 
              }

Thx

 

galaipa
Well duh that's not going to work. You are checking if the color is red then you aren't doing anything with it! You aren't even printing or anything.

 

galaipa, I'm confused as to what you're looking for. Do you want to dye the armor or check if the armor is a certain color?
Never the less, I'd use .equals() instead of ==

 

AoH_Ruthless I know Its not working. I check it adding a log.info. I removed it to post it here.
RAFA_GATO_FOFO I want to check it yes

 

RAFA_GATO_FOFO Enum#equals() calls ==, so use == to be null-safe
galaipa Have you tried casting the ItemMeta to LeatherArmorMeta?

 

xTigerRebornx
If you mean this, is not working

Code:java

          else if (e.getCurrentItem().getType() == Material.LEATHER_HELMET){
              LeatherArmorMeta leather = (LeatherArmorMeta) e.getCurrentItem().getItemMeta();
                if (leather.getColor() == Color.RED){
                    player.sendMessage("Gorria");
                }
    }

 

galaipa What about it doesn't work? Does it throw errors? Does it not execute?

 

xTigerRebornx
No errors. It dosn't do anything.

 

Debug your plugin to see, what if statement cause false.

 

Zupsub Sorry I don't know how to debug it

 

galaipa I would first off make sure that that else if statement is being hit. If you are debugging this piece of code, make sure the prior if statement(s) return false so that this code is hit. You could also just comment them out for the time being. Then, like xTigerRebornx, suggested, I would change the

Code:java

else if (e.getCurrentItem().getType() == Material.LEATHER_HELMET)
{
}

to:

Code:java

else if (e.getCurrentItem().getType().equals(Material.LEATHER_HELMET))
{
}

and the

Code:java

if (leather.getColor() == Color.RED)
{
}

to:

Code:java

if (leather.getColor().equals(Color.RED))
{
}

That will ensure the a logically correct return from those statements, and I am not saying that what you did was wrong, but it can return something that you would not expect. Also, it is just overall better code.

The next thing I would do to debug is add an else statement after your inner if statement that just sends a message to the player to let you know that the inner if statement returned false. It is good to know that the inner statement is being hit and if it is, you can assume that your above code is working properly, but if you don't get a message then you can assume that your prior code is not working properly. So, doing that would look something like this:

Code:java

if (leather.getColor() == Color.RED)
{
player.sendMessage("Your item is a leather helmet and it is red!");
}
else
{
player.sendMessage("Your item is a leather helmet, but it is not red!");
}

Then, just to be proper and so you get results for any situation I would add an else statement to the outer if statement as well. That would look like this:

Code:java

else if (e.getCurrentItem().getType() == Material.LEATHER_HELMET)
{
 
}
else
{
player.sendMessage("Your item is not a leather helmet!");
}

Give these changes a try and let me know the results. I don't expect this to fix your problem, but it should help you find where your plugin is screwing up. If you cannot find the problem, post more of your code here and tell me the results of what I suggested. Good luck !

- Np15isntboss

 

np15isntboss you are misquoting xTigerRebornx
You don't need to equals() an enum, == works and is null-safe.

 

Necrodoom My mistake, I see where I am wrong when it comes to that, but I still endorse the other things I said in order to help debug.

 

np15isntboss Zupsub Necrodoom xTigerRebornx
Here is the code:

Code:java

          else if (e.getCurrentItem().getType() == Material.LEATHER_HELMET){
              player.sendMessage("Helmet yes");
              LeatherArmorMeta leather = (LeatherArmorMeta) e.getCurrentItem().getItemMeta();
                if (leather.getColor() == Color.RED){
                    player.sendMessage("Red helmet yes");
                }else {
                    player.sendMessage("Red helmet no");
                }
 
          }

And the result is:
-Helmet yes, Red helmet no
So something is wrong here

Code:java

              LeatherArmorMeta leather = (LeatherArmorMeta) e.getCurrentItem().getItemMeta();
                if (leather.getColor() == Color.RED){

Thanks to everybody

 

Print out what getColor returns instead.

 

Zupsub
It returns: Color: [rgb0x993333]

 

galaipa Use http://jd.bukkit.org/rb/doxygen/d2/...eColor.html#abb385516d88544669358ede553d1d5ef to get a DyeColor, then try comparing that to the DyeColor that you want

 

xTigerRebornx
I used this from your link but I dont know why It dosn't work.

Code:java

leather.getColor() == Color.fromRGB(0x993333)

 

galaipa You didn't use the method that was shown by that link.
Use DyeColor#getByColor() and compare that to the DyeColor you want (or just call DyeColor#getByColor() on Color.RED and compare the converted DyeColor to that)

 

@xTigerReborn
Sorry but I dont understand how can I get the dye color.

xTigerRebornx
Code fixed!
Here is the final code:

Code:java

          else if (e.getCurrentItem().getType() == Material.LEATHER_HELMET){
              LeatherArmorMeta leather = (LeatherArmorMeta) e.getCurrentItem().getItemMeta();
              Color kolorea =  Color.fromRGB(0x993333);
              Color kolorea2 = leather.getColor();
                if  (kolorea2.equals(kolorea)){
                    player.sendMessage("Red helmet yes");
                }else{
                    player.sendMessage("Red helmet no");
                    Color a = leather.getColor();
 
                }
 
          }

Thanks to everybody

EDIT by Moderator: merged posts, please use the edit button instead of double posting.