Subtract money from a player when they're killed?

I have coded this class and i can get the player kills another player money and the message comes up but when the other player dies their money is not taken away.

Code:java

package me.max;
 
import net.milkbowl.vault.economy.Economy;
import net.milkbowl.vault.economy.EconomyResponse;
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.PlayerDeathEvent;
import org.bukkit.plugin.RegisteredServiceProvider;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Eco extends JavaPlugin implements Listener {
 
    public static Economy econ = null;
    public static EconomyResponse r;
 
    public void onEnable() {
        if (!setupEconomy() ) {
            getLogger().severe(String.format("[%s] - Disabled due to no Vault dependency found!", getDescription().getName()));
            getServer().getPluginManager().disablePlugin(this);
            return;
        }
 
        getLogger().info("Plugin has been enabled!");
        Bukkit.getServer().getPluginManager().registerEvents(this, this);
    }
 
    private boolean setupEconomy() {
        if (getServer().getPluginManager().getPlugin("Vault") == null) {
            return false;
        }
        RegisteredServiceProvider<Economy> rsp = getServer().getServicesManager().getRegistration(Economy.class);
        if (rsp == null) {
            return false;
        }
        econ = rsp.getProvider();
        return econ != null;
    }
 
    @EventHandler
    public void onPlayerDeath(PlayerDeathEvent e) {
        Player p = e.getEntity().getKiller();
 
        if (e.getEntity().getKiller() instanceof Player) {
 
            r = econ.depositPlayer(p.getName(), 5.00);
            if (r.transactionSuccess()) {
                p.sendMessage(ChatColor.GREEN + "You have recived 5 coins.");
                return;
            }
            else {
                p.sendMessage(ChatColor.RED + "An error occured when paying out your money. Please contact a server admin.");
                return;
            }
        }
 
        r = econ.withdrawPlayer(p.getName(), 5.00);
        if (r.transactionSuccess()) {
            p.sendMessage(ChatColor.DARK_RED + "5 coins have been taken from your account!");
            return;
        }
        else {
            p.sendMessage(ChatColor.RED + "ECONOMY ISNT WORKING RIGHT! Please contact a server admin right away!");
            return;
        }
    }
 
}

 

It's because after you deposit the money you have a return statement, it will never run the rest of your code. Take out all of the return statements from the onPlayerDeath method and it should work as intended.

 

@mazentheamazin Is there a way to stop the ballance going below 0? St3venAU

 

Get the balance beforehand, if its 5 or more then deduct 5, if its less then 5 then deduct whatever balance they have.

 

MaxNatural I dont have the api right now
But Make A If Statement To Check If a player has more than 5 coins

 

Herbert_The_Pervert Could you help me out more on this? I tried and failed ;(

 

MaxNatural Of Course I can.

MaxNatural Try if(VaultEco.hasUnder(1) To Return nothing then make an else statement to take the money away

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Where would this go. This is my first plugin with Vault Herbert_The_Pervert

St3venAU Code you show me with this code?

Code:java

package me.max;
 
import net.milkbowl.vault.economy.Economy;
import net.milkbowl.vault.economy.EconomyResponse;
 
import org.bukkit.Bukkit;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.PlayerDeathEvent;
import org.bukkit.plugin.RegisteredServiceProvider;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Eco extends JavaPlugin implements Listener {
 
    public static Economy econ = null;
    public static EconomyResponse r;
 
    public void onEnable() {
        if (!setupEconomy() ) {
            getLogger().severe(String.format("[%s] - Disabled due to no Vault dependency found!", getDescription().getName()));
            getServer().getPluginManager().disablePlugin(this);
            return;
        }
 
        getLogger().info("Plugin has been enabled!");
        Bukkit.getServer().getPluginManager().registerEvents(this, this);
    }
 
    private boolean setupEconomy() {
        if (getServer().getPluginManager().getPlugin("Vault") == null) {
            return false;
        }
        RegisteredServiceProvider<Economy> rsp = getServer().getServicesManager().getRegistration(Economy.class);
        if (rsp == null) {
            return false;
        }
        econ = rsp.getProvider();
        return econ != null;
    }
 
    @EventHandler
    public void onDeath(PlayerDeathEvent event) {
      //Get killed entity
      Player p = event.getEntity();
      //Get the killer
      Player killer = p.getKiller();
 
      if(killer != null) {
          EconomyResponse playerResponse;
          EconomyResponse killerResponse;
 
          //Withdraw money from the player
          playerResponse = econ.withdrawPlayer(p, 5D);
 
          if(playerResponse.transactionSuccess()) {
            p.sendMessage("§7[§4-§7]5 coins!");
 
            //Give the killer money
            killerResponse = econ.depositPlayer(killer, 5D);
 
            if(killerResponse.transactionSuccess()) {
                killer.sendMessage("§7[§a+§7]5 coins!");
            }
          }
      }
    }
}
 

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

MaxNatural
Most economy plugins do not allow players to go into the negative balances. If they do, its configurable.

 

mazentheamazin I will try it!

mazentheamazin It worked thanks!

EDIT by Moderator: merged posts, please use the edit button instead of double posting.