PvP Permissions

Hey all. I am working on a team based PvP plugin that has 2 teams which each have their own permission group using GroupManager.

What I am trying to figure out is how I can make it so one team can kill the other team but not members of the same team. Think of it as Red vs Blue for simplicity, red can kill blue and blue can kill red, but red can't kill red and blue can't kill blue.

I'd like to make it simple and just be able to put like pvp.red and pvp.blue for each group. Those would be permissions that make a team part of an actual side/team.

Any help would be greatly appreciated, thanks.

 

the problem that teammates can hit each other to create a scoreboard, I do not know exactly how to do it but there are plenty of tutorials how to do it

 

Listen for when players attack each other. Then, when the event is called, cancel if the attacker and the damaged player have the same permission (pvp.red or pvp.blue)

 

Beno65Dev
Not sure I follow you?

AndrewAnderVille
Yeah the part that confuses me really is how do I 'compare' the permissions? And if they happen to be part of the same team how do you block that damage from happening? Just return false?

Here is what I have:

Code:java

    public void onEntityDamage(EntityDamageEvent e) {
        if (e.getEntity() instanceof Player && e instanceof EntityDamageByEntityEvent && ((EntityDamageByEntityEvent)e).getDamager() instanceof Player) {
        // Permission check here
        }
        }

 

First get both entities as players. Then check if player one has "pvp.red". If player one does, check if player two does too. Do the same for both permissions. If both have the same permission, cancel the event which will stop the damage.

EDIT: Also, instead of using an EntityDamageEvent, I would use an EntityDamageByEntityEvent.

 

AndrewAnderVille
How does this look:

Code:java

    @EventHandler
    public void onEntityDamage(EntityDamageByEntityEvent e) {
        if (e.getEntity() instanceof Player && e instanceof EntityDamageByEntityEvent && ((EntityDamageByEntityEvent)e).getDamager() instanceof Player) {
            Player p = (Player) e.getEntity();
            Player hitter = (Player) e.getDamager();
 
            //Permission Check Red
            if(hitter.hasPermission("pvp.red")){
                if(p.hasPermission("pvp.red")){
                    e.setCancelled(true);
                }else{
                    return;
                }
            }
 
            //Permission Check Blue
            if(hitter.hasPermission("pvp.blue")){
                if(p.hasPermission("pvp.blue")){
                    e.setCancelled(true);
                }else{
                    return;
                }
            }
        }
    }
}

 

Looks good

 

AndrewAnderVille
So it seems PvP doesn't work at all now. Any ideas?

 

Not sure if this is the issue but try changing this

Code:java

if (e.getEntity() instanceof Player && e instanceof EntityDamageByEntityEvent && ((EntityDamageByEntityEvent)e).getDamager() instanceof Player) {

to this

Code:java

if (e.getEntity() instanceof Player && e.getDamager() instanceof Player) {

 

AndrewAnderVille
Same issue. To double check I removed the plugin and used the same 2 accounts in the same spot and they were able to damage each other. So it for sure has something to do with this. It looks right to me, not sure what the issue is.

Anything else you can think of?

I got it sort of working, but the first 2 hits against a player does nothing, then starts working.

Does anyone know how to fix this issue? Here is the full source to take a look at it all:

Code:java

package main.unity.pvp;
 
import java.util.logging.Logger;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.entity.EntityDamageByEntityEvent;
import org.bukkit.plugin.PluginDescriptionFile;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Main extends JavaPlugin {
 
public static Main plugin;
public final Logger logger = Logger.getLogger("Minecraft");
 
@Override
public void onEnable(){
PluginDescriptionFile pdfFile = this.getDescription();
this.logger.info(pdfFile.getName() + " Has Been Enabled." + pdfFile.getVersion());
}
 
public void onDisable(){
PluginDescriptionFile pdfFile = this.getDescription();
this.logger.info(pdfFile.getName() + " Has Been Disabled.");
}
 
 
@EventHandler
public void onEntityDamage(EntityDamageByEntityEvent e) {
if (e.getEntity() instanceof Player && e.getDamager() instanceof Player) {
Player p = (Player) e.getEntity();
Player hitter = (Player) e.getDamager();
 
//Permission Check Red
if(hitter.hasPermission("pvp.red")){
if(p.hasPermission("pvp.red")){
e.setCancelled(true);
}else{
return;
}
}
 
//Permission Check Blue
if(hitter.hasPermission("pvp.blue")){
if(p.hasPermission("pvp.blue")){
e.setCancelled(true);
}else{
return;
}
}
}
}
}
 

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Remove the else statements in

Code:java

if(p.hasPermission("pvp.red")){
e.setCancelled(true);
}else{
return;

and the other one

 

AndrewAnderVille
Yeah I was wondering if those were actually needed or not. So I have found the issues though. For some reason when you first join a server you have some sort of immunity or something? But that is why nothing was happening when I tested PvP.

As for the plugin itself, everything was correct I just was a derp and forgot to implement listener lol.

Thanks for all your help AndrewAnderVille!