Changing Items On Right Click Event

Ok, So I have started making this plugin and I am trying to make it so that when you right click the item it switches it. but when i right click the blaze rod, the item doesn't change and it gives me both messages telling me that it is parsing the code. I have tried turning it to boolean and returning it differently but it is switching between the two items, one might work but the other won't.


Code:
For Disabling Stacker

Code:java

package Stacker;
 
import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;
 
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.Action;
import org.bukkit.event.player.PlayerInteractEvent;
import org.bukkit.inventory.ItemStack;
import org.bukkit.inventory.meta.ItemMeta;
 
public class StackerDisable implements Listener {
 
    public ItemStack setMeta(ItemStack material, String name , List<String> lore, String string) {
        if(((material == null) || material.getType() == Material.AIR) || (name == null && lore == null))
 
            return null;
 
        ItemMeta im = material.getItemMeta();
        if (name != null)
            im.setDisplayName(name);
        if(lore != null) {
            im.setLore(lore);
 
        material.setItemMeta(im);
        return material;
 
        }
        return material;   
    }
 
    public List<Player> ds = new ArrayList<Player>();
    public List<Player> es = new ArrayList<Player>();
 
 
    public ItemStack DisableStacker = setMeta(new ItemStack(Material.BLAZE_ROD), (ChatColor.RED + "Disable Stacker"),
            Arrays.asList(ChatColor.GREEN + "Right Click To Disable Stacker"), (ChatColor.GREEN + "Stacker Is Currently Enabled"));
 
    public ItemStack EnableStacker = setMeta(new ItemStack(Material.STICK), (ChatColor.GREEN + "Enable Stacker"),
            Arrays.asList(ChatColor.GREEN + "Right Click To Enable Stacker"), (ChatColor.GREEN + "Stacker Is Currently " + ChatColor.RED + "Disabled"));
 
 
    @EventHandler
    public void onStackerDisable(PlayerInteractEvent event) {
        Player player = event.getPlayer();
        if(player.getItemInHand().equals(DisableStacker) && (event.getAction() == Action.RIGHT_CLICK_AIR)) {
                player.getInventory().remove(DisableStacker);
                player.updateInventory();
                player.getInventory().addItem(EnableStacker);
                player.updateInventory();
                player.sendMessage(ChatColor.RED + "Stacker Disabled");
 
 
        }
        return;
 
 
 
    }
 
 
 
}
 

For Enabling Stacker:

Code:java

package Stacker;
 
import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;
 
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.Action;
import org.bukkit.event.player.PlayerInteractEvent;
import org.bukkit.inventory.ItemStack;
import org.bukkit.inventory.meta.ItemMeta;
 
public class StackerEnable implements Listener {
 
 
    public ItemStack setMeta(ItemStack material, String name , List<String> lore, String string) {
        if(((material == null) || material.getType() == Material.AIR) || (name == null && lore == null))
 
            return null;
 
        ItemMeta im = material.getItemMeta();
        if (name != null)
            im.setDisplayName(name);
        if(lore != null) {
            im.setLore(lore);
 
        material.setItemMeta(im);
        return material;
 
        }
        return material;   
    }
 
    public List<Player> ds = new ArrayList<Player>();
    public List<Player> es = new ArrayList<Player>();
 
 
    public ItemStack DisableStacker = setMeta(new ItemStack(Material.BLAZE_ROD), (ChatColor.RED + "Disable Stacker"),
            Arrays.asList(ChatColor.GREEN + "Right Click To Disable Stacker"), (ChatColor.GREEN + "Stacker Is Currently Enabled"));
 
    public ItemStack EnableStacker = setMeta(new ItemStack(Material.STICK), (ChatColor.GREEN + "Enable Stacker"),
            Arrays.asList(ChatColor.GREEN + "Right Click To Enable Stacker"), (ChatColor.GREEN + "Stacker Is Currently " + ChatColor.RED + "Disabled"));
 
 
    @EventHandler
    public void onStackerEnable(PlayerInteractEvent event) {
        Player player = event.getPlayer();
        if(player.getItemInHand().equals(EnableStacker) && (event.getAction() == Action.RIGHT_CLICK_AIR)) {
                player.getInventory().remove(EnableStacker);
                player.updateInventory();
                player.getInventory().addItem(DisableStacker);
                player.updateInventory();
                player.sendMessage(ChatColor.GREEN + "Stacker Enabled");
 
 
        }
 
        return;
 
    }
 
 
}
 

Thanks guys and any help would be appreciated.

Bump?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Wait, what are you trying to archive? You want to change a item or its name and item meta? And what happens with blazerod?

 

I would probably try and do something more like this:

on the event:
if (player.getinventory.getItemInHand.getItemMeta.getName.equals("WhatEver") {
player.getinventory.getitemeinhand.getitemmeta.setname("Other");
}
else if (player.getinventory.getiteminhand.getitemmeta.getname.equals("Other") {
player.getinventory.getiteminhand.getitemmeta.setname("WhatEver") {
}

 

Try to add this:

Code:java

public class StackerDisable extends JavaPlugin implements Listener {
//extends JavaPlugin so you can add onEnable(){!
 

And then you wanna add:

Code:java

public void onEnable(){
getServer().getPluginManager().registerEvents(this, this);
}
//This will make it so the plugin can Register Events!
 

And the same on StackerEnabled!

Code:java

public class StackerEnabled extends JavaPlugin implements Listener{
 

And:

Code:java

public void onEnable(){
getServer().getPluginManager().registerEvents(this, this);
}