Solved Problems with shields

Hi, so I am coding a plugin and one of the abilities is that when you block with a wood sword you are in shield mode until you block again. For some reason this code doesn't work:

Code:java

package me.thesamster8.heroesskills.Skills1;
 
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.Action;
import org.bukkit.event.entity.EntityDamageByEntityEvent;
import org.bukkit.event.player.PlayerInteractEvent;
import org.bukkit.inventory.ItemStack;
 
public class Shield implements Listener {
 
 
 
    private boolean shielded = false;
 
    @EventHandler
    public void onBlock(PlayerInteractEvent e) {
        Player p = e.getPlayer();
        if(p.getItemInHand()==new ItemStack(Material.WOOD_SWORD)){
            if(e.getAction()==Action.RIGHT_CLICK_AIR || e.getAction()==Action.RIGHT_CLICK_BLOCK) {
                shielded = true;
                p.sendMessage(ChatColor.GREEN + "Shielded Mode: On");
            }
            else if(shielded) {
                shielded = false;
                p.sendMessage("Shielded Mode: Off");
            }
        }
    }
 
            @EventHandler
            public void onDamage(EntityDamageByEntityEvent e) {
                Player p = (Player) e.getEntity();
                Player d = (Player) e.getDamager();
                if(shielded) {
                    e.setCancelled(true);
                }
        }
    }

And I have registered my events in my Main class

 

ZodiacTheories
All of it doesn't work or what exactly happens?
I'd add this between 23 and 24:

Code:java

if(!shielded)

 

First off, you need to rethink your use of that boolean, especially considering it is a global instance variable because if your code did work then if I were to right click and activate the shield, then it would be active for everyone and also anyone who right clicks with their sword would also deactivate the shield. To fix this problem you would need to look into the use of a List.

Next thing I would say is that when checking the item in their hand, the way I would do it is I would first check they have something in their hand (hint: It's null if they aren't holding anything). After that I would then get the type of the item in their hand and then do a simple enum check with the Material for wooden sword. Then you would do your stuff with the list.

With your damage event, you are casting the entities to players without even checking that it was a player that either did the damage, or received it. You should probably add those checks before casting. After that you can do you boolean check with your List which you would have implemented by then and cancel the event accordingly.

If your code does not appear to be running at all, then add debug messages. One for each block of code. I.e one at the start of the event to see if it is being called, one in the first if statement, one in the second if statement and if you really feel like it, then one in the else statement. From this you can tell what code is being run or not.

 

RAFA_GATO_FOFO

Updated code as you suggested.

Nothing happens when I right click a wood sword. This is the only error that appears in the console:

Code:

04.06 21:56:33 [Server] WARN No compatible nms block class found.

Thanks

theguynextdoor

Woah, thanks for that detailed response

For the first bit, I was just testing this ability to see if it would work in general, I am planning to add a list later. Second bit: Ill try that. Third: Ill try that. Fouth: Was going to do that

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

It's a WorldEdit warning, basically informing you that the plugin is out of date.

 

fireblast709

oh lol ty

fireblast709 theguynextdoor RAFA_GATO_FOFO

Thanks guys - especially theguynextdoor!

For anybody wondering, here is the solution:

Code:java

package me.thesamster8.heroesskills.Skills1;
 
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.entity.Entity;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.Action;
import org.bukkit.event.entity.EntityDamageByEntityEvent;
import org.bukkit.event.player.PlayerInteractEvent;
 
public class Shield implements Listener {
 
 
 
    private boolean shielded = false;
 
    @EventHandler
    public void onBlock(PlayerInteractEvent e) {
        Player p = e.getPlayer();
        if(p.getItemInHand()==null) return;
        else {
            if(p.getItemInHand().getType()==Material.WOOD_SWORD) {
            if(e.getAction()==Action.RIGHT_CLICK_AIR || e.getAction()==Action.RIGHT_CLICK_BLOCK) {
                if(!shielded) {
                shielded = true;
                p.sendMessage(ChatColor.GREEN + "Shielded Mode: On");
            }
            else if(shielded) {
                shielded = false;
                p.sendMessage(ChatColor.RED + "Shielded Mode: Off");
            }
        }
        }
    }
    }
 
            @EventHandler
            public void onDamage(EntityDamageByEntityEvent e) {
                Entity p = e.getEntity();
                Entity d = e.getDamager();
                if(p instanceof Player) {
                    p = (Player) e.getEntity();
                if(shielded) {
                    e.setCancelled(true);
                }
        }
    }
}

EDIT by Moderator: merged posts, please use the edit button instead of double posting.